BUG: objects removed from the diagram are still in the root element

[Simone Di Cola]

As in the subject,

 I've just noticed that in removing an element on the diagram, the pictogram element is removed correctly, while its relative business object is not. 

FIX:

override the postRemove method and call EcoreUtil.delete(deletedBusinessObject);

Simone

[Simone Di Cola]

MAybe this makes the FIX a little bit clearer:

@Override

public void remove(IRemoveContext context) {

Validate.notNull(context);

Validate.notNull(context.getPictogramElement());

try {

deletedBusinessObject = (EObject) getBusinessObjectForPictogramElement(context.getPictogramElement());

markers = MarkerManager.findMarkers(null, EcoreUtil.getIdentification(deletedBusinessObject), false, IResource.DEPTH_ZERO);

super.remove(context);

} catch (CoreException e) {

LOGGER.error("ERROR in MarkerManager.findMarkers @delete", e);

}

}

@Override

public void postRemove(IRemoveContext context) {

try {

EcoreUtil.delete(deletedBusinessObject);

MarkerManager.destroyMarker(markers);

} catch (CoreException e) {

LOGGER.error("ERROR in MarkerManager.destroyMarker @postDelete", e);

[Jörg Reichert]

Please notice, there is a semantic difference between remove and delete in Graphiti: http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.graphiti.doc%2Fresources%2Fdocu%2Fgfw%2Fremove-and-delete-feature.htm

Joerg

--
Sie erhalten diese Nachricht, weil Sie in Google Groups E-Mails von der Gruppe "spray-user" abonniert haben.
Wenn Sie sich von dieser Gruppe abmelden und keine E-Mails mehr von dieser Gruppe erhalten möchten, senden Sie eine E-Mail an spray-users...@googlegroups.com.
Weitere Optionen finden Sie unter https://groups.google.com/d/optout.

[Simone Di Cola]

Opsss