No dismiss() method for alerts, or how to send a pull request

26 views
Skip to first unread message

Adam Victor Nazareth Brandizzi

unread,
Jan 13, 2012, 12:31:55 PM1/13/12
to splinter-developers
Hello, all!

The AlertElement does not have a dismiss() method as stated by the
doc. I needed it, so I added the method and a test to Splinter.

I though about send a pull request on github; however, I think it
would be nicer to ask you all if it would be accepted. There are some
pull requests waiting for approval and I would not like to clutter it
anymore. So would such a pull request desirable? Or would you prefer
to repair yourselves the bug?

(Sorry for such an unusual question. I am not used to GitHub and its
netiquette)

Thanks in advance!

Francisco Souza

unread,
Jan 13, 2012, 12:40:11 PM1/13/12
to splinter-...@googlegroups.com
Hey there,
send the pull request, please. I hope I can dedicate some time to splinter next weekend.

Thanks in advance for the collaboration :)
--
Francisco Souza

Adam Victor Nazareth Brandizzi

unread,
Jan 13, 2012, 12:45:51 PM1/13/12
to splinter-...@googlegroups.com
On Fri, Jan 13, 2012 at 3:40 PM, Francisco Souza <f...@souza.cc> wrote:
> Hey there,
> send the pull request, please. I hope I can dedicate some time to splinter
> next weekend.
>
> Thanks in advance for the collaboration :)

No problem, I am really thankful for splinter itself :)

--
Adam Victor Nazareth Brandizzi
http://brandizzi.googlepages.com/

Reply all
Reply to author
Forward
0 new messages