Created Issue: Content within HTML conditional comments is ignored [6373]

[sparkviewengine Issue Tracker Rss Feed]

What happens: When content is placed within an HTML conditional comment, it is not evaluated by Spark and instead output as a literal string.
What's expected: Content within an HTML conditional comment should be evaluated by Spark.

Example code to reproduce:
<!--[if IE 6]>
<link type="text/css" rel="stylesheet" media="screen" href="~/css/ie.6.css">
<![endif]-->

Expected Output:
<!--[if IE 6]>
<link type="text/css" rel="stylesheet" media="screen" href="http://mysiteroot.com/css/ie.6.css">
<![endif]-->

Actual Output:
<!--[if IE 6]>
<link type="text/css" rel="stylesheet" media="screen" href="~/css/ie.6.css">
<![endif]-->


I appreciate why this is happening - commented content should be ignored, but conditional comment should ideally be handled as a special case.


Further Information:
* Conditional Comments - http://en.wikipedia.org/wiki/Conditional_comment and http://www.quirksmode.org/css/condcom.html

URL: http://sparkviewengine.codeplex.com/workitem/6373

[Adam Schroder]

Will spark even replace "~" in a attribute??

I'm not sure that it would?

2010/7/1 Asbjørn Ulsberg <asbj...@gmail.com>

Yet another use case that demands a different default comment mechanism, as the previously discussed {#...#} construct (or something similar). With it, these conditional comments wouldn't be an issue.


-Asbjørn

--
You received this message because you are subscribed to the Google Groups "Spark View Engine Dev" group.
To post to this group, send email to spar...@googlegroups.com.
To unsubscribe from this group, send email to spark-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/spark-dev?hl=en.

[Louis DeJardin]

Yep, it will expand leading ~’s in the html attributes that are known to be uri values.

[Adam Schroder]

Fricken wicked Louis!!!!

[Louis DeJardin]

Thanks. :)

 

There’s another feature hidden in ~ that you can find buried in the docs for the config settings.

 

http://sparkviewengine.com/documentation/configuring#Sparksettingsinconfigfile

 

In the spark/pages/resources section you can change your production config to replace various ~/xxx prefixes with some alternate value. Putting content on cdn, for example. Works with ISparkSettings in code also.