Created Issue: DefaultDescriptorBuilder: Empty prefix is handled incorrectly [6141]

0 views
Skip to first unread message

sparkviewengine Issue Tracker Rss Feed

unread,
May 20, 2010, 1:42:03 PM5/20/10
to spar...@googlegroups.com
In commit 7cb2aa3967df572901f2, DefaultDescriptorBuilder was changed to use <use master="foobar"/>-tags with an optional prefix (ie. <s:use master="foobar"/>). However, the parser will look for the colon whenever the prefix is non-null, that is: also if it is empty. An empty prefix should be considered "no prefix" at all. The problem breaks nested master pages (see the three pass example on the web site), the <use master=""/> tag in Application.spark is not recognized anymore.

The fix is pretty easy: only parse the colon if the prefix is not null and not empty.

The attached git patch fixes the problem and adds a unit test that reveals the bug.

URL: http://sparkviewengine.codeplex.com/WorkItem/View.aspx?WorkItemId=6141

--
You received this message because you are subscribed to the Google Groups "Spark View Engine Dev" group.
To post to this group, send email to spar...@googlegroups.com.
To unsubscribe from this group, send email to spark-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/spark-dev?hl=en.

Reply all
Reply to author
Forward
0 new messages