New macOS build: Qt 6, dual architecture, notarized

[Nir Arbel]

This build has a lot of changes in it, including my first attempt at a full port to Qt 6. It's built for both intel and apple silicon, and notarized to boot.

https://drive.google.com/file/d/1Zh1ap3P-wGCBzdz2R1JeMlt-Wosjb_M-/view?usp=share_link

Other changes include general improvements to performance, a fix for the problem of the add shared folder dialog disappearing, and the list of shared folders are now sorted alphabetically.

[Nir Arbel]

If anyone's used this build for a while without any problems please let me know, I want to post it to the download page if I can.

[anencephalic]

I ran into a problem.  I just tried 2023-1-3 for the first time on an Intel Macbook.  I started out with Options->File Sharing->Share Folder->Add Shared Folder and the dialog stayed on top no matter how hard I tried to get it to pop under.  However, when I clicked Select Folder, selected a folder and clicked Open, the app crashed due to a SIGSEGV.  I've attached the problem report.

[anencephalic]

I restarted the app, only this time I didn't try to get the Add Shared Folder dialog to pop under.  Last time I tried various combinations of minimizing the app, popping other apps on top of it, etc.  This time I was able to add the shared folder without crashing the app.  I'll see if there's a series of steps that lead to the crash.

[anencephalic]

I am able to consistently (three times now) get the app to crash with the following steps:

1 - Start the app

2 - Options->File Sharing->Share Folder->Add Shared Folder

3 - Minimize the app (click upper left yellow button with minus sign).  Add Shared Folder dialog remains displayed even though the main app window is no longer visible.

4 - Click Select Folder

5 - Select a folder

6 - Click Open.  Selection dialog goes away.  The selected folder name appears in the Add Shared Folder dialog.

7 - Click OK.

8 - App crashes with SIGSEGV.

[anencephalic]

I tried the same steps on 2021.2.6 and the new shared folder was successfully added without crashing the app.

[Nir Arbel]

Thanks, this should fix the issue: https://drive.google.com/file/d/1V-teBr6mo9f1WcvVVZq0eYbsjjYy_6cc/view?usp=share_link

[anencephalic]

I agree that the add shared folder pop-under crash is fixed.  I can’t reproduce it in 2023.1.9 no matter how hard I try.  Nice.

There’s another pop-under problem with the User Notes dialog.  It can get lost, and if you try to unhide it by re-clicking Edit User Note, nothing happens.  It seems it should pop back to the top like the Gift Privileges and Set User’s Groups dialogs do.  Otherwise you have to go hunting for it.

If you want to look at an another (and old) problem, search results don’t display the size of many large files, usually video.  The cell in that column is often blank, especially for 4K videos.  The largest value I see displayed is around 2.1 GB (31 bits).  My guess is that column is formatted as a signed 32-bit integer but should be able to display 64-bit values.  I anticipate petabyte metaverse files in our future :).

I'll keep testing.

[Nir Arbel]

That's great, thank you. This should fix the file size issue in search results. I also made all dialogs stay on top so they won't disappear behind other application windows anymore.

https://drive.google.com/file/d/1a9npAo5jIqqYExqXYhBsoFmnZUtA-kJI/view?usp=share_link

[anencephalic]

File sizes in search results for large files looks good now. Thanks.  

I noticed that the file size column for empty files is blank.  If someone shares a 1 byte file, a one is displayed, but if the file is empty. nothing is displayed.  It would be ideal if a zero were displayed instead so one knows not to bother selecting empty files for download.  

Downloading zero-length files is interesting.  The Transfers->Downloads window shows the file as instantly completed although no file or folder is created in the downloads folder as a result.  This could be confusing for users who wonder where their “downloaded” file is.  I’m not sure this is worth changing though.

Pop-up dialogs are much harder to lose now.  User Notes, Gift Privileges, Excluded Download Extensions and Filter Help stay on top no matter what I try to pop over them, but User Groups for [user] and Chat Filter Words can still be covered by the main app window.  User Groups pops back to the top when reselected but Chat Filter Words does not.

Transfer->Downloads->[right click on user]->Notify Me When seems broken.  No submenu appears, even when you click it, so you can’t select a notification type.

I’ll test some more tomorrow.

[Nir Arbel]

Here we go: https://drive.google.com/file/d/1WuNyoPL_hH7Ls5wJSLd9Iep3YNI07RdU/view?usp=share_link

Zero file sizes should show up everywhere now. I also changed a few more dialogs to always show on top including the ones you mentioned. I made sure Notify me... doesn't appear in the download context menu if there are no ongoing transfers. If there are, it will contain options to receive download complete notifications as before.

The zero file issue actually is a bug. There's code to create an empty file but it doesn't work if the target folder isn't there yet. That should be fixed now as well.

Thanks, Nir

[anencephalic]

All of the last batch of fixes look good.  It’s nice to see all the file size fields filled in and empty files handled properly.  Thank you.  If you’re willing to keep going, so am I.

I found some Transfers->Downloads context menu issues with Open File and Open Folder.

1 - If you select a user folder, sub-folder or file and click Open, but that item doesn’t exist in the Complete folder, nothing happens.  The Open Folder/File menu entries should probably be suppressed in these cases.
2 - If you select a user folder with multiple sub-folders and click Open Folder, one (always the topmost?) of the sub-folders gets opened. I think that the user folder itself should be opened in all cases where it’s the selected item.

3 - For files that are partially downloaded, Open File is suppressed.  I often want to play a partial to see if it’s fake or corrupted.  It would be nice if this were doable through the GUI.

I'm running out of things to test.  Have any suggestions?

[Nir Arbel]

Honestly the main thing I was worried about is bugs in the new build that aren't in the official builds. I changed a whole lot of stuff to get it to work with Qt6 and there are a few other low-level changes in there so I was a little nervous about putting it on the download page. It sounds like you're not running into anything like that though, so I think I'm gonna go ahead and do that. I'll look into the new list of bugs you posted soon.

Thanks, Nir

[anencephalic]

I think the app is in really good shape overall.  For me, it's every bit as functional as the old (2021?) release, and performs better.  The old client would eventually get sluggish, display the twirling beach ball every 20 seconds and have to be restarted.  I haven't seen any sign of that on these newer builds.  IMO, that's the best fix you made.  Except for the shared folder dialog crash, all the other stuff I've reported was pretty nit-picky by comparison. Thanks for fixing them though :).

[Nir Arbel]

That's really good to hear, thank you for all your help!