Version naming/branding for in-house builds

[Christian Svensson]

Hello,

An organization I am part of has a fork of sonic-buildimage that we use for in-house builds that include patches that have not been accepted upstream yet.

We follow the same branch naming as Azure/sonic-buildimage (e.g. 202111) and we also use the same Azure Pipelines[1] scripts to run our builds.

The issue we face is that this results in images with version information extremely similar to official upstream images.

Example: 202012.19-08de2b148 is our build version, while the latest upstream is 202012.63280-1eec2bc25.

The for an operator that is more confusing than it needs to be.

We would like to be able to set an environment variable to "brand" or tag a version as a certain organization.

My current hack is this[2] which changes the format to ${branch_name}-${BUILD_ORG}.${BUILD_NUMBER}-${commit} but

I would be happy with any format that the community accepts. My biggest concern about making something like this up for

myself is to break potential version string parsing that may happen now or in the future.

Thoughts?

[1] https://github.com/kamelnetworks/sonic-buildimage/blob/05f42e03abe91b7beb0ddfa877a8e83be534e7d4/.azure-pipelines/kamel-build.yml

[2] https://github.com/kamelnetworks/sonic-buildimage/commit/9f27d4d001cb2cee07d39e2364151c8ee70234d9

Regards,

[Yuval-Mellanox]

will overriding the $SONIC_IMAGE_VERSION during the make suffice your requirement ?

https://github.com/Azure/sonic-buildimage/blob/4acdc2a81ec4b7ba43a491b541c0e5768100ed60/slave.mk

[Christian Svensson]

Hi,

Thanks for the suggestion!

In theory yes that would work - but In that case I would have to introduce an extra script step in the CI build that basically does what sonic_get_version does in order to calculate what to set that variable to.

Seems like a lot of extra work, it's easier to carry a patch to modify functions.sh in that case.

--
You received this message because you are subscribed to the Google Groups "sonicproject" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonicproject...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonicproject/5d8fc7ca-9bba-42f7-b22f-49b3dc12ec87n%40googlegroups.com.