Question on ACL-based rate limiting, Mirroring, L2 (202012 roadmap item)

[Max Chen]

Hi folks:

Does anyone can help me to understand the item "ACL-based rate limiting, Mirroring, L2"?

Does that means the use L2 ACL (ex DA/SA) to specify the flow that should be rate limited with configured rate?

In other words, the L2 meand L2-ACL?

Thank you.

/Max

[Ben Gale]

Max,

I don't think this feature is correctly stated in the 202012 lineup. More accurate would be as below: -

ACL enhancements: Policing, DHCP/PCP remark, L2

Use Flow-based Services framework to add ACL enhancements, including L2 ACLs, QoS re-marking and policing, and mirroring match enhancements.

HLD should be available in the next few weeks.

Ben

--
You received this message because you are subscribed to the Google Groups "sonicproject" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonicproject...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonicproject/db01697c-910a-439f-b0c1-82fe7b81cd27o%40googlegroups.com.

[Max Chen]

Thank you Ben.

It seems we will have enhancement on ACL to include L2/L3 matching field for remarking, policing, mirroring actions. 

That should make the ACL and QoS more complete.

Thank you.

Ben Gale於 2020年8月18日星期二 UTC+8上午12時00分26秒寫道：

Max,

I don't think this feature is correctly stated in the 202012 lineup. More accurate would be as below: -

ACL enhancements: Policing, DHCP/PCP remark, L2

Use Flow-based Services framework to add ACL enhancements, including L2 ACLs, QoS re-marking and policing, and mirroring match enhancements.

HLD should be available in the next few weeks.

Ben

On Mon, Aug 17, 2020 at 4:08 AM Max Chen <strong...@gmail.com> wrote:

Hi folks:

Does anyone can help me to understand the item "ACL-based rate limiting, Mirroring, L2"?

Does that means the use L2 ACL (ex DA/SA) to specify the flow that should be rate limited with configured rate?

In other words, the L2 meand L2-ACL?

Thank you.

/Max

--
You received this message because you are subscribed to the Google Groups "sonicproject" group.

To unsubscribe from this group and stop receiving emails from it, send an email to sonicp...@googlegroups.com.

[balajinath]

//Reviving the old thread

Hi,

     Can somebody provide more detail on L2 ACL support current status on 202012 and Master branch? When I run sonic-mgmt test suite's spytest  for ACL

(sonic-test/sonic-mgmt/spytest/tests/qos/acl/test_acl.py).  It is failing because   ACL table L2 is not supported in ACL/orchagent  codebase.  I have

show the config being done by script, Error reported by orchagent and code snippet of supported ACL  table type.  If L2 ACL is not supported in sonic code

yet then I am wondering why this test cases added to spytest .

L2  table config block from the script:

"ACL_TABLE": {

        "L2_MAC_EGRESS": {

            "policy_desc": "L2_MAC_EGRESS",

            "ports": [

                "PortChannel1"            ],

            "stage": "EGRESS",

            "type": "L2"

        }

    },

Error  from orchagent:

<snip>

root@sonic:/home/cisco# show logging  | grep L2_MAC

Apr 15 23:13:25.643717 sonic ERR swss#orchagent: :- doAclTableTask: Failed to process ACL table L2_MAC_EGRESS type

Apr 15 23:13:25.643717 sonic ERR swss#orchagent: :- doAclTableTask: Failed to create ACL table L2_MAC_EGRESS, invalid configuration

</snip>

<snip>

static acl_table_type_lookup_t aclTableTypeLookUp =

{

    { TABLE_TYPE_L3,                    ACL_TABLE_L3 },

    { TABLE_TYPE_L3V6,                  ACL_TABLE_L3V6 },

    { TABLE_TYPE_MIRROR,                ACL_TABLE_MIRROR },

    { TABLE_TYPE_MIRRORV6,              ACL_TABLE_MIRRORV6 },

    { TABLE_TYPE_MIRROR_DSCP,           ACL_TABLE_MIRROR_DSCP },

    { TABLE_TYPE_CTRLPLANE,             ACL_TABLE_CTRLPLANE },

    { TABLE_TYPE_DTEL_FLOW_WATCHLIST,   ACL_TABLE_DTEL_FLOW_WATCHLIST },

    { TABLE_TYPE_DTEL_DROP_WATCHLIST,   ACL_TABLE_DTEL_DROP_WATCHLIST },

    { TABLE_TYPE_MCLAG,                 ACL_TABLE_MCLAG }

};

</snip>

Thanks,

-Balaji