sonic compilation error after introducing new parameter

16 views
Skip to first unread message

Kiran N

unread,
Jan 8, 2023, 11:36:19 PM1/8/23
to sonicp...@googlegroups.com, soni...@lists.sonicfoundation.dev
Hi Sonic team, 

I am introducing new parameter in SONIC for the function create_acl_table and create_acl_entry to get the EID and GID values of ACL from BROADCOM_SAI back to SONIC. But after introducing the new parameter I am getting below mentioned compilation error in saimetadata.c which is an autogenerated file. As per my understanding This file is generated based on .h files in sonic-Sairedis/SAI/inc. As per this I updated the parameter in saiacl.h as well. but still getting below error. Can someone help here.

make[5]: Leaving directory '/sonic/src/sonic-sairedis/SAI/meta'
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -ansi  -g -O2 -fdebug-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -c -o ../SAI/meta/libsaimetadata_la-saimetadata.lo `test -f '../SAI/meta/saimetadata.c' || echo './'`../SAI/meta/saimetadata.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -ansi -g -O2 -fdebug-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -c ../SAI/meta/saimetadata.c  -fPIC -DPIC -o ../SAI/meta/.libs/libsaimetadata_la-saimetadata.o
../SAI/meta/saimetadata.c: In function 'sai_metadata_generic_create_SAI_OBJECT_TYPE_ACL_TABLE':
../SAI/meta/saimetadata.c:94759:91: warning: passing argument 2 of 'sai_metadata_sai_acl_api->create_acl_table' makes pointer from integer without a cast [-Wint-conversion]
     return sai_metadata_sai_acl_api->create_acl_table(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
                                                                                           ^~~~~~~~~
../SAI/meta/saimetadata.c:94759:91: note: expected 'uint32_t *' {aka 'unsigned int *'} but argument is of type 'sai_object_id_t' {aka 'long unsigned int'}
../SAI/meta/saimetadata.c:94759:114: warning: passing argument 4 of 'sai_metadata_sai_acl_api->create_acl_table' makes integer from pointer without a cast [-Wint-conversion]
     return sai_metadata_sai_acl_api->create_acl_table(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
                                                                                                                  ^~~~~~~~~
../SAI/meta/saimetadata.c:94759:114: note: expected 'uint32_t' {aka 'unsigned int'} but argument is of type 'const sai_attribute_t *' {aka 'const struct _sai_attribute_t *'}
../SAI/meta/saimetadata.c:94759:12: error: too few arguments to function 'sai_metadata_sai_acl_api->create_acl_table'
     return sai_metadata_sai_acl_api->create_acl_table(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
            ^~~~~~~~~~~~~~~~~~~~~~~~
../SAI/meta/saimetadata.c: In function 'sai_metadata_generic_create_SAI_OBJECT_TYPE_ACL_ENTRY':
../SAI/meta/saimetadata.c:94854:91: warning: passing argument 2 of 'sai_metadata_sai_acl_api->create_acl_entry' makes pointer from integer without a cast [-Wint-conversion]
     return sai_metadata_sai_acl_api->create_acl_entry(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
                                                                                           ^~~~~~~~~
../SAI/meta/saimetadata.c:94854:91: note: expected 'uint32_t *' {aka 'unsigned int *'} but argument is of type 'sai_object_id_t' {aka 'long unsigned int'}
../SAI/meta/saimetadata.c:94854:114: warning: passing argument 4 of 'sai_metadata_sai_acl_api->create_acl_entry' makes integer from pointer without a cast [-Wint-conversion]
     return sai_metadata_sai_acl_api->create_acl_entry(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
                                                                                                                  ^~~~~~~~~
../SAI/meta/saimetadata.c:94854:114: note: expected 'uint32_t' {aka 'unsigned int'} but argument is of type 'const sai_attribute_t *' {aka 'const struct _sai_attribute_t *'}
../SAI/meta/saimetadata.c:94854:12: error: too few arguments to function 'sai_metadata_sai_acl_api->create_acl_entry'
     return sai_metadata_sai_acl_api->create_acl_entry(&meta_key->objectkey.key.object_id, switch_id, attr_count, attr_list);
            ^~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:645: ../SAI/meta/libsaimetadata_la-saimetadata.lo] Error 1

--
KIRAN.N
9900079546
Reply all
Reply to author
Forward
0 new messages