RE: EVPN code review

[Pavel Shirshov]

Hi Prince,

 

I’d recommend to send this https://github.com/Azure/sonic-buildimage/pull/4806 to frr team for review. For that the patch must to be rebased to FRR master.

 

Thanks

-----Original Appointment-----
From: Prince Sunny <Prince...@microsoft.com>
Sent: Wednesday, September 16, 2020 8:37 AM
To: Tapash Das; Rajesh Sankaran; ben.gale; Alfred Ma; Laveen Thamilchelvam; Madhu Pal; devel...@aviznetworks.com
Cc: sonic-evpn-workgroup; Rajesh Pukhraj Jain; Qi Luo; Ying Xie; Pavel Shirshov; Zhenggen Xu; Guohan Lu; Xin Liu (CLOUD); Nikhil Kelapure; Rita Hui; Phanira...@dell.com; Mahalinga, Venkatesan; gord_chen 陳冠億
Subject: EVPN code review
When: Occurs every Friday effective 9/18/2020 until 10/16/2020 from 9:00 AM to 10:00 AM (UTC-08:00) Pacific Time (US & Canada).
Where: Microsoft Teams Meeting

 

 

PRs:

 

 

 

Repo	Description	PR ID	Owner	Reviewers	Status
HLDs
SONiC	EVPN VXLAN HLD	https://github.com/Azure/SONiC/pull/437	Rajesh S	EVPN WG	Open
SONiC	Kernel programming performance enhancement - Netlink API	https://github.com/Azure/SONiC/pull/493	Naveen S	Qi Luo	Open
SAI PRs
SAI	Improved support for p2p tunnels (Add DIP in the tunnel sai attribute)	https://github.com/opencomputeproject/SAI/pull/1025	Vissu		Merged
SAI	Support for per-vlan traps (incl. the ARP/ND PR)	https://github.com/opencomputeproject/SAI/pull/1092	Jai		Merged
SAI	Support for static FDB Entries to allow MAC Move	https://github.com/opencomputeproject/SAI/pull/1024	Vissu		Merged
SONiC Code PRs
sonic-swss-common	EVPN VXLAN DB support	https://github.com/Azure/sonic-swss-common/pull/339	Rajesh S	Prince	Merged
sonic-swss-common	Support to register for RAW Netlink Msg handling to support EVPN Type5 route	https://github.com/Azure/sonic-swss-common/pull/353	Kishore K	Qi Luo	Open
sonic-swss-common	Warm Reboot changes for EVPN	https://github.com/Azure/sonic-swss-common/pull/350	Rajesh S	Qi Luo/Ying/Dong	Open
sonic-utilities	VXLAN config and show utilities	https://github.com/Azure/sonic-utilities/pull/870	Rajesh S	Gord Chen/Prince	Open
sonic-swss	Layer 2 Forwarding Enhancements	https://github.com/Azure/sonic-swss/pull/885	Anil P	Xu/Prince	Rebase
sonic-swss	VxlanOrch and PortsOrch changes	https://github.com/Azure/sonic-swss/pull/1264	Rajesh S	Gord Chen/Prince	Rebase
sonic-swss	VxlanMgr changes	https://github.com/Azure/sonic-swss/pull/1266	Rajesh S	Gord Chen/Prince	Open
sonic-swss	Pytest for VxlanOrch, Portsorch and VxlanMgr	https://github.com/Azure/sonic-swss/pull/1318	Rajesh S		Open
sonic-swss	L3 VXLAN changes	https://github.com/Azure/sonic-swss/pull/1267	Tapash D	Prince	Open
sonic-swss	PY Test for L3 VxLAN	https://github.com/Azure/sonic-swss/pull/1330/	Tapash D		Open
sonic-swss	FdbOrch changes	https://github.com/Azure/sonic-swss/pull/1275	Pankaj J	Gord Chen/Xu/Prince	Rebase
sonic-swss	ARP suppression changes		Karthikeyan		To be filed
sonic-swss	Fdbsyncd changes	https://github.com/Azure/sonic-swss/pull/1276	Kishore K	Gord Chen/Xu/Prince	Rebase
sonic-swss	Fpmsyncd changes for Type 5 routes	https://github.com/Azure/sonic-swss/pull/1326	Kishore K	Qi/Pavel/Prince	Open
sonic-swss	Warm Reboot changes for EVPN		Nikhil/Anil		To be filed
sonic-frr	FRR patch for Type 5 routes	https://github.com/Azure/sonic-buildimage/pull/4806	Kishore K	Pavel
sonic-linux-kernel	Linux kernel patch for control plane learnt fdb/neigh entries		Hasan		To be filed
	libnl/iproute2 changes for ARP suppression		Karthikeyan		To be filed

 

 

________________________________________________________________________________

Microsoft Teams meeting

Join on your computer or mobile app

Click here to join the meeting

Or call in (audio only)

+1 323-849-4874,,121342274#   United States, Los Angeles

Phone Conference ID: 121 342 274#

Find a local number | Reset PIN

Learn More | Meeting options

________________________________________________________________________________

 

[Prince Sunny]

Notes for 9/18:

 

PRs:

 

 

 

Repo	Description	PR ID	Owner	Reviewers	Status
HLDs

SONiC

EVPN VXLAN HLD

https://github.com/Azure/SONiC/pull/437

Rajesh S

EVPN WG

Open 9/18: Comments are being addressed

SONiC

Kernel programming performance enhancement - Netlink API

https://github.com/Azure/SONiC/pull/493

Naveen S

Qi Luo/Kumaresh

Open 9/18: Arp suppression requires nlapis, EVPN feature itself is not blocked.

Qi Luo/Kumaresh	Open

sonic-swss-common

Warm Reboot changes for EVPN

https://github.com/Azure/sonic-swss-common/pull/350

Rajesh S

Qi Luo/Ying/Dong/Heidi	Open 9/18: Currently addressing review-comments

sonic-utilities

VXLAN config and show utilities

https://github.com/Azure/sonic-utilities/pull/870

Rajesh S

Gord Chen/Prince/Madhu	Open

sonic-swss

Layer 2 Forwarding Enhancements

https://github.com/Azure/sonic-swss/pull/885

Anil P

Xu/Prince

Rebase 9/18: Recommend to split the PR. EVPN related changes are part PR 1275

sonic-swss

VxlanOrch and PortsOrch changes

https://github.com/Azure/sonic-swss/pull/1264

Rajesh S

Gord Chen/Prince/Ying/Kumaresh/Madhu	Rebase 9/18: Rajesh to update the PR rebase issue 9/18: Review in progress ETA for review – 9/25

sonic-swss

VxlanMgr changes

https://github.com/Azure/sonic-swss/pull/1266

Rajesh S

Gord Chen/Prince/Ying/Kumaresh/Madhu	Open ETA for review – 9/25

sonic-swss

Pytest for VxlanOrch, Portsorch and VxlanMgr

https://github.com/Azure/sonic-swss/pull/1318

Rajesh S

Madhu	Open

sonic-swss

L3 VXLAN changes

https://github.com/Azure/sonic-swss/pull/1267

Tapash D

Prince/Phani	Open ETA for review – 10/2

sonic-swss

PY Test for L3 VxLAN

https://github.com/Azure/sonic-swss/pull/1330/

Tapash D

Prince/Phani	Open ETA for review – 10/2

sonic-swss

FdbOrch changes

https://github.com/Azure/sonic-swss/pull/1275

Pankaj J

Gord Chen/Xu/Prince

Rebase 9/18: Pankaj to rebase 9/18: No changes required in sai-redis

sonic-swss

ARP suppression changes

Karthikeyan

9/18: Use shell commands, Karthik to raise PR

sonic-swss

Fdbsyncd changes

https://github.com/Azure/sonic-swss/pull/1276

Kishore K

Gord Chen/Xu/Prince

Rebase 9/18: Rebase to resolve conflicts

sonic-swss

Fpmsyncd changes for Type 5 routes

https://github.com/Azure/sonic-swss/pull/1326

Kishore K

Qi/Pavel

Open 9/18: Kishore to address comments

sonic-swss

Warm Reboot changes for EVPN

Nikhil/Anil

9/18: Changes related to intfmgr and vlanmgr 9/18: Nikhil to rase PR

sonic-frr

FRR patch for Type 5 routes

https://github.com/Azure/sonic-buildimage/pull/4806

Kishore K

Pavel

9/18: BCM to upstream
	FRR version upgrade (patches for GR)		Hasan/Ben		9/18: FRR version to upgrade to 7.4 Hasan/Ben on to get back on this
sonic-linux-kernel

Linux kernel patch for control plane learnt fdb/neigh entries

Distribution: Debian 10.5 Kernel: 4.19.0-9-2-amd64		Hasan		9/18: Hasan to get back if changes are in 4.19 Distribution: Debian 10.5 Kernel: 4.19.0-9-2-amd64

libnl/iproute2 changes for ARP suppression

Karthikeyan

9/18: Already in 4.19
Bgpcfgd	Bgpcfgd changes for EVPN/Static routes/		Zhenhong	Pavel	9/18: PR is in review 9/18: Zhenhong to address the comments

[Tapash Das]

++

 

PRs:

 

 

sonic-frr

FRR version upgrade (patches for GR)

Hasan/Ben

9/18: FRR version to upgrade to 7.4 Hasan/Ben on to get back on this

sonic-linux-kernel

Linux kernel patch for control plane learnt fdb/neigh entries Distribution: Debian 10.5 Kernel: 4.19.0-9-2-amd64

Hasan

9/18: Hasan to get back if changes are in 4.19 Distribution: Debian 10.5 Kernel: 4.19.0-9-2-amd64

sonic-linux-kernel

libnl/iproute2 changes for ARP suppression

Karthikeyan

9/18: Already in 4.19

sonic-buildimage	Bgpcfgd changes for FRR EVPN/Static routes etc	https://github.com/Azure/sonic-buildimage/pull/5142

Zhenhong

Pavel

9/18: PR is in review 9/18: Zhenhong to address the comments

[Rajesh Sankaran]

Hi Prince, reviewers,

    https://github.com/Azure/sonic-swss/pull/1264  rebase issues have now been resolved. FYI and Action. 

Regards

Rajesh