Request reviews for EVPN PRs

[Prince Sunny]

Hi Folks,

 

Requesting reviews for the following Vxlan/EVPN related PRs. As we discussed before this is targeted for 202006.

 

HLD 

1. https://github.com/Azure/SONiC/pull/437 - [Review complete]

• [Review is completed for this, few modifications pending]

 

sonic-swss-common

1. https://github.com/Azure/sonic-swss-common/pull/339  - [Review in-progress]

 

sonic-utilities

1. https://github.com/Azure/sonic-utilities/pull/870

     

sonic-swss

1.  VxlanOrch and PortsOrch changes 

• https://github.com/Azure/sonic-swss/pull/1264 
• Depends on: sonic-swss-common PR #339. 

 

2.  VxlanMgr changes

• https://github.com/Azure/sonic-swss/pull/1266
• Depends on: sonic-swss-common PR #339. 
• The VxlanMgr has changes pertaining to Warm Reboot. The HLD will be updated with the changes for the same. 

 

3.  L3 VXLAN changes

• https://github.com/Azure/sonic-swss/pull/1267  
• Depends on sonic-swss-common PR #339 and sonic-swss PR#1264

 

4. FdbOrch changes

• https://github.com/Azure/sonic-swss/pull/1275
• Depends on sonic-swss-common PR #339, sonic-swss PR #1264 and sonic-swss PR #885
• Note that the changes to fdborch.cpp and fdborch.h in this  PR has the changes from #885 as well. 
• Depends on SAI PR #1024 to be merged. (https://github.com/opencomputeproject/SAI/pull/1024). 

• Changes specified in #1024 are not yet implemented and will be done once it is merged. 

 

5. Fdbsyncd changes

• https://github.com/Azure/sonic-swss/pull/1276
• Depends on  sonic-swss-common PR #339

 

Thanks @Rajesh for the consolidated list

 

..Prince

[Gord Chen]

Hi Prince,

Is there any PRs for the frr fpmsyncd? In proposal HLD, it look likes fpmsyncd also need to be enhanced for EVPN? Thanks

Regards,

Gord

Prince Sunny於 2020年5月6日星期三 UTC+8上午12時20分39秒寫道：

[Syed Hasan Raza Naqvi]

Hi Gord,

There were a few changes made in frr/fpmsyncd for sending RMAC and L3VNI for the type-5 prefix routes.

MAC/IP & IMET routes do not go via fpmsyncd.

FRR patch and fpmsyncd changes for Type-5 will be upstreamed subsequently.

Thanks,

Hasan

--
You received this message because you are subscribed to the Google Groups "sonic-evpn-workgroup" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonic-evpn-workg...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonic-evpn-workgroup/890a01ba-dcfb-4cc5-a204-f512730b5967%40googlegroups.com.

[Gord Chen(冠億)]

Thanks! 

Syed Hasan Raza Naqvi <syed....@broadcom.com> 於 2020年5月6日 週三 上午10:36寫道：

[Gord Chen]

Hi,

5. Fdbsyncd changes

• https://github.com/Azure/sonic-swss/pull/1276
• Depends on  sonic-swss-common PR #339

For Fdbsyncd changes, it seems not only depend on PR#339, and could you provide those miss dependence PRs

e.g. nlapi library is not found, APP_EVPN_REMOTE_VNI_TABLE_NAME and STATE_EVPN_FDB_RESTORE_TABLE_NAME are not found

Gord Chen於 2020年5月6日星期三 UTC+8上午11時02分52秒寫道：

Thanks! 

To unsubscribe from this group and stop receiving emails from it, send an email to sonic-evpn-workgroup+unsub...@googlegroups.com.

[Rajesh Sankaran]

Hi Prince, All,

  The following new PRs were filed. 

1. Warm Reboot Changes for EVPN (swss-common)

    - https://github.com/Azure/sonic-swss-common/pull/350  

    - This PR is required to be merged before https://github.com/Azure/sonic-swss/pull/1266

2. pytest script for vxlanorch and vxlanmgr changes (swss)

     - https://github.com/Azure/sonic-swss/pull/1318

     - This has to be merged after #1264 and #1266 are merged

    

Regards,

Rajesh

On Wednesday, May 13, 2020 at 8:58:25 AM UTC+5:30, Gord Chen wrote:

Hi,

5. Fdbsyncd changes

• https://github.com/Azure/sonic-swss/pull/1276
• Depends on  sonic-swss-common PR #339

For Fdbsyncd changes, it seems not only depend on PR#339, and could you provide those miss dependence PRs

e.g. nlapi library is not found, APP_EVPN_REMOTE_VNI_TABLE_NAME and STATE_EVPN_FDB_RESTORE_TABLE_NAME are not found

Gord Chen於 2020年5月6日星期三 UTC+8上午11時02分52秒寫道：

Thanks! 

Syed Hasan Raza Naqvi <syed...@broadcom.com> 於 2020年5月6日 週三 上午10:36寫道：

[Tapash Das]

Hi Prince and All,

1. Added following PR for L3 VxLAN PY Test

https://github.com/Azure/sonic-swss/pull/1330  

Should be merged after PR 1267.

2. PR 1267 is Open for review

https://github.com/Azure/sonic-swss/pull/1267 

3. PR  1267 should also be merged after PR 885

https://github.com/Azure/sonic-swss/pull/885/ 

Regards,

Tapash

 

Hi,

Thanks! 

To unsubscribe from this group and stop receiving emails from it, send an email to sonic-evpn-workg...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonic-evpn-workgroup/890a01ba-dcfb-4cc5-a204-f512730b5967%40googlegroups.com.

--

You received this message because you are subscribed to the Google Groups "sonic-evpn-workgroup" group.

To unsubscribe from this group and stop receiving emails from it, send an email to sonic-evpn-workg...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonic-evpn-workgroup/522a5a57-c854-4467-b81a-983257331a49o%40googlegroups.com.

[Prince Sunny]

Hi all,

 

Reviving this thread as the code-review is not completed and PRs are still pending merge. I’ll also set up a weekly meeting for review process and target to complete this by end of this month.

 

Below are the list of PRs with proposed reviewers. Please let us know if there are any concerns.  Can Broadcom team resolve the conflicts for the PRs and rebase to latest master?

 

 

Repo	Description	PR ID	Owner	Reviewers	Status
HLDs
SONiC	EVPN VXLAN HLD	https://github.com/Azure/SONiC/pull/437	Rajesh S	EVPN WG	Open
SONiC	Kernel programming performance enhancement - Netlink API	https://github.com/Azure/SONiC/pull/493	Naveen S	Qi Luo	Open
SAI PRs
SAI	Improved support for p2p tunnels (Add DIP in the tunnel sai attribute)	https://github.com/opencomputeproject/SAI/pull/1025	Vissu		Merged
SAI	Support for per-vlan traps (incl. the ARP/ND PR)	https://github.com/opencomputeproject/SAI/pull/1092	Jai		Merged
SAI	Support for static FDB Entries to allow MAC Move	https://github.com/opencomputeproject/SAI/pull/1024	Vissu		Merged
SONiC Code PRs
sonic-swss-common	EVPN VXLAN DB support	https://github.com/Azure/sonic-swss-common/pull/339	Rajesh S	Prince	Merged
sonic-swss-common	Support to register for RAW Netlink Msg handling to support EVPN Type5 route	https://github.com/Azure/sonic-swss-common/pull/353	Kishore K	Qi Luo	Open
sonic-swss-common	Warm Reboot changes for EVPN	https://github.com/Azure/sonic-swss-common/pull/350	Rajesh S	Qi Luo/Ying/Dong	Open
sonic-utilities	VXLAN config and show utilities	https://github.com/Azure/sonic-utilities/pull/870	Rajesh S	Gord Chen/Prince	Open
sonic-swss	Layer 2 Forwarding Enhancements	https://github.com/Azure/sonic-swss/pull/885	Anil P	Xu/Prince	Rebase
sonic-swss

VxlanOrch and PortsOrch changes

https://github.com/Azure/sonic-swss/pull/1264

Rajesh S	Gord Chen/Prince	Rebase
sonic-swss	VxlanMgr changes	https://github.com/Azure/sonic-swss/pull/1266	Rajesh S	Gord Chen/Prince	Open
sonic-swss	Pytest for VxlanOrch, Portsorch and VxlanMgr	https://github.com/Azure/sonic-swss/pull/1318	Rajesh S		Open
sonic-swss

L3 VXLAN changes

https://github.com/Azure/sonic-swss/pull/1267

Tapash D	Prince	Open
sonic-swss	PY Test for L3 VxLAN	https://github.com/Azure/sonic-swss/pull/1330/	Tapash D		Open
sonic-swss	FdbOrch changes	https://github.com/Azure/sonic-swss/pull/1275	Pankaj J	Gord Chen/Xu/Prince	Rebase
sonic-swss	ARP suppression changes		Karthikeyan		To be filed
sonic-swss	Fdbsyncd changes	https://github.com/Azure/sonic-swss/pull/1276	Kishore K	Gord Chen/Xu/Prince	Rebase
sonic-swss	Fpmsyncd changes for Type 5 routes	https://github.com/Azure/sonic-swss/pull/1326	Kishore K	Qi/Pavel/Prince	Open
sonic-swss	Warm Reboot changes for EVPN		Nikhil/Anil		To be filed
sonic-frr	FRR patch for Type 5 routes	https://github.com/Azure/sonic-buildimage/pull/4806	Kishore K	Pavel
sonic-linux-kernel	Linux kernel patch for control plane learnt fdb/neigh entries		Hasan		To be filed
	libnl/iproute2 changes for ARP suppression		Karthikeyan		To be filed

 

..Prince

Hi,

 

 

Thanks! 

 

1.       https://github.com/Azure/SONiC/pull/437 - [Review complete]

·         [Review is completed for this, few modifications pending]

 

sonic-swss-common

1.       https://github.com/Azure/sonic-swss-common/pull/339  - [Review in-progress]

 

sonic-utilities

1.       https://github.com/Azure/sonic-utilities/pull/870

[Ben Gale]

Thanks for your help in driving this Prince.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonic-evpn-workgroup/SN6PR2101MB177418D1DE25C6BD81AC5E8A93270%40SN6PR2101MB1774.namprd21.prod.outlook.com.