RE: DASH Behavioral Model WG
Kristina Moore
Hello team, below please find last Thursday’s notes:
Detailed Notes:
- Chris and Andy discussed a Service Tunnel feature that Andy was trying to simplify down to 64 bits. Chris suggested filing an Issue and creating a PR to get the discussion going offline. Chris also suggested using blame to see who wrote the code and pinging them in the issue.
- Chris and Vincent discussed an issue with compiling Docker images, which may be related to a race condition. Chris suggested filing an Issue and tagging himself and Kamil.
- Vincent and Chris discussed a compile issue with Docker that Vincent noticed when he pulled up the latest Dash to rebase. Vincent mentioned that Kamil had made some changes to the 'make' files that could be causing the issue.
- Chris and Marian discussed a bug in the bmv2 code; discussed the possibility of returning more than one object type, but Marian was unsure if it was possible due to the API signature.
- Chris and Saad discussed a Python-based behavior model that Saad has been working on for the past few weekends. The model is a drop-in replacement for the existing P4 behavior model.
- Saad has been working on a Python based behavior model to replace the existing P4 model. He has completed the functionality and is now working on integration.
- Chris and Saad discussed a project involving a drop-in replacement for an existing model, which would be written in Python and have the same interfaces as the current P4 runtime approach.
- Chris and Marian discussed two issues related to the implementation of the model. The first issue was discussed yesterday and Brian agreed to take another look at it. The second issue had code issues and Marian was cited to help.
- Chris and Marian discussed a code path in the P4 test Gen that was found to be dead code. Marian explained that the NVGRE encap function is agnostic to the overlay IP family and that the service tunnel is before the IPV6 translation.
- Marian and Chris discussed the code path of NVGRE encap. Marian explained that the function is agnostic to the overlay IP family and that it supports both IPv4 and IPv6 headers.
- Chris, Andy, and Marian discussed the potential of using a code path as a CICD test case for P4 test gen. Marian suggested that the solution should not be to remove the condition from the function.
- Chris talked about Kamil's work on refactoring the SAI Thrift server in the SAI repo to compile the SAI Meta into a Lib Sai Meta.
- Chris discussed the progress of Camille's refactoring of the side thrift server in the Sai repo. The goal is to compile the side meta into a Lib Sai Meta, which will eliminate the need for it in the vendor libsai.
- Chris and Agrawal discussed the status of test cases running on hardware. Vincent offered to check the test cases and provide feedback. Chris suggested that other vendors could also try the test cases on their own implementations.
-----Original Appointment-----
From: Kristina Moore
Sent: Monday, April 18, 2022 10:48 AM
To: John C Carney; Kristina Moore; Marian Pritsak; Mahalinga, Venkatesan; Suresh Ravindran; Renato Recio; venkat pullela; Bud Grise; Jai Kumar; Lisa Nguyen; Prince Sunny; mur...@cisco.com; Paul Cummins; Yusef Skinner; mykola....@plvision.eu; Kishore
Atreya; Steve Espinosa; Kannan Selvaraj; Riff Jiang; amith...@gmail.com; deb.cha...@intel.com
Cc: Mohammad Hanif; Gerald Degrace; Lihua Yuan; Narasimha Rao Vadrevu; zafirhafeez; Senthil.Ku...@dell.com; Agrawal, Ashutosh; Chris Sommers; Sandeep Balani; Mestery, Kyle; Vinod Kumar; Dermody, Anthony; israel...@broadcom.com; k.kwa...@gmail.com;
Sudarshan, Reshma; Dube, Shawn; Singhai, Anjali; Fingerhut, John Andy; Shah, Shitanshu; James...@intel.com; mohammad.q...@gmail.com; saadma...@gmail.com; Sanders, Mark; Moopath velayudhan, Mukesh; Ganesan, Senthil Kumar; Rita Hui; Doddapaneni,
Krishna; carol-ann.slater; ma...@opennets.com; Renuka Manavalan; Srinivasan, Vijay; suresh....@broadcom.com; Thyamagundalu, Sanjay; Vincent Legrand; Shay Schlafman; Aravind Srikumar (arsrikum); Deepti Chandra (deeptich); Rishabh Tewari; Neeraj Motwani;
Sudhir Kayamkulangara (skayamku); richa...@tencent.com; Clark; Eddie Ruan; marc.m...@arm.com; Yohad Tor; Eilon Greenstein; ida...@nvidia.com; Saad Mazhar; Oleksandr Ivantsiv; Harrish SJ; sonic...@googlegroups.com; Mididaddi, Naren; McCollum, Macy;
urv...@arista.com; Alex Bortok; Sonny Mei; Mircea Dan Gheorghe; James Grantham; Rajagopal Krishnaswamy; Apurva Shah; swna...@amd.com; Veerappan, Senthilnathan; Vattem, Phaniraj; Vattem, Phaniraj
Subject: DASH Behavioral Model WG
When: Thursday, September 21, 2023 10:30 AM-11:15 AM (UTC-08:00) Pacific Time (US & Canada).
Where: Microsoft Teams Meeting
- Updating invite list (adding sonic...@googlegroups.com) to extend the DASH Behavioral Model invite to a wider audience
- Meeting is every other Thursday at 10am Pacific
- Please bring your PRs, Issues, Discussion Topics to the call 😊
- Behavioral Model Objective:
- Pipeline (snip): https://github.com/sonic-net/DASH/tree/main/dash-pipeline/bmv2
- SAI (snip): https://github.com/sonic-net/DASH/tree/main/dash-pipeline/SAI
Please join us if you are interested,
Thank you,
Kristina Moore MBA,
M.S., CISSP - Azure Core Principal
PM / DASH
Office: 425-722-7720 Mobile: 425-876-2040 Email:
kri...@microsoft.com
DASH Group to join:
https://groups.google.com/g/sonic-dash
DASH-Test-Workgroup Group to join: https://groups.google.com/g/sonic-dash-test-workgroup
________________________________________________________________________________
Microsoft Teams meeting
Join on your computer or mobile app
Or call in (audio only)
+1 323-849-4874,,187028994# United States, Los Angeles
(866) 679-9995,,187028994# (Toll-free)
Phone Conference ID: 187 028 994#
________________________________________________________________________________
Kristina Moore
Hello team, below please find last Thursday’s Behavioral Model Workgroup (Summary and Detailed) notes:
September 21, 2023 - https://youtu.be/wAkJUG5KduY
Added to Issue428
Andy - issue with P4-DPDK backend. The code at
https://github.com/sonic-net/DASH/blob/main/dash-pipeline/bmv2/dash_service_tunnel.p4#L7-L24which performs 128-bit masking on IPv6 addresses exposes a deficiency in p4-dpdk backend,
it can't perform 128-bit math.
Action - Andy will pursue it with the p4-dpdk team. He may also propose a workaround/compromise and file as an issue or PR.
Issue442 & 432
https://github.com/sonic-net/DASH/issues/442 - p4 compile attempting to run parallel docker compile. Vincent identified
a problem with new improved dash-pipeline makefiles from
https://github.com/sonic-net/DASH/pull/432, the resulting dependencies allowed parallel builds to kick off causing a docker container name reuse issue.
Action - Vincent to file issue; Subsequently he proposed a solution in https://github.com/sonic-net/DASH/pull/443and it's already merged by Chris - DONE
Issue441
Vijay - Can we close
https://github.com/sonic-net/DASH/issues/441- SAI API meter flags not mandatory on meter class
Action - Vincent wlil review response and close if satisfied - DONE
Issue436
https://github.com/sonic-net/DASH/issues/436- Why dash_sai_create_dash_acl_rule create multiple SAI_OBJECT_TYPE_DASH_ACL_RULE objects?
Action - Marian to review again
Issue415
https://github.com/sonic-net/DASH/issues/415- wrong code generated in libsai
Action - Chris added note to the Issue: "Per @marian-pritsak needs some more work to find a better way to perform casting. Deferred for now, it's not "broken." Future action - find a fix?
Issue399
https://github.com/sonic-net/DASH/issues/399- Dead code in dash_pipeline.p4 PNA version. Per @marian-pritsak it is
OK, this dead code path is only because we've future-proofed the code to anticipate future tunneling options.
Action - Chris to close Issue with comments - DONE
Issue430
https://github.com/sonic-net/DASH/pull/430- Added DASH PTF metering test cases and test plans . Ashutosh tested these new cases on real hardware, we can't verify in bmv2. Chris asked for volunteer to
try on their implementation so we can merge with more confidence.
Action- Vincent agreed to try them out and report.
Kristina Moore
Hi Behavioral Model WorkGroup – today Riff Jiang (@r12f) presented a “DASH Pipeline Packet Flow Update Proposal” PR449
https://github.com/sonic-net/DASH/pull/449
We wanted to get this out to the Community for consumption and review, prior to the next Behavioral Model meeting on October 19th, 2023.
Please submit Comments into the PR if you have any 😊
I’ll also include this info in the DASH Community Call notes, to notify the audience there.
Thank you,
Kristina Moore MBA, M.S., CISSP - Azure Core Principal PM / DASH & Network Function Disaggregation
Office: 425-722-7720 Mobile: 425-876-2040 Email:
kri...@microsoft.com
DASH Group to join: https://groups.google.com/g/sonic-dash
DASH-Test-Workgroup Group to join: https://groups.google.com/g/sonic-dash-test-workgroup
-----Original Appointment-----
From: Kristina Moore
To: Kristina Moore
Subject: DASH Behavioral Model WG
When: Thursday, October 5, 2023 10:30 AM-11:15 AM (UTC-08:00) Pacific Time (US & Canada).
Where: Microsoft Teams Meeting