[4/5/2021] SONiC Chassis Code & Test PR Status
Anshu Verma
Hi Team
Please find Weekly Status of Chassis Code and Test PRs below, also action items tagged for PR/review owners.
Summary:
· Progress 71%
· Total Merged PRs (incl. HLDs, Code, Test, HLDs) = 59
· Open PRs Total = 24
- Merged PRs last week = 4
- PRs ready for Merge = 9
- PRs under review this week = 15
|
Feature |
PR |
Owner |
Reviewer - Status |
Action item |
|
PMON HLD |
Nokia |
@Judy Joseph - under review |
4/5: Comments added by @Judy. @Prabhu, Manjunath (Nokia - US/Mountain View) – please address the comments.
3/24: Review comments provided by Judy, no blocking issues. 3/20: No new update 3/12: No new update. @Judy - could you please review and approve 3/5: No new update 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Judy Joseph, could you please review and approve |
|
|
Inband Interface (port type) Code PR |
https://github.com/Azure/sonic-swss/pull/1602
|
Veda (Nokia) |
@song - approved @abdosi - Under review
|
4/5: In discussion Abhishek, Veda, Srikanth.
3/20: Under review by @Abhishek 3/12: @Abhishek - please help with review & merge. 3/5: PR, approved, Thanks Song! Ready for Merge. 2/24: @Abhishek to help with test rerun 2/18: Song (Arista) provided review comments, thanks 2/8: No new update 1/27: @eswaran, @Abhishek - could you please review and approve |
|
|
https://github.com/Azure/sonic-platform-common/pull/159 Ready for merge |
Veda (Nokia) |
@ngoc-do - approved @Abhishek - approved Ready for merge |
4/5: #6477 merged, ready for merge @Abhishek
3/24: Ready for merge after 6477 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! |
|
|
https://github.com/Azure/sonic-platform-daemons/pull/145 Ready for merge |
Veda (Nokia) |
@ngoc-do - approved @Abhishek - approved Ready for merge |
4/5: Ready for merge @Abhishek
3/24: Ready for merge after 6477 3/20: @Ngoc, @eswaran - please re-approve. 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! Do we need MSFT approval? @Abhishek please confirm 1/27: @eswaran, @Abhishek - could you please review and approve |
|
|
https://github.com/Azure/sonic-utilities/pull/1363 Ready for merge |
Veda (Nokia) |
@ngoc-do - approved @Abhishek - approved Ready for merge |
4/5: Ready for merge @Abhishek
3/24: Ready for merge after 6477 3/20: @Ngoc, @eswaran - please re-approve. 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! Do we need MSFT approval? @Abhishek please confirm 1/27: @eswaran, @Abhishek- could you please review and approve |
|
Recycle port support HLD |
https://github.com/Azure/SONiC/pull/742 Ready for merge |
Song (Arista) |
@eswaran - approved @Arvindsrinivasan - approved @Guohan- approved @Suresh -approved @Rita – pending Ready for merge |
4/5: Approved by Arvind, Suresh, Eswaran, thanks! Ready for merge @Arvindsrinivasan
3/24: HLD to be reviewed in SONiC main community 3/20: Under review, to be discussed in subgroup meeting. 3/12: Approved by Srikanth, thanks! Updates requested by Rita and Abhishek. 3/5: Review in progress by Rita. @eswaran, @Arvindsrinivasan - could you please review and approve. 2/24: No new update 2/18: No new update 2/8: @eswaran, @Rita Hui, @Arvindsrinivasan - could you please review and approve 1/27: Need Nokia & MSFT reviewers assigned |
|
Routing/BGP support for Chassis HLD |
https://github.com/Azure/SONiC/pull/674 Ready for merge |
jmmikkel (Arista)
|
@eswaran - approved @Arvindsrinivasan - approved @Guohan Lu- approved @Suresh- approved @Rita - pending Ready for merge |
4/5: Approved by Arvind, Suresh, Eswaran, Guohan thanks! Ready for merge @Arvindsrinivasan
3/24: @Rita Hui, @Arvindsrinivasan could you please review and approve 3/12: Approved by Eswaran, thanks! @Rita Hui- could you please approve and merge. 3/5: Approved by Guohan, Suresh Thanks! @eswaran, @Rita Hui- could you please review and approve 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @eswaran, @Rita Hui- could you please review and approve |
|
Routing/BGP support for Chassis Code PR |
https://github.com/Azure/sonic-buildimage/pull/5622 Ready for merge
|
jmmikkel (Arista) |
@vganesan-nokia - approved @minionatwork - approved @rlhui - pending @Arvindsrinivasan - approved @eswaran - approved @venkat (Dell) - pending @Guohan Lu- pending Ready for merge
|
4/5: PR approved by Arvind, thanks! Ready for merge.
3/24: Comments addressed, Arvind to approve and merge. 3/20: Approved by Suresh, thanks! Under review by @Arvindsrinivasan, @eswaran. 3/12: Feedback provided by Jmmikkel, @eswaran, @Rita Hui, @Suresh, @Arvindsrinivasan - could you please review and approve 3/5: Review in progress by Arvind. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda (Nokia), thanks! 2/8: No new update 1/27: Veda, Suresh, @Rita Hui, @Arvindsrinivasan could you please review and approve |
|
|
https://github.com/Azure/sonic-buildimage/pull/5629
(Critical for testcase pass) Ready for merge |
jmmikkel (Arista) |
@Arvindsrinivasan - approved @Guohan Lu- pending Ready for merge |
4/5: PR approved by Arvind, thanks! Ready for merge.
3/24: New FRR patch raised and update code PR with new FRR patch (action: Joanne) (Action: Rita to confirm if we can bring in FRR patch and get back to Eswaran) (Action: Eswaran - pending FRR community to approve patch) 3/20: @Jmmikkel - please fix conflicts 3/12: @Jmmikkel - please fix conflicts 3/5: Review in progress by Arvind. 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Arvindsrinivasan - could you please review and approve |
|
Fabric port support Code PR |
Ngoc (Arista) |
@minionatwork - pending @rlhui – pending @eswaran - pending @Abhishek - change requested @Guohan Lu- change requested
|
4/5: Fabric port check is disabled, @Abhishek , @Guohan Lu could you please review & approve.
3/24: Ngoc to Update #1459 to disable test 3/20: Review in progress, feedback provided by Ngoc to Abhishek. To be discussed in subgroup meeting. 3/12: Review in progress, feedback provided by Ngoc. 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8:Vs test cases added, Suresh, @Rita, @Guohan, @Abhishek- could you please review and approve 1/27: Suresh, @Rita- could you please review and approve |
|
|
|
https://github.com/Azure/sonic-buildimage/pull/6185 Ready for merge |
Ngoc (Arista) |
@Danny – approved @Guohan - pending @Joe LeVeque - approved @Srikanth -approved Ready for merge |
4/5: Ready for merge, @Danny Please help with merge.
3/24: Can be merged after #1459 (post disabling the tests) 3/20: Approved by Srikanth, thanks! Ready for merge. 3/12: @Srikanth , @Guohan - please review and approve. 3/5: @Srikanth , @Guohan - please review and approve. 2/24: PR approved by Joe, thanks! 2/18: No new update 2/8: New PR, @Guohan, @Joe – could you please review and approve. |
|
Everflow support HLD |
Eswaran (Arista) |
@abdosi - change requested @minionatwork - approved |
4/5: @Eswaran to address review comment.
3/24: Change requested by @Abhishek @eswaran - please add the case where monitor port is the local port the behavior in both the scenarios. 3/12: Approved by Suresh, thanks! 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Abhishek- could you please review and approve |
|
|
Everflow support Code PR |
Song (Arista) |
@abdosi - pending @prsunny- pending @daall- pending @zhenggen-xu - pending @Guohan - under review |
4/5: @Abhishek, @Prince, @Danny - could you please review and approve
3/24: Abhishek to review 3/20: No new update, to be discussed in subgroup meeting. 3/12: No new update 3/5: No new update 2/24: No new update 2/18: Review comments provided by Guohan, thanks! 2/8: No new update 1/27: @Abhishek, @Prince, @Danny, @zhenggen-xu - could you please review and approve |
|
|
Inband Vlan |
Song (Arista) |
@Veda Ganesan – approved @Guohan - change requested |
4/5: PR approved by Veda, thanks! @Guohan - could you please review
3/24: #1605 and #1602 has tests cases to delete created neighbors, will fix test failing. 3/20: No new update, to be discussed in subgroup meeting. 3/12: @Guohan - could you please review and approve, @Veda Ganesan - please re-approve. 3/5: @Guohan - could you please review and approve. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda, thanks! 2/8: New PR, @Veda Ganesan – could you please review and approve. |
|
|
Minigraph support |
Maxime (Arista) |
@Arvindsrinivasan – change requested @Veda Ganesan – change requested @Guohan - pending
|
4/5: Review comments addressed by Maxime, thanks! @Arvindsrinivasan, @Veda Ganesan - could you please review and approve.
3/24: Maxime to update 3/20: Change requested by @Arvindsrinivasan & @Veda Ganesan 3/12: No new update 3/5: No new update 2/24: Under review 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan , @Veda Ganesan |
|
|
|
Maxime (Arista) |
@Arvindsrinivasan – under review @Veda Ganesan – approved |
4/5: Approved by Veda, thanks! @Arvindsrinivasan - could you please review and approve.
3/24: Eswaran, Suresh, Shyam, Judy, Arvind to discuss offline/on subgroup alias. (Action: Eswaran Separate meeting to converge on the solution) 3/20: No new update 3/12: Under review 3/5: Change requested by Veda. 2/24: No new update 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan, @Veda Ganesan |
Chassis Testing Effort:
|
Functional area |
Description |
PR# |
Owner |
Reviewed |
PR Status |
|
VoQ test plan |
Neighbor and Host IP Forwarding testcases and helpers |
Nokia |
|
4/5: All tests are passing, @Xin Wang , @Shuba - please review and approve.
3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Azp few checks failed, @tcusto to address. 3/5: please assign reviewers @Ying, @Eswaran Baskaran |
|
|
PMON |
Add tests cont_link_flap, system_health, platform_info, reboot to run on T2 topology for VoQ chassis |
Nokia |
|
4/5: All tests passing, @Joe LeVeque could you please review and approve.
3/24: unrelated failures in pipeline. Needs re-run @Ying. |
|
|
|
Thermal CLI test case |
|
Nokia |
|
Need json file for sonic build image |
|
LAG Test plan |
LAG on Chassis Test case |
Nokia |
Yes |
4/5: @Ying, @Xin Wang - could you please approve and merge. Need reviewers from Arista team @Eswaran Baskaran
3/20: @Ying, @Xin Wang - please approve and merge. 3/12: Need reviewers from Arista team @Eswaran Baskaran 3/5: Assigned to Ying, Xin. Need reviewers from Arista team @Eswaran Baskaran |
|
|
|
Test cases for LAG on Distributed VOQ System |
Nokia |
|
4/5: All tests passing, @Ying, @Xin Wang - could you please approve and merge.
3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: @Ying please review and help restart the pipeline. |
|
|
BGP on Chassis Test plan |
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Fabric Test plan |
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Everflow support Test plan |
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Minigraph support in sonic-mgmt |
Minigraph support in sonic-mgmt |
Arista |
|
4/5: Under review by sanmalho-git; @Ying, @Xin Wang -could you please approve and merge.
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
|
Adapt testcases for SONiC Chassis |
Support for KVM based virtual T2 VoQ chassis |
Nokia |
|
4/5: @Ying, @Xin Wang - please approve and merge; under review by
3/29: New PR created
|
|
|
T1 test case conversion |
LLDP, SNMP, PortChannel |
Nokia |
|
4/5:All test passing @Xin Wang - could you please approve and merge.
3/20: Azp run few checks failed. @Xin Wang Could you help resolve this?
|
|
|
|
Adapting FIP tests for T2 topology |
Nokia |
|
4/5:All test passing @Xin Wang - could you please approve and merge.
3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Azp run successful, @Ying. please help approve and merge. |
|
|
|
System Health, Syslog |
|
|
|
|
|
|
TACACS |
|
Nokia |
|
|
|
|
Auto_restart, CRM |
|
Nokia |
|
|
Code & HLD Merged PRs
|
Feature |
PR |
Owner |
Reviewer - Status |
Update |
|
Chassis sample test conversion to multi-DUT |
https://github.com/Azure/sonic-mgmt/pull/2813 Merged |
Shuba (Nokia) |
2/8: Merged, thanks Ying!
1/27: Need Arista & MSFT reviewers assigned @Eswaran Baskaran, @Ying Xie– could you please assign reviewers to the PR, thanks. |
|
|
Inband Interface support |
https://github.com/Azure/sonic-swss/pull/1568 Merged |
Veda (Nokia) |
3/5: Merged, thanks Prince! 2/24: Azure pipeline run requested by Prince and tests passed. 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved, ready for merge. Thanks Prince! 1/27: @eswaran, @Abhishek- could you please review and approve |
|
|
Inband Code PR |
https://github.com/Azure/sonic-buildimage/pull/6477 Merged |
Veda (Nokia) |
4/5: Merged, thanks Abhishek! 3/20: PR approved by Abhishek, Max, thanks! 3/12: @Abhishek -thanks for test re-run. #159, #1363 dependent on this PR. Approved by Maxime (Arista), thanks! 3/5: No new update, : 2/24: @Abhishek to help with test rerun 2/18: No new update 2/8: No new update 1/27: @eswaran, @Abhishek - could you please review and approve |
|
|
Fabric port support for Chassis HLD |
https://github.com/Azure/SONiC/pull/668 Merged |
Eswaran (Arista) |
|
3/5: Approved and Merged, thanks Rita! 2/24: No new update 2/18: No new update 2/8: No new update 1/27: Suresh, @Rita, @Guohan, @Abhishek- could you please review and approve |
|
LAG Code PR |
https://github.com/Azure/sonic-swss/pull/1603 Merged |
Veda (Nokia) |
|
3/12: Merged, thanks Judy! 3/5: PR approved by Judy, thanks! Ready for Merge 2/24: Retest requested Judy 2/18: No new update 2/8: PR under review and comments provided by Judy, thanks! 1/27: @Judy Joseph - could you please review and approve |
|
|
https://github.com/Azure/sonic-buildimage/pull/6488 Merged |
Veda (Nokia) |
4/5: Merged, thanks Judy! 3/24: Can be merged 3/20: approved by Judy, thanks! 3/12: Under review by Judy. 3/5: No new update, @Judy- could you please review and approve 2:24: No new update 2/18: No new update 2/8: PR under review and comments provided by Judy, thanks! 1/27: @Judy- could you please review and approve |
|
|
|
https://github.com/Azure/sonic-swss/pull/1605 Merged |
Veda (Nokia) |
4/5: PR approved & Merged. Thanks Judy, Song!
3/24: Tests completed, Judy to take a look. 3/20: Under review. Few swss tests failed @Veda Ganesan to address. 3/12: Under review by Judy. 3/5: No new update, @Judy- could you please review and approve 2/24: PR approved by @ysmanman, thanks! 2/18: Veda added test case for lag id allocator table full error. 2/8: PR under review and comments provided by Judy and Song, thanks! 1/27: Song - could you please review & approve. |
|
|
|
https://github.com/Azure/sonic-swss-common/pull/447 Merged |
Veda (Nokia) |
|
2/18: Merged, thanks Judy, Guohan! 2/8: PR under review and comments provided by Judy, thanks. 1/27: @Judy Joseph - could you please review and approve |
|
|
https://github.com/Azure/sonic-swss-common/pull/448 Merged |
Veda (Nokia) |
|
2/18: Merged, thanks Judy! 2/8: PR approved. 1/27: @Judy Joseph - could you please review and approve |
Merged Test PRs:
|
Functional area |
Description |
PR# |
Owner |
Reviewed |
PR Status |
|
Adapt testcases for SONiC Chassis |
Chassis Test Infrastructure |
Nokia |
Yes |
Merged |
|
|
|
Implementation of multi-DUT and multi-ASIC as per PR 2347 |
Nokia |
Yes |
Merged |
|
|
|
[multi-dut] - Sanity checks for multi-duts |
Nokia |
Yes |
Merged |
|
|
|
Config_facts enhancements for multi-asic and support in SonicAsic |
Nokia |
Yes |
Merged |
|
|
|
Test bgp facts - skip for supervisor card in a SONiC chassis |
Nokia |
Yes |
Merged |
|
|
|
Adding module_utils to allow for common utilites that can be shared among ansible |
Nokia |
Yes |
Merged |
|
|
|
Support for not all DUT ports connected to a fanout switch |
Nokia |
Yes |
Merged |
|
|
|
Creategraph - Support comments and empty lines in the lab_devices and lab links csv files |
Nokia |
Yes |
Merged |
|
|
|
Introduce basic T2 topology |
Nokia |
Yes |
Merged |
|
|
|
Additional fixtures to filter DUTs as per specific test case needs |
Nokia |
Yes |
Merged |
|
|
|
Support for gen-mg to work with multi-dut where VMs connect to only a single host and supervisor card |
Nokia |
Yes |
Merged |
|
|
|
Optimizing dut selection fixtures in pytest_generate_tests |
Nokia |
Yes |
Merged |
|
|
|
Making log analyzer fixture work with multiple DUTs in multi-dut testbed |
Nokia |
Yes |
Merged |
|
|
VOQ test plan |
VOQ test plan |
Nokia |
Yes |
Merged |
|
|
|
System Initialization & Neighbor Lifecycle functional |
Nokia |
Yes |
Merged |
|
|
PMON Test plan |
PMON Test plan |
Nokia |
Yes |
Merged (Thanks Xin, Ying!) |
|
|
|
Framework for selecting pluggable components for sonic modular chassis, and CLI Tests |
Nokia |
Yes |
Merged |
|
|
|
Convert tests test_cpu_memory_usage, test_port_toggle to support T2 |
Nokia |
Yes |
Merged |
|
|
|
New tests for APIs added for Chassis and convert existing APIs to run on Chassis |
Nokia |
|
4/5: Approved & Merged, Thanks Xin, Joe!
3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Approved by Joe, thanks! Under review @Vaibhav, @Sujin, @Ying. 3/12: Comments addressed, please help with approval and Merge @Joe 3/5: Under review (Joe, Sujin, Vaibhav, Ying) |
|
|
T1 test case conversion |
test_interfaces.py, test_nbr_health.py, iface_namingmode and new DUT selection mechanism, ARP, Route, Syslog, Monit, read_mac, TechSupport, PortStat |
Nokia |
Yes |
Merged |
|
|
|
FIB |
Nokia |
Yes |
Merged (Thanks Joe, Ying! ) |
|
|
|
IpFwd |
Nokia |
|
3/12: Closed, new PR will be created 3/5: Under review by Xin, thanks! |
|
|
|
Drop Packets |
MSFT |
|
Merged |
|
|
|
Added support to get random asic in a testcase using 'enum_rand_one_asic_index' |
Nokia |
|
Merged |
|
|
|
Thermal CLI test case, test_cpu_memory_usage.py, test_port_toggle.py |
Nokia |
|
3/20: Approved and Merged, thanks Joe, Ying! 3/12: Comments addressed, please help with Merge @Joe. |
|
|
|
Converting legacy platform tests for a T2 chassis, adding validation of values to tests, and refactor test_sfp into smaller tests |
Nokia |
Yes |
Merged |
|
|
|
Announce_routes for T2 |
Nokia |
Yes |
4/5? Approved & Merged, Thanks Ying! 3/20: Review comments provided by @Ying, Nokia team to address. 3/12: @Ying, @Xin, @Rita - Please review |
Thank You,
Anshu
Anshu Verma
Hi Team
We have made good progress past week, Thank You for your continued effort on the SONiC Chassis support.
Please find Weekly Status of Chassis Code and Test PRs below, also action items tagged for each PR/review owners.
Summary:
· Progress 80%
· Total Merged PRs (incl. HLDs, Code, Test, HLDs) = 66
· Open PRs Total = 17
- Merged PRs last week = 7
- PRs ready for Merge = 5
- PRs under review this week = 12
|
Feature |
PR |
Owner |
Reviewer - Status |
Action item |
|
PMON HLD |
Nokia |
@Judy Joseph - under review |
|
4/5: Comments added by Judy |
|
3/24: Review comments provided by Judy, no blocking issues. 3/20: No new update 3/12: No new update. @Judy - could you please review and approve 3/5: No new update 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Judy Joseph, could you please review and approve |
|
Inband Interface (port type) Code PR |
https://github.com/Azure/sonic-swss/pull/1602
|
Veda (Nokia) |
@song - approved @abdosi - Under review
|
|
4/12: Veda to update HLD with the information of L2Header (Src/Dest Mac) being used for the above packat flow.
4/5: In discussion Abhishek, Veda, Sreekanth. |
|
3/20: Under review by @Abhishek 3/12: @Abhishek - please help with review & merge. 3/5: PR, approved, Thanks Song! Ready for Merge. 2/24: @Abhishek to help with test rerun 2/18: Song (Arista) provided review comments, thanks 2/8: No new update 1/27: @eswaran, @Abhishek - could you please review and approve |
|
Recycle port support HLD |
|
https://github.com/Azure/SONiC/pull/742 Ready for merge |
Song (Arista) |
|
@eswaran - approved @Arvindsrinivasan -pending @Suresh -approved @Rita – pending @Abhishek - change requested Ready for merge |
4/12: Song confirmed review comments addressed, @eswaran, @Rita Hui, @Abhishek , @Arvindsrinivasan - please review and approve.
4/7: Is the HLD updated with the review comments, so that in future there's no need to go to PR comments 4/5: Approved by Suresh, Eswaran, thanks! |
|
Ready for merge @Arvindsrinivasan 3/24: HLD to be reviewed in SONiC main community 3/20: Under review, to be discussed in subgroup meeting. 3/12: Approved by Srikanth, thanks! Updates requested by Rita and Abhishek. 3/5: Review in progress by Rita. @eswaran, @Arvindsrinivasan - could you please review and approve. 2/24: No new update 2/18: No new update 2/8: @eswaran, @Rita Hui, @Arvindsrinivasan - could you please review and approve 1/27: Need Nokia & MSFT reviewers assigned |
|
Routing/BGP support for Chassis Code PR |
|
https://github.com/Azure/sonic-buildimage/pull/5622 Ready for merge
|
jmmikkel (Arista) |
@vganesan-nokia - approved @minionatwork - approved @rlhui - pending @Arvindsrinivasan - approved @eswaran - approved @venkat (Dell) - pending @Guohan Lu- pending Ready for merge
|
|
4/12: Veda, Suresh (Nokia), @eswaran - please re-approve.
4/7: Nokia to also approve. |
|
4/5: PR approved by Arvind, thanks! Ready for merge. 3/24: Comments addressed, Arvind to approve and merge. 3/20: Approved by Suresh, thanks! Under review by @Arvindsrinivasan, @eswaran. 3/12: Feedback provided by Jmmikkel, @eswaran, @Rita Hui, @Suresh, @Arvindsrinivasan - could you please review and approve 3/5: Review in progress by Arvind. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda (Nokia), thanks! 2/8: No new update 1/27: Veda, Suresh, @Rita Hui, @Arvindsrinivasan could you please review and approve |
|
|
https://github.com/Azure/sonic-buildimage/pull/5629
(Critical for testcase pass) Ready for merge |
jmmikkel (Arista) |
@Arvindsrinivasan - approved @Guohan Lu- pending Ready for merge |
|
4/12: Rita to sync-up with Guohan
4/7: Rita to sync-up with Guohan |
|
4/5: PR approved by Arvind, thanks! Ready for merge. 3/24: New FRR patch raised and update code PR with new FRR patch (action: Joanne) (Action: Rita to confirm if we can bring in FRR patch and get back to Eswaran) (Action: Eswaran - pending FRR community to approve patch) 3/20: @Jmmikkel - please fix conflicts 3/12: @Jmmikkel - please fix conflicts 3/5: Review in progress by Arvind. 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Arvindsrinivasan - could you please review and approve |
|
Fabric port support Code PR |
Ngoc (Arista) |
|
@minionatwork - pending @rlhui – pending @eswaran - pending |
@Abhishek - approved @Guohan Lu- change requested
|
4/12: @Guohan Lu , @eswaran , Suresh (Nokia) could you please review & approve. Approved by Abhishek, thanks! |
|
4/5: Fabric port check is disabled, @Abhishek , @Guohan Lu could you please review & approve. 3/24: Ngoc to Update #1459 to disable test 3/20: Review in progress, feedback provided by Ngoc to Abhishek. To be discussed in subgroup meeting. 3/12: Review in progress, feedback provided by Ngoc. 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8:Vs test cases added, Suresh, @Rita, @Guohan, @Abhishek- could you please review and approve 1/27: Suresh, @Rita- could you please review and approve |
|
Everflow support HLD |
Eswaran (Arista) |
@Abhishek - change requested @minionatwork - approved |
4/12: @eswaran - please confirm if review comments are addressed
4/7: @Abhishek , to close |
|
4/5: @Eswaran to address review comment. 3/24: Change requested by @Abhishek @eswaran - please add the case where monitor port is the local port the behavior in both the scenarios. 3/12: Approved by Suresh, thanks! 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Abhishek- could you please review and approve |
|
Everflow support Code PR |
Song (Arista) |
|
@Abhishek - change requested |
|
@prsunny- pending @daall- pending @zhenggen-xu - pending @Guohan - under review |
|
4/12: Review comments added by Abhishek. |
|
@Prince, @Danny - could you please review and approve
4/5: @Abhishek, @Prince, @Danny - could you please review and approve 3/24: Abhishek to review 3/20: No new update, to be discussed in subgroup meeting. 3/12: No new update 3/5: No new update 2/24: No new update 2/18: Review comments provided by Guohan, thanks! 2/8: No new update 1/27: @Abhishek, @Prince, @Danny, @zhenggen-xu - could you please review and approve |
|
Inband Vlan |
Song (Arista) |
|
@Veda Ganesan – approved @Guohan - change requested |
@Abhishek - change requested |
4/12: Updates made by Song, thanks! |
4/7: Song to update, Abhishek provided review comments. |
|
4/5: PR approved by Veda, thanks! @Guohan - could you please review 3/24: #1605 and #1602 has tests cases to delete created neighbors, will fix test failing. 3/20: No new update, to be discussed in subgroup meeting. 3/12: @Guohan - could you please review and approve, @Veda Ganesan - please re-approve. 3/5: @Guohan - could you please review and approve. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda, thanks! 2/8: New PR, @Veda Ganesan – could you please review and approve. |
|
Minigraph support |
Maxime (Arista) |
|
@Arvindsrinivasan – change requested @Veda Ganesan – approved @Guohan - pending
|
4/12: PR approved by Veda, thanks! @Arvindsrinivasan,@Guohan could you please review and approve. |
|
4/5: Review comments addressed by Maxime, thanks! @Arvindsrinivasan, @Veda Ganesan - could you please review and approve. 3/24: Maxime to update 3/20: Change requested by @Arvindsrinivasan & @Veda Ganesan 3/12: No new update 3/5: No new update 2/24: Under review 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan , @Veda Ganesan |
|
|
Maxime (Arista) |
@Arvindsrinivasan – under review @Veda Ganesan – approved |
|
4/12: @Arvindsrinivasan - could you please review and approve. |
|
4/5: Approved by Veda, thanks! |
3/24: Eswaran, Suresh, Shyam, Judy, Arvind to discuss offline/on subgroup alias. (Action: Eswaran Separate meeting to converge on the solution) |
|
3/20: No new update 3/12: Under review 3/5: Change requested by Veda. 2/24: No new update 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan, @Veda Ganesan |
Chassis Testing Effort:
|
Functional area |
Description |
PR# |
Owner |
Reviewed |
PR Status |
|
VoQ test plan |
Neighbor and Host IP Forwarding testcases and helpers |
Nokia |
|
|
4/12: approved by Xin, thanks! @saravanansv - please take a review and approve. |
|
4/5: All tests are passing, @Xin Wang , @Shuba - please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Azp few checks failed, @tcusto to address. 3/5: please assign reviewers @Ying, @Eswaran Baskaran |
|
PMON |
Add tests cont_link_flap, system_health, platform_info, reboot to run on T2 topology for VoQ chassis |
Nokia |
|
|
4/12: Change requested by Joe, Nokia team to address review comments. |
|
4/5: All tests passing, @Joe LeVeque could you please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. |
|
|
Thermal CLI test case |
|
Nokia |
|
Need json file for sonic build image |
|
LAG Test plan |
Test cases for LAG on Distributed VOQ System |
Nokia |
|
4/12: Review comments provided by Xin, thanks! Nokia team to address.
4/7: @yxieca @wangxin , @saravanansv - could you please take a look, thanks. |
|
4/12: Approved by Ying, thanks! @Abhishek - please review and approve. |
|
4/5: Under review by sanmalho-git; @Ying, @Xin Wang -could you please approve and merge. 3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Adapt testcases for SONiC Chassis |
Support for KVM based virtual T2 VoQ chassis |
Nokia |
|
|
4/12: Approved by Ying, thanks! Ready for Merge |
|
T1 Test case conversion |
|
Adapting FIP tests for T2 topology |
Nokia |
|
|
4/12: /12: Review comments provided by Xin, thanks! Nokia team to address. |
|
|
https://github.com/Azure/sonic-platform-common/pull/159 Merged |
Veda (Nokia) |
@ngoc-do Merged |
4/12: Merged, thanks Abhishek!
4/7: Abhishek to start azp run |
|
4/5: #6477 merged, ready for merge @Abhishek 3/24: Ready for merge after 6477 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! |
|
|
https://github.com/Azure/sonic-platform-daemons/pull/145 Merged |
Veda (Nokia) |
@ngoc-do Merged |
4/12: Merged, thanks Abhishek!
4/7: Abhishek to start azp run |
|
4/5: Ready for merge @Abhishek 3/24: Ready for merge after 6477 3/20: @Ngoc, @eswaran - please re-approve. 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! Do we need MSFT approval? @Abhishek please confirm 1/27: @eswaran, @Abhishek - could you please review and approve |
|
|
https://github.com/Azure/sonic-utilities/pull/1363 Merged |
Veda (Nokia) |
@ngoc-do Merged |
4/12: Merged, thanks Abhishek!
4/7: Veda to add test case |
|
4/5: Ready for merge @Abhishek 3/24: Ready for merge after 6477 3/20: @Ngoc, @eswaran - please re-approve. 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! Do we need MSFT approval? @Abhishek please confirm 1/27: @eswaran, @Abhishek- could you please review and approve |
|
Fabric port support Code PR |
https://github.com/Azure/sonic-buildimage/pull/6185 Merged |
Ngoc (Arista) |
|
4/7: Merged , Thanks Danny! |
|
4/5: Ready for merge, @Danny Please help with merge. 3/24: Can be merged after #1459 (post disabling the tests) 3/20: Approved by Srikanth, thanks! Ready for merge. 3/12: @Srikanth , @Guohan - please review and approve. 3/5: @Srikanth , @Guohan - please review and approve. 2/24: PR approved by Joe, thanks! 2/18: No new update 2/8: New PR, @Guohan, @Joe – could you please review and approve. |
|
|
https://github.com/Azure/sonic-buildimage/pull/6185 Merged |
Ngoc (Arista) |
@Srikanth Merged |
4/12: Merged, thanks Danny! |
|
4/5: Ready for merge, @Danny Please help with merge. 3/24: Can be merged after #1459 (post disabling the tests) 3/20: Approved by Srikanth, thanks! Ready for merge. 3/12: @Srikanth , @Guohan - please review and approve. 3/5: @Srikanth , @Guohan - please review and approve. 2/24: PR approved by Joe, thanks! 2/18: No new update 2/8: New PR, @Guohan, @Joe – could you please review and approve. |
|
Routing/BGP support for Chassis HLD |
https://github.com/Azure/SONiC/pull/674 Merged |
jmmikkel (Arista)
|
@Suresh Merged |
4/12: Merged, thanks Arvind! |
|
4/5: Approved by Arvind, Suresh, Eswaran, Guohan thanks! Ready for merge @Arvindsrinivasan 3/24: @Rita Hui, @Arvindsrinivasan could you please review and approve 3/12: Approved by Eswaran, thanks! @Rita Hui- could you please approve and merge. 3/5: Approved by Guohan, Suresh Thanks! @eswaran, @Rita Hui- could you please review and approve 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @eswaran, @Rita Hui- could you please review and approve |
Merged Test PRs:
|
4/5: Approved & Merged, Thanks Ying! |
|
3/20: Review comments provided by @Ying, Nokia team to address. 3/12: @Ying, @Xin, @Rita - Please review |
|
|
LLDP, SNMP, PortChannel |
Nokia |
|
4/12: Approved & Merged, thanks Xin! |
|
LAG Test plan |
|
LAG on Chassis Test case |
Nokia |
Yes |
|
4/12: Merged, thanks Xin! 4/7: @yxieca @wangxin , @saravanansv - could you please take a look, thanks. |
|
4/5: @Ying, @Xin Wang - could you please approve and merge. Need reviewers from Arista team @Eswaran Baskaran 3/20: @Ying, @Xin Wang - please approve and merge. 3/12: Need reviewers from Arista team @Eswaran Baskaran 3/5: Assigned to Ying, Xin. Need reviewers from Arista team @Eswaran Baskaran |
Thank You,
Anshu
From: Anshu Verma
Sent: Tuesday, April 6, 2021 5:05 PM
To: Judy Joseph <Judy....@microsoft.com>; Prabhu, Manjunath (Nokia - US/Mountain View) <manjunat...@nokia.com>; sonic-chass...@googlegroups.com; Eswaran Baskaran <esw...@arista.com>; Joe LeVeque <jole...@microsoft.com>; Danny Allen
<Daniel...@microsoft.com>; Abhishek Dosi <Abhish...@microsoft.com>; Rita Hui <Rita...@microsoft.com>; Guohan Lu <gu...@microsoft.com>; Ying Xie <Ying...@microsoft.com>; Xin Wang <xiw...@microsoft.com>; Duraisamy, Sureshkannan (Nokia - US/Mountain
View) <sureshkanna...@nokia.com>; Ganesan, Vedavinayagam (Nokia - US/Westford) <vedavinaya...@nokia.com>
Subject: [4/5/2021] SONiC Chassis Code & Test PR Status
Hi Team
Please find Weekly Status of Chassis Code and Test PRs below, also action items tagged for PR/review owners.
Summary:
· Progress 71%
· Total Merged PRs (incl. HLDs, Code, Test, HLDs) = 59
· Open PRs Total = 24
- Merged PRs last week = 4
- PRs ready for Merge = 9
- PRs under review this week = 15
<snip>
Thank You,
Anshu
Anshu Verma
Hi Team –
Please find Weekly Status of Chassis Code and Test PRs below, also action items tagged and highlighted for each PR/review owners.
Summary:
· Progress at 83% PR merge completion.
· Total Merged PRs (incl. HLDs, Code, Test, HLDs) = 69
· Open PRs Total = 14
· Merged PRs last week = 3
· PRs ready for Merge = 4
· PRs under review this week = 10
|
Feature |
PR |
Owner |
Reviewer - Status |
Action item |
|
PMON HLD |
Nokia |
@Judy Joseph - under review |
|
4/19: Approved by Judy, thanks. Awaiting review from Staphylo, @keboliu, @Junchao-Mellanox, @Joe |
|
4/5: Comments added by Judy 3/24: Review comments provided by Judy, no blocking issues. 3/20: No new update 3/12: No new update. @Judy - could you please review and approve 3/5: No new update 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Judy Joseph, could you please review and approve |
|
Inband Interface (port type) Code PR |
https://github.com/Azure/sonic-swss/pull/1602
|
Veda (Nokia) |
@song - approved @abdosi - Under review
|
|
4/19: Added PR Azure/SONiC#777 with the information of L2Header (Src/Dest Mac). @Abhishek , could you please review. |
|
4/12: Veda to update HLD with the information of L2Header (Src/Dest Mac) being used for the above packat flow. 4/5: In discussion Abhishek, Veda, Sreekanth. 3/20: Under review by @Abhishek 3/12: @Abhishek - please help with review & merge. 3/5: PR, approved, Thanks Song! Ready for Merge. 2/24: @Abhishek to help with test rerun 2/18: Song (Arista) provided review comments, thanks 2/8: No new update 1/27: @eswaran, @Abhishek - could you please review and approve |
|
Recycle port support HLD |
|
Song (Arista) |
|
@eswaran - approved @Arvindsrinivasan -pending @Suresh -approved @Rita – pending @Abhishek - change requested |
|
4/19: Song confirmed review comments addressed, @eswaran, @Rita Hui, @Abhishek , @Arvindsrinivasan - please review and approve. |
|
4/12: Song confirmed review comments addressed, @eswaran, @Rita Hui, @Abhishek , @Arvindsrinivasan - please review and approve.
4/7: Is the HLD updated with the review comments, so that in future there's no need to go to PR comments 4/5: Approved by Suresh, Eswaran, thanks! Ready for merge @Arvindsrinivasan 3/24: HLD to be reviewed in SONiC main community 3/20: Under review, to be discussed in subgroup meeting. 3/12: Approved by Srikanth, thanks! Updates requested by Rita and Abhishek. 3/5: Review in progress by Rita. @eswaran, @Arvindsrinivasan - could you please review and approve. 2/24: No new update 2/18: No new update 2/8: @eswaran, @Rita Hui, @Arvindsrinivasan - could you please review and approve 1/27: Need Nokia & MSFT reviewers assigned |
|
Fabric port support Code PR |
|
Ngoc (Arista) |
@minionatwork - pending @rlhui – pending @eswaran - pending @Abhishek - approved @Guohan Lu- change requested
|
|
4/19: @Guohan Lu could you please review & approve. 4/12: @Guohan Lu could you please review & approve. Approved by Abhishek, thanks! |
|
4/5: Fabric port check is disabled, @Abhishek , @Guohan Lu could you please review & approve. 3/24: Ngoc to Update #1459 to disable test 3/20: Review in progress, feedback provided by Ngoc to Abhishek. To be discussed in subgroup meeting. 3/12: Review in progress, feedback provided by Ngoc. 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8:Vs test cases added, Suresh, @Rita, @Guohan, @Abhishek- could you please review and approve 1/27: Suresh, @Rita- could you please review and approve |
|
Everflow support HLD |
Eswaran (Arista) |
@Abhishek - change requested @minionatwork - approved |
|
4/19: @eswaran - please confirm if review comments are addressed |
|
4/12: @eswaran - please confirm if review comments are addressed
4/7: @Abhishek , to close 4/5: @Eswaran to address review comment. 3/24: Change requested by @Abhishek @eswaran - please add the case where monitor port is the local port the behavior in both the scenarios. 3/12: Approved by Suresh, thanks! 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Abhishek- could you please review and approve |
|
Everflow support Code PR |
Song (Arista) |
@Abhishek - change requested @prsunny- pending @daall- pending @zhenggen-xu - pending @Guohan - under review |
|
4/12: Review comments added by Abhishek. @Prince, @Danny - could you please review and approve
4/5: @Abhishek, @Prince, @Danny - could you please review and approve 3/24: Abhishek to review 3/20: No new update, to be discussed in subgroup meeting. 3/12: No new update 3/5: No new update 2/24: No new update 2/18: Review comments provided by Guohan, thanks! 2/8: No new update 1/27: @Abhishek, @Prince, @Danny, @zhenggen-xu - could you please review and approve |
|
Inband Vlan Code PR |
|
Song (Arista) |
@Veda Ganesan – approved @Guohan - change requested @Abhishek - change requested |
|
4/12: Updates made by Song, thanks! @Guohan, @Abhishek- could you please review and approve
4/7: Song to update, Abhishek provided review comments. 4/5: PR approved by Veda, thanks! @Guohan - could you please review 3/24: #1605 and #1602 has tests cases to delete created neighbors, will fix test failing. 3/20: No new update, to be discussed in subgroup meeting. 3/12: @Guohan - could you please review and approve, @Veda Ganesan - please re-approve. 3/5: @Guohan - could you please review and approve. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda, thanks! 2/8: New PR, @Veda Ganesan – could you please review and approve. |
|
Minigraph support |
Maxime (Arista) |
@Arvindsrinivasan – change requested @Veda Ganesan – approved @Guohan - pending
|
|
4/19: @Arvindsrinivasan,@Guohan could you please review and approve. |
|
4/12: PR approved by Veda, thanks! @Arvindsrinivasan,@Guohan could you please review and approve.
4/5: Review comments addressed by Maxime, thanks! @Arvindsrinivasan, @Veda Ganesan - could you please review and approve. 3/24: Maxime to update 3/20: Change requested by @Arvindsrinivasan & @Veda Ganesan 3/12: No new update 3/5: No new update 2/24: Under review 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan , @Veda Ganesan |
|
|
Maxime (Arista) |
@Arvindsrinivasan – under review @Veda Ganesan – approved |
|
4/19: @Arvindsrinivasan - could you please review and approve. |
|
4/12: @Arvindsrinivasan - could you please review and approve.
4/5: Approved by Veda, thanks! 3/24: Eswaran, Suresh, Shyam, Judy, Arvind to discuss offline/on subgroup alias. (Action: Eswaran Separate meeting to converge on the solution) 3/20: No new update 3/12: Under review 3/5: Change requested by Veda. 2/24: No new update 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan, @Veda Ganesan |
Chassis Testing Effort:
|
Functional area |
Description |
PR# |
Owner |
Reviewed |
PR Status |
|
VoQ test plan |
Neighbor and Host IP Forwarding testcases and helpers |
Nokia |
|
|
4/19: @saravanansv - please take a review and approve. |
|
4/12: approved by Xin, thanks! @saravanansv - please take a review and approve.
4/5: All tests are passing, @Xin Wang , @Shuba - please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Azp few checks failed, @tcusto to address. 3/5: please assign reviewers @Ying, @Eswaran Baskaran |
|
PMON |
Add tests cont_link_flap, system_health, platform_info, reboot to run on T2 topology for VoQ chassis |
Nokia |
|
|
4/19: @Ying- could you please assign reviewer. |
|
4/12: Change requested by Joe, Nokia team to address review comments. 4/5: All tests passing, @Joe LeVeque could you please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. |
|
|
Thermal CLI test case |
|
Nokia |
|
Need json file for sonic build image |
|
LAG Test plan |
Test cases for LAG on Distributed VOQ System |
Nokia |
|
|
4/19: PR approved by Xin, Ready for merge. |
|
4/19: @Abhishek - please review and approve, thanks. |
|
4/12: Approved by Ying, thanks! @Abhishek - please review and approve. 4/5: Under review by sanmalho-git; @Ying, @Xin Wang -could you please approve and merge. 3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
T1 Test case conversion |
|
Adapting FIP tests for T2 topology |
Nokia |
|
|
4/19: Approved by Xin. Ready for Merge. |
|
4/12: Review comments provided by Xin, thanks! Nokia team to address. |
4/5:All test passing @Xin Wang - could you please approve and merge. |
|
4/12: Merged, thanks Abhishek! |
|
4/7: Abhishek to start azp run 4/5: #6477 merged, ready for merge @Abhishek 3/24: Ready for merge after 6477 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! |
|
|
https://github.com/Azure/sonic-platform-daemons/pull/145 Merged |
Veda (Nokia) |
@ngoc-do
|
|
4/12: Merged, thanks Abhishek! |
|
4/7: Abhishek to start azp run 4/5: Ready for merge @Abhishek 3/24: Ready for merge after 6477 3/20: @Ngoc, @eswaran - please re-approve. 3/12: @Ngoc - please re-approve. PR approved by Abhishek, thanks! 3/5: No new update, : @Abhishek please help with test rerun. PR was approved by Ngoc. 2/24: @Abhishek to help with test rerun 2/18: @Rita, @Guohan - could you please help with Merge. 2/8: PR approved by Ngoc (Arista), thanks! Do we need MSFT approval? @Abhishek please confirm 1/27: @eswaran, @Abhishek - could you please review and approve |
|
|
https://github.com/Azure/sonic-utilities/pull/1363 Merged |
Veda (Nokia) |
@ngoc-do
|
|
4/12: Merged, thanks Abhishek! |
|
Routing/BGP support for Chassis HLD |
|
https://github.com/Azure/SONiC/pull/674 Merged |
jmmikkel (Arista)
|
@Suresh
|
|
4/12: Merged, thanks Arvind! |
|
4/5: Approved by Arvind, Suresh, Eswaran, Guohan thanks! Ready for merge @Arvindsrinivasan 3/24: @Rita Hui, @Arvindsrinivasan could you please review and approve 3/12: Approved by Eswaran, thanks! @Rita Hui- could you please approve and merge. 3/5: Approved by Guohan, Suresh Thanks! @eswaran, @Rita Hui- could you please review and approve 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @eswaran, @Rita Hui- could you please review and approve |
|
Routing/BGP support for Chassis Code PR |
https://github.com/Azure/sonic-buildimage/pull/5622 Merged
|
jmmikkel (Arista) |
@venkat (Dell)
|
4/19: Merged, thanks Arvind! 4/12: Veda, Suresh (Nokia) please re-approve. |
|
4/7: Nokia to also approve. 4/5: PR approved by Arvind, thanks! Ready for merge. 3/24: Comments addressed, Arvind to approve and merge. 3/20: Approved by Suresh, thanks! Under review by @Arvindsrinivasan, @eswaran. 3/12: Feedback provided by Jmmikkel, @eswaran, @Rita Hui, @Suresh, @Arvindsrinivasan - could you please review and approve 3/5: Review in progress by Arvind. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda (Nokia), thanks! 2/8: No new update 1/27: Veda, Suresh, @Rita Hui, @Arvindsrinivasan could you please review and approve |
|
https://github.com/Azure/sonic-buildimage/pull/5629
(Critical for testcase pass) |
Merged |
jmmikkel (Arista) |
|
4/19: Merged, thanks Arvind! |
|
4/12: Rita to sync-up with Guohan 4/7: Rita to sync-up with Guohan 4/5: PR approved by Arvind, thanks! Ready for merge. 3/24: New FRR patch raised and update code PR with new FRR patch (action: Joanne) (Action: Rita to confirm if we can bring in FRR patch and get back to Eswaran) (Action: Eswaran - pending FRR community to approve patch) 3/20: @Jmmikkel - please fix conflicts 3/12: @Jmmikkel - please fix conflicts 3/5: Review in progress by Arvind. 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Arvindsrinivasan - could you please review and approve |
Merged Test PRs:
|
|
Support for KVM based virtual T2 VoQ chassis |
Nokia |
Yes |
4/19: Approved & Merged, thank Ying! |
|
4/12: Approved by Ying, thanks! |
|
3/29: New PR created |
|
VOQ test plan |
Thanks,
Anshu Verma
Hi Team –
Please find Weekly Status of Chassis Code and Test PRs below, also action items tagged and highlighted for each PR/review owners.
PR and review owners please plan to join tomorrow’s Chassis Subgroup meeting (9-10am pst) for Status update.
Summary:
· Progress at 87%
· Total Merged PRs (incl. HLDs, Code, Test, HLDs) = 72
· Open PRs Total = 11
· Merged PRs last week = 3
· PRs ready for Merge = 5
· PRs under review this week = 6
|
Feature |
PR |
Owner |
Reviewer - Status |
Action item |
|
PMON HLD |
Nokia |
@Judy Joseph - under review |
|
4/27: Awaiting review from Staphylo, @keboliu, @Junchao-Mellanox, @Joe |
|
4/19: Approved by Judy, thanks. Awaiting review from Staphylo, @keboliu, @Junchao-Mellanox, @Joe 4/5: Comments added by Judy 3/24: Review comments provided by Judy, no blocking issues. 3/20: No new update 3/12: No new update. @Judy - could you please review and approve 3/5: No new update 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Judy Joseph, could you please review and approve |
|
Recycle port support HLD |
|
https://github.com/Azure/SONiC/pull/742 Ready for merge |
Song (Arista) |
@eswaran - approved @Arvindsrinivasan -pending @Suresh -approved @Rita – pending @Abhishek - change requested Ready for merge |
|
4/27: No new update |
|
4/19: Song confirmed review comments addressed, @eswaran, @Rita Hui, @Abhishek , @Arvindsrinivasan - please review and approve. 4/12: Song confirmed review comments addressed, @eswaran, @Rita Hui, @Abhishek , @Arvindsrinivasan - please review and approve. 4/7: Is the HLD updated with the review comments, so that in future there's no need to go to PR comments 4/5: Approved by Suresh, Eswaran, thanks! Ready for merge @Arvindsrinivasan 3/24: HLD to be reviewed in SONiC main community 3/20: Under review, to be discussed in subgroup meeting. 3/12: Approved by Srikanth, thanks! Updates requested by Rita and Abhishek. 3/5: Review in progress by Rita. @eswaran, @Arvindsrinivasan - could you please review and approve. 2/24: No new update 2/18: No new update 2/8: @eswaran, @Rita Hui, @Arvindsrinivasan - could you please review and approve 1/27: Need Nokia & MSFT reviewers assigned |
|
Fabric port support Code PR |
Ngoc (Arista) |
@minionatwork - pending @rlhui – pending @eswaran - pending @Abhishek - approved @Guohan Lu- change requested
|
|
4/27: @Guohan Lu please review & approve. 4/19: @Guohan Lu please review & approve. 4/12: @Guohan Lu please review & approve. Approved by Abhishek, thanks! |
|
4/5: Fabric port check is disabled, @Abhishek , @Guohan Lu could you please review & approve. 3/24: Ngoc to Update #1459 to disable test 3/20: Review in progress, feedback provided by Ngoc to Abhishek. To be discussed in subgroup meeting. 3/12: Review in progress, feedback provided by Ngoc. 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8:Vs test cases added, Suresh, @Rita, @Guohan, @Abhishek- could you please review and approve 1/27: Suresh, @Rita- could you please review and approve |
|
Everflow support HLD |
Eswaran (Arista) |
@Abhishek - change requested @minionatwork - approved |
|
4/27: @'Eswaran Baskaran' - please confirm if review comments are addressed 4/19: @'Eswaran Baskaran' - please confirm if review comments are addressed 4/12: @'Eswaran Baskaran'- please confirm if review comments are addressed |
|
4/7: @Abhishek , to close 4/5: @Eswaran to address review comment. 3/24: Change requested by @Abhishek @eswaran - please add the case where monitor port is the local port the behavior in both the scenarios. 3/12: Approved by Suresh, thanks! 3/5: Review in progress by Abhishek 2/24: No new update 2/18: No new update 2/8: No new update 1/27: @Abhishek- could you please review and approve |
|
Everflow support Code PR |
Song (Arista) |
@Abhishek - change requested @prsunny- pending @daall- pending @zhenggen-xu - pending @Guohan - under review |
|
4/27: @Prince Sunny, @Danny - could you please review and approve 4/19: @Prince Sunny, @Danny - could you please review and approve 4/12: Review comments added by Abhishek. @Prince Sunny, @Danny - could you please review and approve |
|
4/5: @Abhishek, @Prince, @Danny - could you please review and approve 3/24: Abhishek to review 3/20: No new update, to be discussed in subgroup meeting. 3/12: No new update 3/5: No new update 2/24: No new update 2/18: Review comments provided by Guohan, thanks! 2/8: No new update 1/27: @Abhishek, @Prince, @Danny, @zhenggen-xu - could you please review and approve |
|
Inband Vlan Code PR |
Song (Arista) |
|
@Veda Ganesan – approved @Guohan - change requested @Abhishek - change requested |
@Prince - Change requested |
4/27: Review comments provided by @Prince |
|
4/19: @Guohan, @Abhishek- could you please review and approve 4/12: Updates made by Song, thanks! @Guohan, @Abhishek- could you please review and approve
4/7: Song to update, Abhishek provided review comments. 4/5: PR approved by Veda, thanks! @Guohan - could you please review 3/24: #1605 and #1602 has tests cases to delete created neighbors, will fix test failing. 3/20: No new update, to be discussed in subgroup meeting. 3/12: @Guohan - could you please review and approve, @Veda Ganesan - please re-approve. 3/5: @Guohan - could you please review and approve. 2/24: PR approved by Veda, thanks! 2/18: Review comments provided by Veda, thanks! 2/8: New PR, @Veda Ganesan – could you please review and approve. |
|
Minigraph support |
|
Maxime (Arista) |
@Arvindsrinivasan – under review @Veda Ganesan – approved |
|
4/27: @Arvindsrinivasan - could you please review and approve. |
|
4/19: @Arvindsrinivasan - could you please review and approve. 4/12: @Arvindsrinivasan - could you please review and approve.
4/5: Approved by Veda, thanks! 3/24: Eswaran, Suresh, Shyam, Judy, Arvind to discuss offline/on subgroup alias. (Action: Eswaran Separate meeting to converge on the solution) 3/20: No new update 3/12: Under review 3/5: Change requested by Veda. 2/24: No new update 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan, @Veda Ganesan |
Chassis Testing Effort:
|
Functional area |
Description |
PR# |
Owner |
Reviewed |
PR Status |
|
VoQ test plan |
Neighbor and Host IP Forwarding testcases and helpers |
Nokia |
|
|
4/27: @saravanansv - please take a review and approve. |
|
4/19: @saravanansv - please take a review and approve. 4/12: approved by Xin, thanks! @saravanansv - please take a review and approve.
4/5: All tests are passing, @Xin Wang , @Shuba - please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: Azp few checks failed, @tcusto to address. 3/5: please assign reviewers @Ying, @Eswaran Baskaran |
|
PMON |
Add tests cont_link_flap, system_health, platform_info, reboot to run on T2 topology for VoQ chassis |
Nokia |
|
|
4/27: Approved by @Ying, @Joe. Ready for merge. |
|
4/19: @Ying- could you please assign reviewer. 4/12: Change requested by Joe, Nokia team to address review comments. 4/5: All tests passing, @Joe LeVeque could you please review and approve. 3/24: unrelated failures in pipeline. Needs re-run @Ying. |
|
|
Thermal CLI test case |
|
Nokia |
|
Need json file for sonic build image |
|
BGP on Chassis Test plan |
|
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Fabric Test plan |
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Everflow support Test plan |
Placeholder |
|
Arista |
|
3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
Minigraph support in sonic-mgmt |
Minigraph support in sonic-mgmt |
Arista |
|
|
4/27: Under review @Arvindsrinivasan @Abhishek. |
|
4/19: @Abhishek - please review and approve, thanks. 4/12: Approved by Ying, thanks! @Abhishek - please review and approve. 4/5: Under review by sanmalho-git; @Ying, @Xin Wang -could you please approve and merge. 3/20: No new update 3/12: No new update 3/5: Need ETA from Arista team @Eswaran Baskaran |
|
T1 Test case conversion |
Adapting FIP tests for T2 topology |
Nokia |
|
|
4/27: @Arvindsrinivasan @Rita - please review and approve 4/19: Approved by Xin. |
|
Inband Interface (port type) Code PR |
https://github.com/Azure/sonic-swss/pull/1602 Merged |
Veda (Nokia) |
@song
|
4/27: Merged, thanks Abhishek, Veda, Song! |
|
4/19: Added PR Azure/SONiC#777 with the information of L2Header (Src/Dest Mac). @Abhishek , could you please review. 4/12: Veda to update HLD with the information of L2Header (Src/Dest Mac) being used for the above packat flow. 4/5: In discussion Abhishek, Veda, Sreekanth. 3/20: Under review by @Abhishek 3/12: @Abhishek - please help with review & merge. 3/5: PR, approved, Thanks Song! Ready for Merge. 2/24: @Abhishek to help with test rerun 2/18: Song (Arista) provided review comments, thanks 2/8: No new update 1/27: @eswaran, @Abhishek - could you please review and approve |
|
Minigraph support |
https://github.com/Azure/sonic-buildimage/pull/5991 Merged |
Maxime (Arista) |
4/27: Merged, Thanks Arvind, Maxime, Veda! |
|
4/19: @Arvindsrinivasan,@Guohan could you please review and approve. 4/12: PR approved by Veda, thanks! @Arvindsrinivasan,@Guohan could you please review and approve. 4/5: Review comments addressed by Maxime, thanks! @Arvindsrinivasan, @Veda Ganesan - could you please review and approve. 3/24: Maxime to update 3/20: Change requested by @Arvindsrinivasan & @Veda Ganesan 3/12: No new update 3/5: No new update 2/24: Under review 2/18: No new update 2/8: New PR, under review by @Arvindsrinivasan , @Veda Ganesan |
Merged Test PRs:
|
|
Test cases for LAG on Distributed VOQ System
|
Nokia |
|
4/27: Merged, thanks Xin! 4/19: PR approved by Xin |
|
4/12: Review comments provided by Xin, thanks! Nokia team to address. 4/7: @yxieca @wangxin , @saravanansv - could you please take a look, thanks. 4/5: All tests passing, @Ying, @Xin Wang - could you please approve and merge. 3/24: unrelated failures in pipeline. Needs re-run @Ying. 3/20: @Ying please review and help restart the pipeline. |
Thanks,
Anshu
Heidi net
> You received this message because you are subscribed to the Google Groups "sonic-chassis-subgroup" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sonic-chassis-sub...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sonic-chassis-subgroup/BYAPR21MB133565BE5B983988A5DBC64BB1419%40BYAPR21MB1335.namprd21.prod.outlook.com.
Heidi net
> You received this message because you are subscribed to the Google Groups "sonic-chassis-subgroup" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sonic-chassis-sub...@googlegroups.com.