Jenkins Plugin - Non-ASCII characters broken in build output if system encoding is not UTF-8

[Arend v. Reinersdorff]

Hi,

here's a minor issue with the SonarQube Jenkins Plugin:

If the system encoding is not UTF-8, non-ASCII characters in the build output are broken. For example our nightly SonarQube build outputs all say at the top "Build wurde zeitgesteuert ausgel�st.".

Versions:

• Jenkins 1.651.2 LTS
  
• SonarQube Jenkins Plugin 2.4.3

Reproduce:

1. Run Jenkins with a non-UTF-8 system encoding.
• In my case Cp1252, german Windows encoding
  
• Or set -Dfile.encoding=ISO-8859-1 at Jenkins startup
2. Create a job that outputs some non-ASCII characters
• For example Add build step > Execute Windows batch command > Insert command "echo ßönärQübe"
3. Under build environment select checkbox Prepare SonarQube Scanner environment

Result is that the non-ASCII characters are broken, for example "��n�rQ�be".

Looking into the Github project I found a possible cause in MaskPasswordsOutputStream.eol(). The method assumes the underlying OutputStream is UTF-8 encoded. It looks more like the underlying stream uses the system  encoding.

Best regards,

Arend

[Arend v. Reinersdorff]

Any comment on this?

[Julien HENRY]

Hi Arend,

Thanks for feedback and good investigation.

I have created a ticket:

https://jira.sonarsource.com/browse/SONARJNKNS-257

++

Julien

[Julien HENRY]

Hi Arend,

Would you mind testing the RC1 of 2.4.4 version to confirm the issue is fixed?

https://groups.google.com/forum/#!topic/sonarqube/72R43f223GQ

++

Julien

[Arend v. Reinersdorff]

Hi Julien,

thanks a lot for the fix :-) I just tested version 2.4.4 of the Jenkins plugin and it works well.

Sorry for not replying earlier, I have been sick for a week.

Best regards,
Arend

[Julien HENRY]

No problem Arend, I hope you are getting well. Thanks for the feedback.