NullPointerException while analyzing

68 views

Skip to first unread message

dboc...@redhat.com

unread,

Sep 15, 2017, 12:24:18 PM9/15/17

to SonarQube

We bumped into the NPE, take a look, please:

[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.3.0.603:sonar (default-cli) on project openshift: SonarQube is unable to analyze file : '/mnt/hudson_workspace/workspace/jbosstools-openshift-Pull-Request/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/explorer/OpenShiftExplorerLabelProvider.java': NullPointerException -> [Help 1]

Launched it the following way: mvn clean verify sonar:sonar
The source file is here: https://github.com/jbosstools/jbosstools-openshift/pull/1559/files#diff-a0fd91d14f34262decad12ba1e0e0eb2:

/*******************************************************************************
 * Copyright (c) 2015-2017 Red Hat, Inc.
 * Distributed under license by Red Hat, Inc. All rights reserved.
 * This program is made available under the terms of the
 * Eclipse Public License v1.0 which accompanies this distribution,
 * and is available at http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     Red Hat, Inc. - initial API and implementation
 ******************************************************************************/
package org.jboss.tools.openshift.internal.ui.explorer;

import java.util.Collection;

import org.eclipse.core.runtime.IAdaptable;
import org.eclipse.jface.viewers.StyledString;
import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.graphics.TextStyle;
import org.eclipse.swt.widgets.Display;
import org.eclipse.ui.navigator.IDescriptionProvider;
import org.jboss.tools.openshift.common.core.utils.StringUtils;
import org.jboss.tools.openshift.core.connection.Connection;
import org.jboss.tools.openshift.internal.common.ui.OpenShiftCommonImages;
import org.jboss.tools.openshift.internal.common.ui.explorer.BaseExplorerLabelProvider;
import org.jboss.tools.openshift.internal.ui.OpenShiftImages;
import org.jboss.tools.openshift.internal.ui.models.IResourceWrapper;
import org.jboss.tools.openshift.internal.ui.models.IServiceWrapper;
import org.jboss.tools.openshift.internal.ui.wizard.newapp.IApplicationSource;
import org.jboss.tools.openshift.internal.ui.wizard.newapp.fromimage.ImageStreamApplicationSource;
import org.jboss.tools.openshift.internal.ui.wizard.newapp.fromtemplate.TemplateApplicationSource;

import com.openshift.restclient.ResourceKind;
import com.openshift.restclient.model.IBuild;
import com.openshift.restclient.model.IBuildConfig;
import com.openshift.restclient.model.IDeploymentConfig;
import com.openshift.restclient.model.IImageStream;
import com.openshift.restclient.model.IPod;
import com.openshift.restclient.model.IProject;
import com.openshift.restclient.model.IReplicationController;
import com.openshift.restclient.model.IResource;
import com.openshift.restclient.model.IService;
import com.openshift.restclient.model.route.IRoute;

/**
 * @author jeff.cantrill
 * @author Andre Dietisheim
 * @author Jeff Maury
 */
public class OpenShiftExplorerLabelProvider extends BaseExplorerLabelProvider implements IDescriptionProvider {
	//Limit for label length = baseText.length + qualifiedText.length
	private static final int DEFAULT_LABEL_LIMIT = 60;

	private int labelLimit;

	public OpenShiftExplorerLabelProvider() {
		setLabelLimit(DEFAULT_LABEL_LIMIT);
	}

	/**
	 * Set limit of label length in characters. 
	 * @param limit
	 */
	public void setLabelLimit(int limit) {
		if (limit <= 0) {
			throw new IllegalArgumentException("Label limit cannot be less than 1: " + limit);
		}
		labelLimit = limit;
	}

	@Override
	public String getText(Object element) {
		if (element instanceof IProject) {
			IProject project = (IProject) element;
			String name = project.getName();
			if (org.apache.commons.lang.StringUtils.isNotEmpty(project.getDisplayName())) {
				String[] parts = new String[] { project.getDisplayName(), name };
				applyEllipses(parts);
				name = parts[0] + " (" + parts[1] + ")";
			}
			return name;
		}
		return super.getText(element);
	}

	@Override
	public Image getImage(Object element) {
		element = getAdaptedElement(element);
		if (element instanceof NewProjectLinkNode) {
			return OpenShiftImages.PROJECT_NEW_IMG;
		} else if (element instanceof IResource) {
			IResource resource = (IResource) element;
			switch (resource.getKind()) {
			case ResourceKind.BUILD:
				return OpenShiftImages.BUILD_IMG;
			case ResourceKind.BUILD_CONFIG:
				return OpenShiftImages.BUILDCONFIG_IMG;
			case ResourceKind.IMAGE_STREAM:
				return OpenShiftImages.IMAGE_IMG;
			case ResourceKind.POD:
				return OpenShiftImages.BLOCKS_IMG;
			case ResourceKind.PROJECT:
				return OpenShiftImages.PROJECT_IMG;
			case ResourceKind.ROUTE:
				return OpenShiftImages.ROUTE_IMG;
			case ResourceKind.SERVICE:
				return OpenShiftImages.SERVICE_IMG;
			case ResourceKind.REPLICATION_CONTROLLER:
			case ResourceKind.DEPLOYMENT_CONFIG:
				return OpenShiftImages.REPLICATION_CONTROLLER_IMG;
			default:
				return OpenShiftCommonImages.FILE;
			}
		} else if (element instanceof ImageStreamApplicationSource) {
			return OpenShiftImages.IMAGE_IMG;
		} else if (element instanceof TemplateApplicationSource) {
			return OpenShiftImages.TEMPLATE_IMG;
		} else {
			return super.getImage(element);
		}
	}

	private Object getAdaptedElement(Object element) {
		if (element instanceof IAdaptable) {
			IAdaptable adaptable = (IAdaptable) element;
			IResource resource = adaptable.getAdapter(IResource.class);
			if (resource != null) {
				element = resource;
			}
			Connection connection = adaptable.getAdapter(Connection.class);
			if (connection != null) {
				element = connection;
			}
		}
		return element;
	}

	@Override
	public StyledString getStyledText(Object element) {
		if (element instanceof IServiceWrapper) {
			IServiceWrapper d = (IServiceWrapper) element;
			return style(d.getWrapped().getName(), formatRoute(d.getResourcesOfKind(ResourceKind.ROUTE)));
		}
		element = getAdaptedElement(element);
		if (element instanceof NewProjectLinkNode) {
			return getStyledText((NewProjectLinkNode) element);
		} else if (element instanceof IApplicationSource) {
			return getStyledText((IApplicationSource) element);
		}
		if (element instanceof IResource) {
			IResource resource = (IResource) element;
			switch (resource.getKind()) {
			case ResourceKind.BUILD:
				return getStyledText((IBuild) resource);
			case ResourceKind.BUILD_CONFIG:
				return getStyledText((IBuildConfig) resource);
			case ResourceKind.DEPLOYMENT_CONFIG:
				return getStyledText((IDeploymentConfig) resource);
			case ResourceKind.IMAGE_STREAM:
				return getStyledText((IImageStream) resource);
			case ResourceKind.POD:
				return getStyledText((IPod) resource);
			case ResourceKind.PROJECT:
				return getStyledText((IProject) resource);
			case ResourceKind.ROUTE:
				return getStyledText((IRoute) resource);
			case ResourceKind.REPLICATION_CONTROLLER:
				return getStyledText((IReplicationController) resource);
			case ResourceKind.SERVICE:
				IService service = (IService) resource;
				return getStyledText(service);
			default:
				break;
			}
		}
		if (element instanceof Connection) {
			return getStyledText((Connection) element);
		}
		return super.getStyledText(element);
	}

	private String formatRoute(Collection<IResourceWrapper<?, ?>> routes) {
		if (routes.size() > 0) {
			IRoute route = (IRoute) routes.iterator().next().getWrapped();
			return route.getURL();

		}
		return "";
	}

	private StyledString getStyledText(IService service) {
		String serviceQualifiedText = String.format("selector: %s", StringUtils.serialize(service.getSelector()));
		return style(service.getName(), serviceQualifiedText);
	}

	private StyledString getStyledText(IReplicationController replicationController) {
		return style(replicationController.getName(),
				String.format("selector: %s", StringUtils.serialize(replicationController.getReplicaSelector())));
	}

	private StyledString getStyledText(IRoute route) {
		return style(route.getName(), String.format("%s%s", route.getHost(), route.getPath()));
	}

	private StyledString getStyledText(IBuild build) {
		return style(build.getName(),
				build.getStatus() == null ? "Build" : String.format("%s %s", "Build", build.getStatus()));
	}

	private StyledString getStyledText(IBuildConfig config) {
		return style(config.getName(), config.getSourceURI());
	}

	private StyledString getStyledText(IDeploymentConfig config) {
		return style(config.getName(),
				String.format("selector: %s", StringUtils.serialize(config.getReplicaSelector())));
	}

	private StyledString getStyledText(IPod pod) {
		return style(pod.getName(), pod.getStatus() == null ? "Pod" : String.format("%s %s", "Pod", pod.getStatus()));
	}

	private StyledString getStyledText(IImageStream repo) {
		return style(repo.getName(), repo.getDockerImageRepository().toString());
	}

	private StyledString getStyledText(Connection conn) {
		String prefix = org.apache.commons.lang.StringUtils.defaultIfBlank(conn.getUsername(), "<unknown user>");
		if (prefix == null) {
			prefix = "<unknown user>";
		}
		return style(prefix, conn.toString());
	}

	private StyledString getStyledText(IApplicationSource source) {
		String tags = NLS.bind("({0})", org.apache.commons.lang.StringUtils.join(source.getTags(), ", "));
		StringBuilder qualifier = new StringBuilder();
		if (!StringUtils.isEmpty(tags)) {
			qualifier.append(tags);
		}
		if (!StringUtils.isEmpty(source.getNamespace())) {
			qualifier.append(" - ").append(source.getNamespace());
		}
		return style(source.getName(), qualifier.toString());
	}

	private StyledString getStyledText(IProject project) {
		if (org.apache.commons.lang.StringUtils.isNotBlank(project.getDisplayName())) {
			return style(project.getDisplayName(), project.getName());
		}
		return style(project.getName(), "");
	}

	private StyledString style(String baseText, String qualifiedText) {
		String[] parts = new String[] { baseText, qualifiedText };
		applyEllipses(parts);
		baseText = parts[0];
		qualifiedText = parts[1];
		StyledString value = new StyledString(baseText);
		if (org.apache.commons.lang.StringUtils.isNotBlank(qualifiedText)) {
			value.append(" ").append(qualifiedText, StyledString.QUALIFIER_STYLER);

		}
		return value;
	}

	private void applyEllipses(String[] parts) {
		StringUtils.shorten(parts, labelLimit);
	}

	private StyledString getStyledText(NewProjectLinkNode node) {
		StyledString value = new StyledString();
		value.append(node.toString(), new StyledString.Styler() {

			@Override
			public void applyStyles(TextStyle textStyle) {
				textStyle.underline = true;
				textStyle.foreground = Display.getDefault().getSystemColor(SWT.COLOR_BLUE);
			}

		});
		return value;
	}

	//Status line has with CLabel its own ellipses adjusting string to available space.
	//We could set Integer.MAX_VALUE as limit, but performance will be too low for really long texts.
	private static final int STATUS_LINE_LABEL_LIMIT = 512;

	private static final OpenShiftExplorerLabelProvider instanceForDescription;

	static {
		instanceForDescription = new OpenShiftExplorerLabelProvider();
		instanceForDescription.setLabelLimit(STATUS_LINE_LABEL_LIMIT);
	}

	@Override
	public String getDescription(Object anElement) {
		return instanceForDescription.getStyledText(anElement).getString();
	}
}

Nicolas Peru

unread,

Sep 16, 2017, 3:04:41 AM9/16/17

to dboc...@redhat.com, SonarQube

Hi,

Can you share the whole stacktrace ? Can you also specify what is the version of SonarJava running the analysis ?

Thanks

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/2c815459-0f16-4546-917b-b0c059d7d06a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Nicolas Peru | SonarSource

Senior Developer

http://t witter.com/benzonico

http://sonarsource.com

andre dietisheim

unread,

Sep 25, 2017, 8:12:43 AM9/25/17

to SonarQube

HI Nicolas

Thanks for jumping in, but this is the same problem that we discussed last week in https://groups.google.com/forum/?hl=en#!topic/sonarqube/t7-A4M_Ohd0 that is caused by https://jira.sonarsource.com/browse/SONARJAVA-2461. We'll wait for the upgrade to 4.14 to happen in https://sonarcloud.io which should resolve the issue.