False positive for php:S2037 "Static members should be referenced with "static::"

[Gabriele Santini]

Hi, I think there is a problems with this rule.

I get a report even if the class including the static reference is declared "final".

For me this is a false positive, as in this case you cannot distinguish between the use of "self" and of "static".

[Pierre-Yves Nicolas]

Hi Gabriele,

Your suggestion seems reasonable.

We should probably also filter out cases where the called method is declared as final, don't you think?

Regards,

Pierre-Yves

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/fc82a4ff-1a2e-4ecc-abf2-db0b5329e4f6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Gabriele Santini]

Hi Pierre-Yves,

Yes definitely. 

Thank you for hearing :)

[Pierre-Yves Nicolas]

Hi Gabriele,

I created the following ticket:

https://jira.sonarsource.com/browse/SONARPHP-598

Thanks!

Pierre-Yves

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/90180666-57f1-4671-af3c-a100567914d6%40googlegroups.com.