Java - Visibility of an attribute in an enum

[antoine....@gmail.com]

Hi,
is it the way to report an issue?

Simple code quality bug that just occured to me :

public enum A {
    private final String value;
}

public enum B {
    final String value;
}

On enum A, Sonar will raise a : MINOR "private" is redundant in this context.
On enum B, Sonar will raise a : MAJOR Explicitly declare the visibility for "value".

Following the language specifications, the first one should not raise any comment from Sonar.

Antoine.

[Nicolas Peru]

Hi Antoine, 

Which version of SonarJava are you using ? 

I can't reproduce the issue which (if I understand correctly) should be that the rule squid:S2333 about redudant modifiers should not raise an issue on private enum fields (it raises an issue on enum constructors though which is correct because they are implicitely private). 

Cheers, 

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/1fd30c2c-f70f-41cf-8ddf-0cf04640e019%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Nicolas Peru | SonarSource

Senior Developer

https://twitter.com/benzonico

https://sonarsource.com

[antoine....@gmail.com]

Hello Nicola, thanks for your answer. We are using SonarQube v6.6 (build 32724), our Java analyzer is the last one (I don't have admin rights and can't tell you the exact version number, but it is updated regularly, so the latest stable release it should be)

[antoine....@gmail.com]

To be exact, this is the part of our code that raised both Sonar remarks :

public enum MyEnum{
    A("a"),
    B("b");

    private final String value;

    MyEnum(String value){
        this.value = value;
    }

    public String getValue(){
        return value;
    }
}

The warnings were raised on the "private final String value;" line.

[Nicolas Peru]

Hi, 

So what is the problem ? I don't understand your issue.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/ad25b3db-7fd5-4f66-bac7-992d087dd50d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[antoine....@gmail.com]

Why did Sonar raised a warning for both syntaxes on the "value" attribute (with and without the "private" modifier)?