[PHP] SonarAnalyzer rules : Static members should be referenced with "static::"

[jason.br...@gmail.com]

Hi,


I think the rule 'Static members should be referenced with "static::"' should have another exception:

Consider this code:

class SomeClass
    private static $somevar = null;

    private static function getVars()
    {
        if (self::$somevar == null) {
            self::$somevar = array();
        }
    }
}

The sonar rule report error on self::$somevar lines, but as these are used in a private function, i find no reason to prefer static::$somevar over self::$somevar...
What do you think?

[Elena Vilchik]

Hello,

Ticket is created to improve the rule SONARPHP-644

Thanks for the feedback!

Elena VILCHIK | SonarSource
Language Team

http://sonarsource.com