false positive for lombok @EqualsAndHashCode and compareTo

[t...@berrycloud.co.uk]

Hi

When using the annotations @EqualsAndHashCode, @Value or @Data from Project Lombok, Sonar Java plugin states that equals should be overridden to comply with the contract of compare however equals has already been overridden so I consider this a false positive.

I am using the sonar maven plugin. I am using java plugin version 3.5.

for example:

					@Value @Builder
					public class SimpleInstance implements Comparable<SimpleInstance> {
					private final String type;
					@Override
					public int compareTo(SimpleInstance other) { Override "equals(Object obj)" to comply with the contract of the "compareTo(T o)" method.

[sergey4c...@gmail.com]

True story, I have a related issue with Java plugin version 3.7, assembled from source code (in hope to avoid this problem).

@Data @EqualsAndHashCode(callSuper = true)
public class FeedbackFinalScoreEntity extends IdentityBean{
    private Double finalScore;
    private Integer index;
}

Sonar message:  Override this superclass' "equals" method., SonarQube rule: squid:S2160

понедельник, 12 октября 2015 г., 15:50:03 UTC+3 пользователь t...@berrycloud.co.uk написал:

[Nicolas Peru]

Hi, 

Sorry for the delay of reply but this will finally be adressed : https://jira.sonarsource.com/browse/SONARJAVA-1513 

Cheers,

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/87afd9e4-4bac-4d9c-b585-f36959720095%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[t...@berrycloud.co.uk]

Great thanks for letting me know.  Sonar is a fantastic tool keep up the good work.

[t...@nestcottage.co.uk]

Hi was this fixed in 3.12?  The above code still seems to be generating false positives. Asides from updating to 3.12 and rerunning the analysis is there anything else I need to do?

On Friday, 5 February 2016 09:57:37 UTC+1, Nicolas Peru wrote:

[Michael Gumowski]

Hello,

The issue has been fixed for version 3.12 of the Java plugin, which should be publicly released pretty soon.

Once released, you will just need to update the java plugin and rerun the analysis to get rid of the issues. However, be sure to provide the bytecode for your analysis.

Regards,

Michael GUMOWSKI | SonarSource

Software Developer @ Language Team
http://sonarsource.com

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/69eb573f-7ae5-42ae-9b18-2bba338f6082%40googlegroups.com.

[t...@nestcottage.co.uk]

Hi

I've updated to version 3.12 but it makes no difference.

The problem seems to  be caused by the following check https://github.com/SonarSource/sonar-java/blob/master/java-checks/src/main/java/org/sonar/java/checks/EqualsNotOverridenWithCompareToCheck.java 

I have created some tests for https://github.com/SonarSource/sonar-java/blob/master/java-checks/src/test/files/checks/EqualsNotOverridenWithCompareToCheck.java as a pull request, I hope that is helpful (and correct).

Many thanks

[Michael Gumowski]

Hello Tom,

Thank you for the feedback! It seems indeed that in the process we fixed another rule (S2160, see SONARJAVA-1513) that the one which was initially bothering you.

I consequently created the following ticket to fix S1210: SONARJAVA-1614

Regarding your PR, thank you for providing the code samples which should be compliant.

Feel free to expand your PR and provide a fix for the rule! Otherwise, we will handle your PR when handling the ticket.

Cheers,

Michael GUMOWSKI | SonarSource

Software Developer @ Language Team
http://sonarsource.com

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/bd2750d8-2a5f-4cee-b297-0b6195925436%40googlegroups.com.