[VOTE] Java plugin version 3.6

100 views
Skip to first unread message

Nicolas Peru

unread,
Oct 2, 2015, 10:45:14 AM10/2/15
to SonarQube
Hi to all, 

We would like to release a new version of the java plugin : version 3.6

This release provides the following features : 
  • 14 new rules : among them Dead Store detection rule.
  • JavaCheckVerifier for custom rule test : So custom rules are easier to test when you write them. ( see this pull request to understand how to use this : https://github.com/SonarSource/sonar-examples/pull/17 ) You would have to rebuild the project locally to get access to the test kit artifact from maven. 
  • Numerous bug fixes and improvements, especially in semantic.  

Issues solved: 

You can test this version using the following snapshot : 


Vote is open until next tuesday.

[ ] +1
[ ] +0
[ ] -1

Thanks to Massimo Paladin and Michael Gumowski for their work on that version !

As always, any feedback is more than welcome !
Nicolas PERU | SonarSource
Senior Developer
http://sonarsource.com

dfl...@objectif-informatique.fr

unread,
Oct 5, 2015, 6:35:47 AM10/5/15
to SonarQube
Hi,

+1

Tested with SonarQube 4.5.5
NPE when retrieving default value of identifier : OK
FP on S1948: no issue should be raised when using Map of Serializable objects : OK
Non-regression tests with 2 projects (+100 000 LoC) and activation of new rules with BLOCKER and CRITICAL severity : OK (no error).

Custom rules writing :
Allow JavaCheckVerifier to be used to test custom rules : OK

Regards,

Denis

Alix Lourme

unread,
Oct 5, 2015, 10:19:20 AM10/5/15
to SonarQube, dfl...@objectif-informatique.fr
+1

arjen.v...@gmail.com

unread,
Oct 5, 2015, 11:22:33 AM10/5/15
to SonarQube
Hi,

My plugin doesn't compile against 3.6, as a result of a change in the API :

- JavaFileScannerContext.getComplexity() does no longer return an int, but a list<tree>.

Of course, since this class is @Beta, the api can change. However it would have been nice if this change was done backwards compatible: like, adding getBranchPoints(tree):List<Tree>  and keeping getComplexity(tree):int.
Personally I don't find it very intuitively that getComplexity() returns a 'list of branchpoints'.

After introducing some reflection magic, my plugin now also works with (3.1 upto) 3.6  and all regression tests seem to pass. 

Regards,

Arjen

Michael Gumowski

unread,
Oct 5, 2015, 12:19:32 PM10/5/15
to arjen.v...@gmail.com, SonarQube
Hey Arjen!

Thank you for your precious feedback! Without you, we would have surely let that breaking change of API slip into the final version.
We are going to provide a new Release Candidate (RC2) tomorrow morning. This version will restore breaking changes.

Cheers,

Michael GUMOWSKI | SonarSource
Software Developer @ Language Team
http://sonarsource.com

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/95edb2de-71e8-4967-a81c-8fd9a341f3e3%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Michael Gumowski

unread,
Oct 6, 2015, 4:04:17 AM10/6/15
to arjen.v...@gmail.com, SonarQube
Hey all,

As announced, here is a new version for the vote. The breaking changes in the JavaFileScannerContext API have been fixed and is now backward compatible.

From now on, please test this version using the following snapshot : 

Cheers,

Michael GUMOWSKI | SonarSource
Software Developer @ Language Team
http://sonarsource.com

Nicolas Peru

unread,
Oct 6, 2015, 4:10:57 AM10/6/15
to Michael Gumowski, arjen.v...@gmail.com, SonarQube
As a consequence, vote is extended until the end of the day. 

Arjen, we are really looking forward from your feedback ! 

Cheers,

Nicolas PERU | SonarSource
Senior Developer
http://sonarsource.com


To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/CABGmqnmkLZzSMH_%2B-eSY0z3PQzbYotKzuU1QVmj5rbdqug-Thg%40mail.gmail.com.

arjen.v...@gmail.com

unread,
Oct 6, 2015, 6:36:23 AM10/6/15
to SonarQube, michael....@sonarsource.com, arjen.v...@gmail.com
Hi,

It all works now with the RC-2 version, thank you for implementing backwards compatibility.

Regards,

Arjen

Nicolas Peru

unread,
Oct 6, 2015, 10:17:35 AM10/6/15
to arjen.v...@gmail.com, SonarQube, Michael Gumowski
Hi All, 

Thanks Arjen for your feedback ! 

Vote is now closed and pass with three +1 from Arjen (I count your last feedback as a +1), Alix and  Denis. Kudos to you guys for testing and providing feedback, this is very precious to us. 

Release will happen shortly. 
Cheers,

Nicolas PERU | SonarSource
Senior Developer
http://sonarsource.com


To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/652006b4-3fbd-4d27-b131-f968bc50accc%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages