[VOTE] Code Smells plugin 3.0.0

[Michel Pawlak]

Hi SonarQube community,

I would like to release a new version of the Code Smells (formerly known as WTF) Plugin version 3.0.0 and I'm asking you for your feedback.

The scope of this release is the following:

• Migrate plugin to SonarQube 5.2 API
• Handle multiline @Smell annotations (contributed by Andrew K)
  

To test this release you need to :

• retrieve the snapshot version of the plugin: qualinsight-sonarqube-smell-plugin-3.0.0-RC1.jar             
  
• add the Java api dependency as follows:

<dependency>
    <groupId>com.qualinsight.plugins.sonarqube</groupId>
    <artifactId>qualinsight-plugins-sonarqube-smell-api</artifactId>
    <version>3.0.0-RC1</version>
</dependency>

Usage documentation is available on the plugin's GitHub page.

The vote is open for 72 hours. 

[ ] +1

[ ] -1

Thank you in advance for your feedback !

Michel

[G. Ann Campbell]

@Michel, 

I dug down to the version to find the release notes in hope of seeing what a "multiline smell annotation" looks like, but even in the the related ticket, I came up empty. Can you give an example somewhere of what this looks like?

Also, it occurs to me that you may want to include in your Smell rule description a link to the plugin docs. Either that, the information about the dependency. If I'm just Joe Developer & come across this rule in my SonarQube instance, I'm not going to know how to get started with it, even if it's on in my profile.

Ann 

[Michel Pawlak]

Hi Ann,

Here is an example: https://github.com/Miovision/qualinsight-plugins-sonarqube-smell/blob/0dac74f148855067160d5162b171c70159c4aa55/plugin/src/test/resources/SmellMeasurerTest_5.java

Concerning the URL in check description: good point, I'll add it.

Michel

[G. Ann Campbell]

Ah. So I guess you're doing the major version bump because of the compatibility change?

Anyway, this looks good to me.

---

G. Ann CAMPBELL | SonarSource

Product Owner

http://sonarsource.com

--
You received this message because you are subscribed to a topic in the Google Groups "SonarQube" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sonarqube/_pgIXuXbrOU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/363de607-b15c-4677-bde5-d5bb2452ed8f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[michel...@gmail.com]

As the plugin is not backward compatible (due to 5.2 api not being backward compatible with 5.1), I had to upgrade the major version. 

Michel

[G. Ann Campbell]

Of course. That makes perfect sense.

---

G. Ann CAMPBELL | SonarSource

Product Owner

http://sonarsource.com

[Michel Pawlak]

Hi,

Thanks to Ann for her feedback. I added the requested links and modified the documentation accordingly.

I consider Ann's vote as a +1 and will proceed to release soon.

Best regards,

Michel