Sonarqube doesn't create groups retrieved from LDAP Plugin

[omerfaru...@gmail.com]

Hi,

We are trying to add users to their groups in Active Directory using LDAP plugin. But there is a problem: user's groups are not created automatically when the user logins. If we create the group manually and the user logins again, the user is added to the group as expected.

We tried to inspect the Sonarqube source code and identified the problem. The groups are not attempted to be created in UserIdentityAuthenticatorImpl class:

private void syncGroups(DbSession dbSession, UserIdentity userIdentity, UserDto userDto) {
  if (!userIdentity.shouldSyncGroups()) {
    return;
  }
  String userLogin = userIdentity.getLogin();
  Set<String> userGroups = new HashSet<>(dbClient.groupMembershipDao().selectGroupsByLogins(dbSession, singletonList(userLogin)).get(userLogin));
  Set<String> identityGroups = userIdentity.getGroups();
  LOGGER.debug("List of groups returned by the identity provider '{}'", identityGroups);

  Collection<String> groupsToAdd = Sets.difference(identityGroups, userGroups);
  Collection<String> groupsToRemove = Sets.difference(userGroups, identityGroups);
  Collection<String> allGroups = new ArrayList<>(groupsToAdd);
  allGroups.addAll(groupsToRemove);
  DefaultOrganization defaultOrganization = defaultOrganizationProvider.get();
  Map<String, GroupDto> groupsByName = dbClient.groupDao().selectByNames(dbSession, defaultOrganization.getUuid(), allGroups)
    .stream()
    .collect(uniqueIndex(GroupDto::getName));

  addGroups(dbSession, userDto, groupsToAdd, groupsByName);
  removeGroups(dbSession, userDto, groupsToRemove, groupsByName);
}

private void addGroups(DbSession dbSession, UserDto userDto, Collection<String> groupsToAdd, Map<String, GroupDto> groupsByName) {
  groupsToAdd.stream().map(groupsByName::get).filter(Objects::nonNull).forEach(
    groupDto -> {
      LOGGER.debug("Adding group '{}' to user '{}'", groupDto.getName(), userDto.getLogin());
      dbClient.userGroupDao().insert(dbSession, new UserGroupDto().setGroupId(groupDto.getId()).setUserId(userDto.getId()));
    });
}

Here, in line 24, if the group does not exist, the group is not created in method. filter(Objects::nonNull) method eliminates null items in groupsByName
, so the user's group is never created programatically.

Thank you for your help.

[G. Ann Campbell]

Hi,

As described in the docs, the groups must first exist (be manually created) in SonarQube before membership can be synchronized from LDAP.

Ann