False positive for S2325 : "private" methods that don't access instance data should be "static"

[Dominique Jean-Prost]

Hello,

I guess I have a found a false positive for S2325 with the following code.

public class Sonar {

    private int foo;

    private void toto(final int b) {

        new File(".").listFiles(new FileFilter() {

            public boolean accept(final File pathname) {

                System.out.println(Sonar.this.foo);

                return false;

            }

        });

    }

}

I get this warning : "private" methods that don't access instance data should be "static" : Make "toto" a "static" method.

But I can't make the toto method static there. 

This problem looks like https://jira.sonarsource.com/browse/SONARJAVA-1155.

Thanks.

dom

[Michael Gumowski]

Hey Dom,

Thanks a lot for your feedback as well as for the pretty useful reproducer!

Indeed, this a FP and the case is not well handled in the rule! JIRA ticket created: https://jira.sonarsource.com/browse/SONARJAVA-1620

Cheers,

Michael GUMOWSKI | SonarSource

Software Developer @ Language Team
http://sonarsource.com

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/7fd05b73-ec2d-40dc-a70b-970a01f4cb47%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.