CSS 1.4 Plugin Released

25 views
Skip to first unread message

David Racodon

unread,
Aug 24, 2015, 4:43:28 PM8/24/15
to SonarQube
Hi,

The SonarQube CSS plugin version 1.4 has been released.

  • Rule description tweaks
  • NPE on rule bulletproof-font-face

@SonarSource: I'll let you update the Update Center. Thanks.

Enjoy!

David RACODON
Freelance QA Consultant

Dinesh Bolkensteyn

unread,
Aug 25, 2015, 3:18:16 AM8/25/15
to SonarQube
I don't want to be too rude, but you made this release while integrations tests were red - which is totally unacceptable:


You're lucky that this ended up being a minor problem with the integrations tests themselves - which does not affect the code that has been released.

Let's not let this happen again.

Thank you

David Racodon

unread,
Aug 25, 2015, 4:07:44 AM8/25/15
to Dinesh Bolkensteyn, SonarQube
Hi Dinesh,


I don't want to be too rude

I thought we should say "Hi" in this group.

 
but you made this release while integrations tests were red - which is totally unacceptable:

I fully agree with you. My bad for not having noticed it.
 

You're lucky that this ended up being a minor problem with the integrations tests themselves - which does not affect the code that has been released.

I was releasing changes made a couple weeks ago that were green at that time. As, no changes have been made to the source code since then, the issue was purely related to integration tests.
 

Let's not let this happen again.
 
Yes.

A few points to improve the situation:
  1. You were aware that the integration tests were red on the CSS plugin for a few days (you've got big screens all around at SonarSource) and that a vote was open. You could have issued a warning or at least vote -1 yesterday, instead of +1.
  2. The way those integration tests are configured and work are a bit cryptic for non-SonarSource contributors or at least for me. Could you please point to some documentation or source code for me to better understand how to configure them?
Thank you

Regards,


David RACODON
Freelance QA Consultant

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/8b8e3b20-1139-48ad-9852-002407c6f8b9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Dinesh Bolkensteyn

unread,
Aug 25, 2015, 4:13:31 AM8/25/15
to David Racodon, SonarQube
Hi David,

For now, there is no documentation on how these tests are to be executed - you'll have to reverse engineer the Travis scripts: We're only switched to Travis very recently and this is still work in progress.
However, if there is any failure you do not understand, feel free to ask for help.

About the big screens, sonar-css showed up just yesterday (and not during the vote), because we only check the master's state and there were no new pushes made to it between August 11 and 24 (excluded).

Anyway, no worries - nothing is broken in the end, and we'll do better next time ;-)

Thanks again
Reply all
Reply to author
Forward
0 new messages