Regarding RSPEC-3749 and the implementation of Rule S3749

[simon schrottner]

Hi!

Well i just checked out the new "Sonar-Java" update and i find the rule s3749 is somehow odd!

Yes in spring you should use @Autowired, but you could also use @Resource which is defined in JSR-250 -> so it would be great if we could extend the rule!

Both of them seem for me to be somehow valid and have their usecase!

Br

Simon

PS: here is a small stackoverflow which covers that issue! 

http://stackoverflow.com/questions/4093504/resource-vs-autowired

[G. Ann Campbell]

Hi Simon,

According to the answers on the SO link you posted, it looks like @Resource and @Injected should both be accepted in addition to @Autowired?

Thx,

Ann

[simon schrottner]

Well for our case at least @Resource should be also included! i have not seen and not use @injected so far! :D

Basically i just wanted to start the discussion, maybe your devs had a good reasoning for that, and that brings a new facet to the discussion, which i had with my team :D

Br

Simon

[simon schrottner]

So, what will be the next step? Should i create a change request or should i provide the suggested changes?, i mean this is - based on the implementation - a quick code change, which i will be able to handle i think :)

Just curious :)

[G. Ann Campbell]

Hi Simon,

I've updated the rule specification to include these two annotations & entered SONARJAVA-2219 to update the implementation as well. I'm sure that if you wanted to provide a PR to address that ticket it would be well received. 

:-)

Ann

---

G. Ann CAMPBELL | SonarSource

Product Manager

http://sonarsource.com

On Fri, Mar 31, 2017 at 9:37 AM, simon schrottner <simon.sc...@gmail.com> wrote:

So, what will be the next step? Should i create a change request or should i provide the suggested changes?, i mean this is - based on the implementation - a quick code change, which i will be able to handle i think :)

Just curious :)

--
You received this message because you are subscribed to a topic in the Google Groups "SonarQube" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sonarqube/T-f83S9mvQU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to sonarqube+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/acd42f40-a918-43ed-8def-ced06fcec0b6%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[simon schrottner]

well it is my first try... and i did everything except ITS, but is this the right approach? 

https://github.com/SonarSource/sonar-java/pull/1366

On Monday, 3 April 2017 15:26:43 UTC+2, G. Ann Campbell wrote:

Hi Simon,

I've updated the rule specification to include these two annotations & entered SONARJAVA-2219 to update the implementation as well. I'm sure that if you wanted to provide a PR to address that ticket it would be well received. 

:-)

Ann

---

G. Ann CAMPBELL | SonarSource

Product Manager

http://sonarsource.com

On Fri, Mar 31, 2017 at 9:37 AM, simon schrottner <simon.sc...@gmail.com> wrote:

So, what will be the next step? Should i create a change request or should i provide the suggested changes?, i mean this is - based on the implementation - a quick code change, which i will be able to handle i think :)

Just curious :)

--
You received this message because you are subscribed to a topic in the Google Groups "SonarQube" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sonarqube/T-f83S9mvQU/unsubscribe.

To unsubscribe from this group and all its topics, send an email to sonarqube+...@googlegroups.com.

[G. Ann Campbell]

Hi Simon,

Reviewing this is in the proper queue. But I have no idea how big the queue is.

:-)

Ann

[simon schrottner]

Hi Everybody!

It seems like we forgot an important Annotations "@Value" to inject configuration properties!

The question is, shoul i simply create another pull request with that change, or will there be an internal ticket on your side?

BR

Simon

[Nicolas Peru]

Hi, 

Ideally we would like both : create a ticket explaining the functional requirement and then you can create a PR based on this. 

So could you detail a bit what we missed exactly and why ? 

Thanks. 

You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/1820fd7f-c2cd-409f-afbc-90bf8749bf84%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Nicolas Peru | SonarSource

Senior Developer

http://twitter.com/benzonico

http://sonarsource.com

[simon schrottner]

Well i already created the pull request... which is explaining the issue:

https://github.com/SonarSource/sonar-java/pull/1442

please take a short look - i will create a ticket if you give me the go with the reasoning etc.

 :D 

Br simon

[simon schrottner]

please continue discussion regarding this issue in https://github.com/SonarSource/sonar-java/pull/1444

To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/1820fd7f-c2cd-409f-afbc-90bf8749bf84%40googlegroups.com.

[fesp...@tennaxia.com]

Hi!

The @Value has been added but what about other injection mode like constructor injection (which doesn't even require the @Autowired with recent spring version) ?

https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-spring-beans-and-dependency-injection.html

Thx,
Fabio

[vhai...@gmail.com]

Dne středa 21. června 2017 17:01:05 UTC+2 fesp...@tennaxia.com napsal(a):

Hi!

The @Value has been added but what about other injection mode like constructor injection (which doesn't even require the @Autowired with recent spring version) ?

https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-spring-beans-and-dependency-injection.html

:+1: I have complaints from devs about this exact situation as well. It would be nice to have this kind of injection detected correctly.

[Nicolas Peru]

Hi, 

Indeed, thanks for the suggestion and reference link : ticket created to handle this issue : https://jira.sonarsource.com/browse/SONARJAVA-2639

Cheers, 

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.

To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/75ec7fa8-ba0a-416c-96ed-1f4478955278%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Nicolas Peru | SonarSource

Senior Developer

https://twitter.com/benzonico

https://sonarsource.com

[marko....@gmail.com]

Hello Nicolas.

I see the issue is closed, but still I have problems when I have a multi-parameters constructor. 

In particular, this is a constructor generated using Project Lombok.

@ConstructorProperties({"sender", "beginPrescan", "listenerManager"})
@Autowired
@Generated
public BeginPrescanService(Sender sender, BeginPrescan beginPrescan, ListenerManager listenerManager) {

Best regards

Marko.