Possible new rule: nested ternary operations

[thomas....@gmail.com]

Hello everyone,

in my team I permit the usage of ternary operators. What I would like to prohibit is the usage of nested ternary operations.

e.g.

int x = y == null ? 0 : (z == null ? -1 : z);

Maybe the existing rule can even be extended in a way to define the depth that is allowed. Zero equals to prohibition at all.

Best regards,

Thomas

[Nicolas Peru]

Hi, 

If I understand you correctly you would like to add a parameter to this rule to track nesting level of ternary ?

https://jira.sonarsource.com/browse/RSPEC-1774

Cheers,

Nicolas PERU | SonarSource

Senior Developer
http://sonarsource.com

https://twitter.com/benzonico

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/3714b30e-a3ff-4236-a484-1a22ad88b192%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[David Racodon]

Hi Nicolas,

I'm also interested in such a rule.

But I would prefer to have two distinct rules instead of a parameter:

• The ternary operator should not be used
  
• Ternary operators should not be nested

I found it clearer this way.

Thank you

Regards,

David RACODON

Freelance QA Consultant

LinkedIn | Twitter

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/CAFHtbL1tY7mnT%3DjeTuwJW4EBVF8w_%3DF%3DVyt%3DPxbQ6uUVz4gV5w%40mail.gmail.com.

[thomas....@gmail.com]

Hi Nicolas,

I don't mind how to solve that. The extension is only one possible solution. I would also agree with Davids suggestion.

Best regards,

Thomas

[thomas....@gmail.com]

Hi Nicolas,

is there any update on this possible rule/extension?

[Nicolas Peru]

Hi Thomas, 

Ok, let's create a rule to avoid nesting of ternary operators. 

@Ann I stubbbed the RSPEC, can you please complete it : https://jira.sonarsource.com/browse/RSPEC-3358 ? 

Thanks.

Cheers,

Nicolas PERU | SonarSource

Senior Developer
http://sonarsource.com

https://twitter.com/benzonico

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/27419891-c55e-408a-9f8f-b86dee835267%40googlegroups.com.

[G. Ann Campbell]

Done @Nicolas

To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+unsubscribe@googlegroups.com.

[Thomas McWork]

Hi Ann and Nicolas,

I was just searching for this rule for Java and didn't find it. Your repository states there are only JavaScript and C implementations. Could you please also implements this for Java?

Thanks in advance.

Best regards,

Thomas

[Nicolas Peru]

Hi, 

That's odd : it is implemented in SonarJava : https://sonarqube.com/coding_rules#rule_key=squid%3AS1774 

Cheers, 

Done @Nicolas

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/27419891-c55e-408a-9f8f-b86dee835267%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/CAKfAaY%3D0Je1q3%3DVbPrLV0wnDsF4Ht3Sh1tadWB4khSiV24Z72g%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

[G. Ann Campbell]

That's a different rule @Nico. S1774 is 'don't use ternary ops at all', S3358 is 'don't put a ternary inside a ternary'.

Ann

---

G. Ann CAMPBELL | SonarSource

Product Manager

http://sonarsource.com

Done @Nicolas

To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/27419891-c55e-408a-9f8f-b86dee835267%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.

To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/CAKfAaY%3D0Je1q3%3DVbPrLV0wnDsF4Ht3Sh1tadWB4khSiV24Z72g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Nicolas Peru]

Oh indeed, my bad. 

so it is not implemented yet. 
I created a ticket to track it : https://jira.sonarsource.com/browse/SONARJAVA-2068 

Cheers, 

--