False Positive: csharpsquid:S1104

142 views
Skip to first unread message

Jody Lester

unread,
Apr 10, 2018, 10:56:21 AM4/10/18
to SonarQube
Hi there!

One of my developers has raised a question regarding a potential false positive for csharpsquid:S1104.

The code in question is for a WPF BindableProperty (S1104.png screenshot of code with issue attached).

When encapsulating the field (using a backing field or auto property) to mitigate the minor vulnerability then WPF fails to bind properly with the following error:

Severity

Code

Description

Project

File

Line

Suppression State

Error

 

Position 84:34. No property, bindable property, or event found for 'Checked', or mismatching type between value and property.

SynergyTrak.Mobile

C:\WS\STMobile\Dev\SynergyTrak.Mobile\SynergyTrak.Mobile\Pages\SettingsPage.xaml

84

 


Is this a false positive or a poor Microsoft implantation (of binding) that we can do nothing about?

Many thanks,
S1104.png

Amaury Leve

unread,
Apr 10, 2018, 11:07:03 AM4/10/18
to Jody Lester, SonarQube
Hi Jody,

This is indeed a False Positive on our side. I have created a ticket on our repository to track the issue (https://github.com/SonarSource/sonar-csharp/issues/1317).

Thanks for the feedback!

Cheers,
Amaury

Synergy Health plc
Company Reg. No. 3355631
VAT Reg. No. 706 1634 56

Registered Office: 
Ground Floor Stella, 
Windmill Hill Business Park 
Swindon, 
Wiltshire. 
SN5 6NX


*********************************************************************************
Internet communications are not secure and therefore Synergy Health Plc does not accept legal responsibility for the contents of this message.

We may monitor incoming and outgoing e-mail in accordance with legislation. We have taken steps to ensure that this email and  attachments are free from any malicious programs or viruses, but it remains your responsibility to  carry out virus and other security checks that you deem necessary to ensure that your systems or data are not affected by any potentially damaging contents.

Any views or opinions presented are solely those of the author and do not necessarily represent those of Synergy Health plc. If you are not the intended recipient be aware that any disclosure, copying, distribution or use of the contents of this information is prohibited. If you have received this electronic message in error, please notify us immediately by e-mail to postm...@synergyhealthplc.com and then delete the message.

*********************************************************************************

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/51281268-cba0-43dc-9467-c2313854d818%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--

Amaury Levé | SonarSource

Software Developer - .Net Team

http://sonarsource.com


Are you using SonarLint in your IDE? 

Jody Lester

unread,
Apr 10, 2018, 11:09:42 AM4/10/18
to SonarQube
Hi Amaury,

Thanks for getting back so quickly!  That's great, we'll keep an eye out for when the issue is resolved.

Many Thanks,
Reply all
Reply to author
Forward
0 new messages