False positive for "Iterate over the "entrySet" instead of the "keySet"."

[mikael petterson]

Hi,

We got the following in sonar:



What are we missing? Or is it a false positive in Sonar.

We use SonarQube Version 5.6.6.

br,

//mikael

[simon schrottner]

hi

i highly recommend to also post your SonarJava version, so it is possible to tell you, if you are maybe just using an outdated version of sonarJava :D

Br

Simon

[mikael petterson]

SonarJava 4.7.1.9272

br,

//mikael

[G. Ann Campbell]

Hi mikael, 

You are indeed using a rather dusty version of SonarJava. Please give it a try with the latest: 4.14.

Ann

[mikael petterson]

Can you confirm that this issue has been fixed in later versions. I am asking this since the process to get a new version of SonarJava requires a lot of coordination and weekend work.

br,

//mikael

[Nicolas Peru]

Hi, 

No work has been done on that rule since a long time : https://github.com/SonarSource/sonar-java/commits/cb1baeadb6f9beaab8a04a639a33b90944f73f19/java-checks/src/main/java/org/sonar/java/checks/KeySetInsteadOfEntrySetCheck.java I don't expect anything to be changed. 

 Could you provide a simple reproducer of the issue so we can investigate properly ? 

Cheers, 

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/ad05b95c-f88c-451d-ba03-cfc1b0c3dcd1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Nicolas Peru | SonarSource

Senior Developer

https://twitter.com/benzonico

https://sonarsource.com

[mikael petterson]

Hi,

We tried with the following example:


import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
import java.util.Map.Entry;

public class LoopMap {

    public static void main(String[] args) {

        // initial a Map
        Map<String, String> map = new HashMap<String, String>();
        map.put("1", "Jan");
        map.put("2", "Feb");
        map.put("3", "Mar");
        map.put("4", "Apr");
        map.put("5", "May");
        map.put("6", "Jun");

        // more elegant way, this should be the standard way, recommend!
        System.out.println("\nExample 2...");
        for (Map.Entry<String, String> entry : map.entrySet()) {
            System.out.println("Key : " + entry.getKey() + " Value : " + entry.getValue());
        }

    }

}

but could not get a sonar warning. So I guess it must be an issue with the environment.

br,

//mikael