[JAVA] Checkstyle - Missing Override - FP for JDK5

[Adam Gabryś]

Hi,

I know there is a problem with SQUID:1161 (“@Override” annotation should be used on any method) and JDK5: https://jira.sonarsource.com/browse/SONARJAVA-818

 

I will be nice, if you (after fix it) also dynamicaly set “javaFiveCompatibility” parameter to true (JDK5) or false (JDK6+).

 

http://checkstyle.sourceforge.net/config_annotation.html#MissingOverride

http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.html

 

Regards,

    Adam Gabryś

[Adam Gabryś]

I forgot. It would also be nice if you correct squid:UndocumentedApi (http://nemo.sonarqube.org/coding_rules#q=UndocumentedApi) rule for JDK5 (ignore if method is defined and documented in parent).

 

Regards,

    Adam Gabryś

--
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sonarqube+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/DUB124-DS26E59CF586B4D37B126BE98E80%40phx.gbl.
For more options, visit https://groups.google.com/d/optout.

[Nicolas Peru]

Hi Adam, 

You have two requests here : 

• Can we improve checkstyle plugin so we set parameters depending on the sonar.java.sources propery ? Short answer is no. We actually won't go for implementation of this from SonarSource. This is definitely not a priority on our side. However, feel free to contribute and propose a pull request for this feature. 
• Can we update UndocumentedApi rule to behave differently depending on java version ? Would you mind precising how you think the rule should behave ? 

Cheers, 

Nicolas PERU | SonarSource

Senior Developer
http://sonarsource.com

https://twitter.com/benzonico

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/DUB124-DS13F6FAA2143B7A5CB02EF398E80%40phx.gbl.

[Adam Gabryś]

Hi,

1) Ok. I understand and I will try ;-)

 

2) If we use JDK5, we can not make decisions based on @Override annotations. It will be nice, if the rule check only those methods which are not override (not available in parent class or implemented interfaces).

 

By the way I would like to point out that this rule also create issues for not documented public methods i private/package classes and interfaces (http://stackoverflow.com/questions/31463950/how-to-resolve-squidundocumentedapi-on-public-method-in-package-classes).

 

Regards,

    Adam Gabryś

To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/CAFHtbL3ud8_j-4%2BZxF6SM86QMorHqVH_5Hcpwk7f4fiU25ND3g%40mail.gmail.com.