domain distribution needs implements for Table data structure in c++, or cython?

2 views
Skip to first unread message

Taihsiang Ho

unread,
May 22, 2016, 8:29:18 PM5/22/16
to sol...@googlegroups.com
Hi, solverconers:

when digging into this issue (issue135),
I found one of the root cause is the lack of the implement to distribute the domains in parallel mode.

Since we are now moving to c++ instead of the cython code, e.g. the pull request #155,
it is a really good time for us to implement it in C++.

However implementing it in cython could fix this issue in a short time and make us have a prototype to make sure the method work.

I propose we implement BOTH because
1. we have to migrate to c++ anyway in accordance with the earlier discussion and conclusion (issue153). Yung-Yu is the best candidate to do that.
2. it is a good chance for me (Taihsiang) to get familiar with the Table structure by implementing the code relevant to it. I could implement the cython part.
3. the cython part could be a part of the unit test or function test for domain distribution in c++.

What do you think? Thanks.

Cheers,
Taihsiang


Yung-Yu Chen

unread,
May 22, 2016, 8:59:38 PM5/22/16
to sol...@googlegroups.com
We should fix / implement the domain decomposition issue in Cython and C++.  Since I am working on the porting from C/Cython to C++ I will address this bug (in C++) sooner or later.  I am still working on taking solvcon.block.Block and solvcon.boundcond.BC to C++.  After they are ported I can work on the domain decomposition issue.

And I agree it’s equally important to fix the existing Cython version so that we can cover it in tests.  It’s surprising that the domain decomposition causes problem because we already have unit tests for it.  But apparently we need to improve the coverage.  We should also revive our CI.  It’s time to get Travis-CI to work.

Yung-Yu

Cheers,
Taihsiang



--
You received this message because you are subscribed to the Google Groups "solvcon" group.
To unsubscribe from this group and stop receiving emails from it, send an email to solvcon+u...@googlegroups.com.
To post to this group, send email to sol...@googlegroups.com.
Visit this group at https://groups.google.com/group/solvcon.
To view this discussion on the web visit https://groups.google.com/d/msgid/solvcon/CAGpVV1jAqkUPbaOP8w4WMYO9Wj1LSuLDYVBOLuPMo8YyUZD7nw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
Yung-Yu Chen
http://yyc.solvcon.net/
+886 (99) 129 4763

Reply all
Reply to author
Forward
0 new messages