Hello,
I’ve just started working on a pull request to upgrade VuFind to use Solr 8.2:
https://github.com/vufind-org/vufind/pull/1477
However, when I try to run SolrMarc on this branch, it fails with:
Error Specified solrj class name, found, but it isnt a SolrServer or a SolrClient
Which appears to be coming from here:
https://github.com/solrmarc/solrmarc/blob/master/src/org/solrmarc/solr/SolrCoreLoader.java#L147
I’m guessing this means that the SolrJ interface has changed in yet another backward-incompatible way, and we need to come up with a new way to wrap the object.
Has anyone else encountered this?
I’m willing to put some time into investigating this more carefully, but I want to be sure I’m not repeating work that has already been done. Please let me know if you need me to put further effort into this!
thanks,
Demian
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339B49EAF8A155F1242CDB080680%40DM5PR13MB1339.namprd13.prod.outlook.com.
Tod,
I don’t think the browse handler is causing the SolrMarc error, since Solr itself starts up and responds as normal. However, you are correct that the browse handler does not compile with Solr 8. Here is my compiler output:
Buildfile: /opt/vufind-browse-handler/build.xml
clean:
[delete] Deleting directory /opt/vufind-browse-handler/build
setup:
[mkdir] Created dir: /opt/vufind-browse-handler/build
[mkdir] Created dir: /opt/vufind-browse-handler/build/deps
[mkdir] Created dir: /opt/vufind-browse-handler/build/bundled-deps
setup-solr-deps:
unpack-solr-war:
build-common:
[mkdir] Created dir: /opt/vufind-browse-handler/build/common
[javac] Compiling 8 source files to /opt/vufind-browse-handler/build/common
[javac] warning: [options] bootstrap class path not set in conjunction with -source 8
[javac] 1 warning
build-handler:
[mkdir] Created dir: /opt/vufind-browse-handler/build/browse-handler
[javac] Compiling 13 source files to /opt/vufind-browse-handler/build/browse-handler
[javac] warning: [options] bootstrap class path not set in conjunction with -source 8
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/AuthDB.java:63: error: bad operand types for binary operator '>'
[javac] if (results.totalHits > 0) {
[javac] ^
[javac] first type: TotalHits
[javac] second type: int
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/AuthDB.java:80: error: bad operand types for binary operator '<'
[javac] for (int i = 0; i < results.totalHits; i++) {
[javac] ^
[javac] first type: int
[javac] second type: TotalHits
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:96: error: <anonymous org.vufind.solr.handler.BibDB$1> is not abstract and does not override abstract method scoreMode() in Collector
[javac] db.search(q, new SimpleCollector() {
[javac] ^
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:186: error: <anonymous org.vufind.solr.handler.BibDB$2> is not abstract and does not override abstract method scoreMode() in Collector
[javac] db.search(q, new SimpleCollector() {
[javac] ^
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:279: error: <anonymous org.vufind.solr.handler.BibDB$3> is not abstract and does not override abstract method scoreMode() in Collector
[javac] db.search(q, new SimpleCollector() {
[javac] ^
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseItem.java:157: warning: [deprecation] Integer(int) in Integer has been deprecated
[javac] this.setCount(new Integer(count));
[javac] ^
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseRequestHandler.java:60: warning: [deprecation] toSolrParams(NamedList) in SolrParams has been deprecated
[javac] solrParams = SolrParams.toSolrParams(args);
[javac] ^
[javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseRequestHandler.java:94: warning: [deprecation] Integer(String) in Integer has been deprecated
[javac] return new Integer(s).intValue();
[javac] ^
[javac] 5 errors
[javac] 4 warnings
BUILD FAILED
/opt/vufind-browse-handler/build.xml:84: Compile failed; see the compiler error output for details.
This is off-topic for the SolrMarc list, so we should take further discussion of the browse handler to a different forum… but it is definitely another issue that will have to be resolved!
- Demian
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/95D27A6A-941E-4586-B8A8-2B7195E48F0C%40uchicago.edu.
Thanks, Bob – do you want me to take a stab at this?
- Demian
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339B49EAF8A155F1242CDB080680%40DM5PR13MB1339.namprd13.prod.outlook.com.
Great, I’ll see what I can come up with this afternoon. I’ll either open a pull request or report back here, depending on my degree of success. 😊
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339A8F22BB4B5062EB4486580680%40DM5PR13MB1339.namprd13.prod.outlook.com.
Good news: it appears to have been a simple fix!
https://github.com/solrmarc/solrmarc/pull/86
Assuming you have no concerns and are able to merge this, please let me know when the new release is out so I can get us upgraded on the VuFind side!
thanks,
Demian
From: solrma...@googlegroups.com <solrma...@googlegroups.com>
On Behalf Of Haschart, Robert J (rh9ec)
Sent: Tuesday, October 22, 2019 1:59 PM
To: solrma...@googlegroups.com
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339A8F22BB4B5062EB4486580680%40DM5PR13MB1339.namprd13.prod.outlook.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM6PR03MB4922E31A479A5039A048D5B5E8680%40DM6PR03MB4922.namprd03.prod.outlook.com.
Michael,
Unfortunately, I think you’re going to need a JDK, for two reasons:
Please let us know if we can be of further assistance! Information on errors and warnings is definitely useful, but the problems with the 3.3 release are already known and resolved, so I’d strongly recommend getting set up to compile from master before proceeding. I’m happy to answer any questions about that as well if you run into trouble!
- Demian
From: solrma...@googlegroups.com <solrma...@googlegroups.com>
On Behalf Of Michael Levy
Sent: Tuesday, December 3, 2019 9:04 AM
To: solrmarc-tech <solrma...@googlegroups.com>
Subject: [EXTERNAL] [solrmarc-tech] Re: SolrMarc and Solr 8.2
Hello all,
--
You received this message because you are subscribed to the Google Groups "solrmarc-tech" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
solrmarc-tec...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/ee7d658e-d204-4924-b068-9de3a942342b%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM6PR03MB4922583680C18E25BC1B7761E8420%40DM6PR03MB4922.namprd03.prod.outlook.com.
Excellent, glad to hear you got things working – let us know if you run into any problems along the way!
From: solrma...@googlegroups.com <solrma...@googlegroups.com>
On Behalf Of Levy, Michael
Sent: Tuesday, December 3, 2019 5:00 PM
To: solrma...@googlegroups.com
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/CAF9-XVKYSuVfhpeEmgx9iJWrTX3sesWKHuB29mZV9LNwBKODTw%40mail.gmail.com.