suggestion for code

0 views
Skip to first unread message

wxia...@gmail.com

unread,
Jun 1, 2009, 10:49:01 AM6/1/09
to Yuejie, soci...@googlegroups.com
Hi, Yuejie:

I looked at your code.Some suggestions, you could consider:

1. Naming: I suggest to change the class name of CampaignMessage to a single word: Message. It is simple, a message could be associate with a Campaign, but could also be standalone. It is possible to send a message without creating campaign first. it is simple this way.

2. I suggest to change the class name of ResponseBehaivor to Response. From you data model of response, I guess you want to record click stream of user, but I think this is not the purpose of Response object. Response is to record the response of particular message or offer, for example, a phone call, a click, a request to unsubscribe or un-follow...If you want to record click stream, I suggest we add another object called click stream...

Let me know what you think

wei
Reply all
Reply to author
Forward
0 new messages