patch for correct handling of wsdl:fault

[Peter Gardfjäll]

Attached to this mail is a text file containing the patch applied to the svn repository code in order to get soap4r to handle wsdl-defined faults correctly.

For more details, please refer to the following mailing list entry:

 

http://groups.google.com/group/soap4r/browse_thread/thread/9dc37ceec92ea769

 

I did not manage to add an attachement for the patch via ticket creation. Sorry for the inconvenience.

 

regards, Peter

[NAKAMURA, Hiroshi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Peter,

Sorry for late reply.

Peter Gardfjäll wrote:
> Attached to this mail is a text file containing the patch applied to the
> svn repository code in order to get soap4r to handle wsdl-defined faults
> correctly.
> For more details, please refer to the following mailing list entry:
>
> http://groups.google.com/group/soap4r/browse_thread/thread/9dc37ceec92ea769

Thank you for your patch. Of cource I'll apply the patch. Yes, it
should handle wsdl-defined fault by default.

* 1 request. Would you please show me a sample which uses wsdl-defined
fault? I'll add it as a test, too.

* 1 question. When I applied your patch, I get the following error
from an existing test 'test/wsdl/test_multiplefault.rb'.
test/wsdl/multiplefault.wsdl is the only WSDL in tests which has a fault
definition.

Do you think the WSDL is invalid? I don't want to corrupt current
working systems of users.

> Loaded suite test/wsdl/test_multiplefault
> Started
> E
> Finished in 0.022671 seconds.
>
> 1) Error:
> test_multiplefault(WSDL::TestMultipleFault):
> RuntimeError: Operation "myoperation": fault must specify a "name" attribute
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:129:in `collect_fault_messages'
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:126:in `each'
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:126:in `collect_fault_messages'
> /usr/local/lib/ruby/1.8/xsd/namedelements.rb:58:in `each'
> /usr/local/lib/ruby/1.8/xsd/namedelements.rb:57:in `each'
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:125:in `collect_fault_messages'
> /usr/local/lib/ruby/1.8/xsd/namedelements.rb:58:in `each'
> /usr/local/lib/ruby/1.8/xsd/namedelements.rb:57:in `each'
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:124:in `collect_fault_messages'
> /usr/local/lib/ruby/1.8/wsdl/soap/definitions.rb:82:in `collect_faulttypes'
> /usr/local/lib/ruby/1.8/wsdl/soap/classDefCreator.rb:35:in `initialize'
> test/wsdl/test_multiplefault.rb:16:in `new'
> test/wsdl/test_multiplefault.rb:16:in `test_multiplefault'
>
> 1 tests, 0 assertions, 0 failures, 1 errors

Regards,
// NaHi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)

iQEVAwUBRjicAh9L2jg5EEGlAQL9FQgAxRDswhWydy14DIIh25pmxaCpCylCwU3m
VNuB6YdoY+Or4uo+We3Z5j+hukMrHYrSLjQAVTCdIi1iG/1G+746qDNyAnUP9Wbo
fQafiX7lopiT0hX7ZXkQb7u1eCojWwOItjI2UNIZ/psn7zEfNjF7rdJc1sgul7vB
M6NI7A5cTM7LdVOomGDcmAfUl6BVtMV5WJ+Oc1j181UtJAZPBstYsFhrOF41d1Ta
s05ETk4FlgGnW5ZPiVOr8v4v9bh/w21pLtLGbIjEu/RgnUep+WbSawNAo4fEUYfp
ayAmV9P7A4U9+cG9NCP0sQjkQFwzn9de3bnY/xNoRM2sVZ8Bmd8KEQ==
=PVVN
-----END PGP SIGNATURE-----