[opensource-dev] Review Request: STORM-1807 Play animation floater 2nd play button active while animation is playing

[Jonathan Yap]

This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/552/

Review request for Viewer. By Jonathan Yap. Description Part 1 Open your inventory's Animations folder Double click on an animation Click on Play Inworld: Play Inworld is replaced by a Stop button Observed behavior: It is still possible to click on Play Locally, which also is replaced by a Stop button. Clicking on either Stop works and resets the floater back to having both Play buttons showing. Expected behavior: When one of the play buttons is clicked the other should be disabled. Part 2 1 .To reproduce, get any non looping animation. ie, one that plays once and then stops. 2. Right click in inventory and select play in world. 3. The animation dialog appears with play locally and play in world buttons. 4. When the animation is playing, the play in world button changes to a stop button, which makes it stop playing. Now here's the problem: 5. When the animation finishes of it's own accord, the button still says stop. To play it again, you have to click the redundant stop button to make it change back to Play in World, then click that to play again. Expected behaviour, is that when an animation finishes, the stop button should change back of it's own accord. Testing See test plan in jira. Bugs: STORM-1807 Diffs doc/contributions.txt (0a41a8750048) indra/newview/llinventorybridge.cpp (0a41a8750048) indra/newview/llpreviewanim.h (0a41a8750048) indra/newview/llpreviewanim.cpp (0a41a8750048) indra/newview/skins/default/xui/en/floater_preview_animation.xml (0a41a8750048) View Diff

[Jonathan Yap]

This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/552/

Review request for Viewer. By Jonathan Yap.

Updated Feb. 18, 2012, 5:24 a.m. Changes Fix possible compiling issue on Linux

Description Part 1 Open your inventory's Animations folder Double click on an animation Click on Play Inworld: Play Inworld is replaced by a Stop button Observed behavior: It is still possible to click on Play Locally, which also is replaced by a Stop button. Clicking on either Stop works and resets the floater back to having both Play buttons showing. Expected behavior: When one of the play buttons is clicked the other should be disabled. Part 2 1 .To reproduce, get any non looping animation. ie, one that plays once and then stops. 2. Right click in inventory and select play in world. 3. The animation dialog appears with play locally and play in world buttons. 4. When the animation is playing, the play in world button changes to a stop button, which makes it stop playing. Now here's the problem: 5. When the animation finishes of it's own accord, the button still says stop. To play it again, you have to click the redundant stop button to make it change back to Play in World, then click that to play again. Expected behaviour, is that when an animation finishes, the stop button should change back of it's own accord. Testing See test plan in jira. Bugs: STORM-1807

Diffs (updated)

[Oz Linden]

This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/552/

Ship it!

Ship It!

- Oz

On February 18th, 2012, 5:24 a.m., Jonathan Yap wrote:

Review request for Viewer. By Jonathan Yap. Updated Feb. 18, 2012, 5:24 a.m.

Description

Part 1 Open your inventory's Animations folder Double click on an animation Click on Play Inworld: Play Inworld is replaced by a Stop button Observed behavior: It is still possible to click on Play Locally, which also is replaced by a Stop button. Clicking on either Stop works and resets the floater back to having both Play buttons showing. Expected behavior: When one of the play buttons is clicked the other should be disabled. Part 2 1 .To reproduce, get any non looping animation. ie, one that plays once and then stops. 2. Right click in inventory and select play in world. 3. The animation dialog appears with play locally and play in world buttons. 4. When the animation is playing, the play in world button changes to a stop button, which makes it stop playing. Now here's the problem: 5. When the animation finishes of it's own accord, the button still says stop. To play it again, you have to click the redundant stop button to make it change back to Play in World, then click that to play again. Expected behaviour, is that when an animation finishes, the stop button should change back of it's own accord. Testing See test plan in jira. Bugs: STORM-1807 Diffs