[opensource-dev] Review Request: STORM-1808 Indicate ability to build

2 views
Skip to first unread message

Jonathan Yap

unread,
Feb 8, 2012, 6:31:02 PM2/8/12
to Viewer, Jonathan Yap
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/553/

Review request for Viewer.
By Jonathan Yap.

Description 

When standing in a parcel it would be helpful to have a graphical indication in the UI if you are able to build/rez.

The icon in the (mini) location bar shows parcel properties, not what is available to you as parcel owner or as a member of a group that has rezzing enabled as one of your group roles.

Suggested solution: Gray out the build button if it is present on the toolbar, just like the Speak button is grayed out if voice is not available.

Testing 

See test plan in jira.

I also searched the xml files to be sure no other calls to LLAgent::isActionAllowed were being made.
Bugs: STORM-1808

Diffs

  • doc/contributions.txt (0a41a8750048)
  • indra/newview/app_settings/commands.xml (0a41a8750048)
  • indra/newview/llagent.cpp (0a41a8750048)

View Diff

Jonathan Yap

unread,
Feb 19, 2012, 2:08:57 PM2/19/12
to Viewer, Jonathan Yap
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/553/

Review request for Viewer.
By Jonathan Yap.

Updated Feb. 19, 2012, 11:08 a.m.

Changes

Recoded so build button is not clickable when grayed out.

Description 

When standing in a parcel it would be helpful to have a graphical indication in the UI if you are able to build/rez.

The icon in the (mini) location bar shows parcel properties, not what is available to you as parcel owner or as a member of a group that has rezzing enabled as one of your group roles.

Suggested solution: Gray out the build button if it is present on the toolbar, just like the Speak button is grayed out if voice is not available.

Testing 

See test plan in jira.

I also searched the xml files to be sure no other calls to LLAgent::isActionAllowed were being made.
Bugs: STORM-1808

Diffs (updated)

    • doc/contributions.txt (0a41a8750048)
    • indra/newview/app_settings/commands.xml (0a41a8750048)
    • indra/newview/llagent.cpp (0a41a8750048)
    • indra/newview/lltoolmgr.h (0a41a8750048)
    • indra/newview/lltoolmgr.cpp (0a41a8750048)

    View Diff

    Jonathan Yap

    unread,
    Feb 19, 2012, 4:22:36 PM2/19/12
    to Viewer, Jonathan Yap
    This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/553/

    Review request for Viewer.
    By Jonathan Yap.

    Updated Feb. 19, 2012, 1:22 p.m.

    Changes

    Fix wrong name in XML file.

    Oz Linden

    unread,
    Feb 22, 2012, 9:51:32 AM2/22/12
    to Viewer, Oz Linden, Jonathan Yap
    This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/553/

    Ship it!

    Ship It!

    - Oz


    On February 19th, 2012, 1:22 p.m., Jonathan Yap wrote:

    Review request for Viewer.
    By Jonathan Yap.

    Updated Feb. 19, 2012, 1:22 p.m.

    Description 

    When standing in a parcel it would be helpful to have a graphical indication in the UI if you are able to build/rez.

The icon in the (mini) location bar shows parcel properties, not what is available to you as parcel owner or as a member of a group that has rezzing enabled as one of your group roles.

Suggested solution: Gray out the build button if it is present on the toolbar, just like the Speak button is grayed out if voice is not available.

    Testing 

    See test plan in jira.

I also searched the xml files to be sure no other calls to LLAgent::isActionAllowed were being made.
    Bugs: STORM-1808

    Diffs

    Reply all
    Reply to author
    Forward
    0 new messages