[opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

1 view
Skip to first unread message

Lance Corrimal

unread,
Jan 12, 2012, 3:23:50 AM1/12/12
to Lance Corrimal, Viewer
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/532/

Review request for Viewer.
By Lance Corrimal.

Description 

At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.

Testing 

tested with release viewer 3.2.5 and my own TPV, works fine.
Bugs: VWR-28087

Diffs

  • indra/newview/skins/default/xui/en/floater_image_preview.xml (4982ab91ef6a)

View Diff

Jonathan Yap

unread,
Jan 12, 2012, 4:31:09 AM1/12/12
to Viewer, Lance Corrimal, Jonathan Yap
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/532/

indra/newview/skins/default/xui/en/floater_image_preview.xml (Diff revision 1) 


  

 



 
 




 

  

    111
    
     bottom="225"

    111
    
     bottom="250"

  


 





Why are you changing this by 25 when in the other two locations you are only increasing by 20?









- Jonathan






On January 12th, 2012, 12:23 a.m., Lance Corrimal wrote:











Review request for Viewer.


By Lance Corrimal.




Updated Jan. 12, 2012, 12:23 a.m.
Lance Corrimal
unread,
Jan 12, 2012, 4:41:15 AM1/12/12
to Jonathan Yap, Lance Corrimal, Viewer

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      http://codereview.secondlife.com/r/532/
     
    

   

   











 
On January 12th, 2012, 1:31 a.m., Jonathan Yap wrote:

 

  





 
  

   
    indra/newview/skins/default/xui/en/floater_image_preview.xml
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 



 
 




 

  

    111
    
     bottom="225"

    111
    
     bottom="250"

  


 




  
Why are you changing this by 25 when in the other two locations you are only increasing by 20?

 









it looks better that way :)








- Lance
Lance Corrimal
unread,
Jan 12, 2012, 5:06:00 AM1/12/12
to Jonathan Yap, Lance Corrimal, Viewer

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      http://codereview.secondlife.com/r/532/
     
    

   

   







Review request for Viewer.


By Lance Corrimal.




Updated Jan. 12, 2012, 2:06 a.m.





Changes



 

  
   
on second thought the additional 5 pixels are not really necessary.

  		
 








Description 

 

 

  
   
At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.

  		
 






Testing 



 

  
   
tested with release viewer 3.2.5 and my own TPV, works fine.

  		
 








 Bugs: 


 VWR-28087







Diffs (updated)


    

 
  • indra/newview/skins/default/xui/en/floater_image_preview.xml (4982ab91ef6a)
    • 





View Diff





  		
 







  

 




Lance Corrimal
unread,
Feb 18, 2012, 3:28:55 AM2/18/12
to Lance Corrimal, Viewer

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      http://codereview.secondlife.com/r/532/
     
    

   

   






 
i guess when a CR doesn't get approved right away it falls into oblivion?

 









- Lance






On January 12th, 2012, 2:06 a.m., Lance Corrimal wrote:











Review request for Viewer.


By Lance Corrimal.




Updated Jan. 12, 2012, 2:06 a.m.








Description 

 

 

  
   
At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.

  		
 






Testing 



 

  
   
tested with release viewer 3.2.5 and my own TPV, works fine.

  		
 








 Bugs: 


 VWR-28087







Diffs 


    

 
  • indra/newview/skins/default/xui/en/floater_image_preview.xml (4982ab91ef6a)
    • 





View Diff





  		
 











  

 




Oz Linden
unread,
Feb 28, 2012, 12:10:09 PM2/28/12
to Lance Corrimal, Oz Linden, Viewer

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      http://codereview.secondlife.com/r/532/
     
    

   

   




 
Ship it!




 
Ship It!

 









- Oz






On January 12th, 2012, 2:06 a.m., Lance Corrimal wrote:











Review request for Viewer.


By Lance Corrimal.




Updated Jan. 12, 2012, 2:06 a.m.








Description 

 

 

  
   
At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.

  		
 






Testing 



 

  
   
tested with release viewer 3.2.5 and my own TPV, works fine.

  		
 








 Bugs: 


 VWR-28087







Diffs 


    

 
  • indra/newview/skins/default/xui/en/floater_image_preview.xml (4982ab91ef6a)
    • 





View Diff





  		
 











  

 




Oz Linden
unread,
Mar 23, 2012, 9:26:18 AM3/23/12
to Lance Corrimal, Oz Linden, Viewer

   

    

     
      This is an automatically generated e-mail. To reply, visit:
      http://codereview.secondlife.com/r/532/
     
    

   

   




 
Ship it!




 
Ship It!

 









- Oz






On January 12th, 2012, 2:06 a.m., Lance Corrimal wrote:











Review request for Viewer.


By Lance Corrimal.




Updated Jan. 12, 2012, 2:06 a.m.








Description 

 

 

  
   
At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.

  		
 






Testing 



 

  
   
tested with release viewer 3.2.5 and my own TPV, works fine.

  		
 








 Bugs: 


 VWR-28087







Diffs 


    

 
  • indra/newview/skins/default/xui/en/floater_image_preview.xml (4982ab91ef6a)
    • 





View Diff





  		
 











  

 




Reply all
Reply to author
Forward
0 new messages