Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater
Lance Corrimal
| This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/ |
Ship it!
Testing done: this tool has been in dolphin viewer for over a year now, to great benefit of the users, and has shown no problems.
- Lance
On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
|
Review request for Viewer.
By Tobias Roth.
Updated March 2, 2012, 12:30 a.m. Description
Diffs
|
Liny Odell
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Nicky Perian
| This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/ |
Do qtoolsalign.cpp aand qtoolsalign.h need to added to /indra/newview/CMakeLists.txt?
- Nicky
Lance Corrimal
bye,
LC
Am Freitag, 2. März 2012, 10:36:25 schrieb Liny Odell:
> Please see https://jira.secondlife.com/browse/STORM-468
>
> On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal
<Lance.C...@eregion.de>wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > http://codereview.secondlife.com/r/543/
> >
> > Ship it!
> >
> > Testing done: this tool has been in dolphin viewer for over a year now, to
> > great benefit of the users, and has shown no problems.
> >
> >
> > - Lance
> >
> > On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
> > Review request for Viewer.
> >
> > By Tobias Roth.
> >
> > *Updated March 2, 2012, 12:30 a.m.*
> > Description
> >
> > Qarls Aligning tool ported over from Nirans Viewer for code review
> >
> > Diffs
> >
> > - indra/newview/llfloatertools.cpp (b91d07f8fad9)
> > - indra/newview/qtoolalign.h (PRE-CREATION)
> > - indra/newview/qtoolalign.cpp (PRE-CREATION)
> > - indra/newview/skins/default/xui/de/floater_tools.xml (b91d07f8fad9)
> > - indra/newview/skins/default/xui/en/floater_tools.xml (b91d07f8fad9)
> >
> > View Diff <http://codereview.secondlife.com/r/543/diff/>
Tankmaster Finesmith
| This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/ |
I would suggest using "size *= 1.25;" instead of "size *= 2.0;" to better conform with existing hover over edit arrows behavior (normal edit arrows). This is what we use in Firestorm currently. This is in qtoolalign.cpp line 330
- Tankmaster
On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
|
Review request for Viewer.
By Tobias Roth.
|
Updated March 2, 2012, 12:30 a.m. Description |
Diffs |
Nicky Perian
| This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/ |
qtoolalign not qtools
- Nicky
Liny Odell
it may be useful for others to have a link in both directions (into
and out of the code review)
On Fri, Mar 2, 2012 at 10:48 AM, Lance Corrimal