Advice on ticket: feature request: Allow changing link cost from CLI #90

[Karen Schoener]

Hi,

My engineering manager has asked that I start working on the Skupper open source project - with the goal of contributing to the Skupper code base.

Here's some info on my background: I'm a software engineer with experience in IP routing.  I'm familiar with languages: golang, C++, python.

I've pulled the skupper and skupper-router repos.  I verified that I can build and run tests locally.

I've reviewed the skupper issues, looking for a candidate first work item.

I've been reviewing the skupper code with this issue in mind:

• feature request: Allow changing link cost from CLI #905
  https://github.com/skupperproject/skupper/issues/905

To address this issue, I believe the following is needed:

• Create CLI command: skupper link update
• CLI 'skupper link update' would update/annotate the correct secret with the desired new cost.
• Update service-controller to detect this change in cost.
• Write an ampq API to send a 'connector modify' request to the router.
• Verify this works in docker and in podman

At this point, I thought it would be wise to check in with the Skupper community - to see if I am on the right track so far.

Thanks in advance for any feedback or suggestions...

Thanks very much, Karen

[Ted Ross]

Hi Karen,

I tried to reply to your email yesterday but I can find no evidence that it was sent out.

Welcome to the Skupper developer community.  We're pleased to have you contribute to the project.

Issue #905 is probably not the best starter issue to work on.  We are starting on the version 2 updates and that particular area is undergoing some architectural changes in order to address issues like that raised in #905.  One of the complicating factors is that the router doesn't support a "connector modify" operation.  To change the cost of an inter-router connection, the connector needs to be deleted and re-created.

Are you looking for a good place to jump into the code or do you have a specific interest in the cost-change feature?

Regards,

-Ted Ross

--
You received this message because you are subscribed to the Google Groups "Skupper" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skupper+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/skupper/DM6PR15MB22686D7FE33C908A21773B92850E2%40DM6PR15MB2268.namprd15.prod.outlook.com.

[Karen Schoener]

Hi Ted, 

Thanks for your response!

I (mistakenly) assumed that cost could be modified in the router.

Investigating this issue has been a good learning experience.  I've traced through the code that generates claim tokens, the code that redeems the claims, and I gained an understanding of how links are created.

At an appropriate time, I'd be interested in working on a cost-change feature.

But for the moment, I was looking for a good place to jump into the code.

I notice that a few skupper tickets were marked as good-first-issues, recently.
https://github.com/skupperproject/skupper/labels/good%20first%20issue

I do not appear to have permissions to assign a ticket to myself.  
I assume that a skupper engineer would need to grant me permission to change a ticket's assignee field?

But I can plan to start working on this ticket, so I get more familiar with the skupper code base.

unsecured podman site with console reports credentials #1389

https://github.com/skupperproject/skupper/issues/1389

Thanks again, Karen

---

From: Ted Ross <therma...@gmail.com>
Sent: Friday, April 19, 2024 3:31 PM
To: Karen Schoener <Karen.S...@ibm.com>
Cc: sku...@googlegroups.com <sku...@googlegroups.com>
Subject: [EXTERNAL] Re: Advice on ticket: feature request: Allow changing link cost from CLI #90

 

This Message Is From an Untrusted Sender

You have not previously corresponded with this sender.

Report Suspicious