Revert "Make GrDrawTarget.h and GrPathRenderer.h be private headers" (issue 4896048)

0 views
Skip to first unread message

van...@chromium.org

unread,
Aug 16, 2011, 7:20:45 PM8/16/11
to bsal...@google.com, skia-...@googlegroups.com, re...@codereview.appspotmail.com
Reviewers: bsalomon,

Description:
Revert "Make GrDrawTarget.h and GrPathRenderer.h be private headers"

This reverts commit r2125

Looks like GrPathRenderer.h is used from
gpu/include/GrTesselatedPathRenderer.h

There also seems to be a dependency tracking problem, because r2125
didn't go red, but the next revision did.

Committed: http://code.google.com/p/skia/source/detail?r=2127

Please review this at http://codereview.appspot.com/4896048/

Affected files:
M gpu/include/GrContext.h
A + gpu/include/GrDrawTarget.h
A + gpu/include/GrPathRenderer.h
M gpu/src/GrContext.cpp
D gpu/src/GrDrawTarget.h
M gpu/src/GrGpu.cpp
D gpu/src/GrPathRenderer.h
M gyp/gpu.gyp
M samplecode/SampleApp.cpp


Brian Salomon

unread,
Aug 17, 2011, 9:35:11 AM8/17/11
to van...@chromium.org, bsal...@google.com, skia-...@googlegroups.com, re...@codereview.appspotmail.com
Yikes! It built fine locally for me. I suppose gyp-gen'ed projects lose track of dependencies when a file is removed from the gyp. I'll be sure to do a clean build before submitting changes that move files around in the future.

Brian
Reply all
Reply to author
Forward
0 new messages