Re: Add setup scripts for a Graphite server. (issue 310253003)

1 view
Skip to first unread message

tfa...@chromium.org

unread,
Sep 23, 2014, 12:02:46 AM9/23/14
to jcgre...@google.com, rmi...@google.com, skia-...@googlegroups.com

https://codereview.chromium.org/310253003/diff/180001/compute_engine_scripts/monitoring/graphite_setup.sh
File compute_engine_scripts/monitoring/graphite_setup.sh (right):

https://codereview.chromium.org/310253003/diff/180001/compute_engine_scripts/monitoring/graphite_setup.sh#newcode23
compute_engine_scripts/monitoring/graphite_setup.sh:23: sudo mkdir
/home/www-data
could this be simplified to the following command line?

sudo adduser www-data

https://codereview.chromium.org/310253003/

jcgre...@google.com

unread,
Sep 23, 2014, 7:24:08 AM9/23/14
to rmi...@google.com, skia-...@googlegroups.com, tfa...@chromium.org
Reviewers: rmistry,


https://codereview.chromium.org/310253003/diff/180001/compute_engine_scripts/monitoring/graphite_setup.sh
File compute_engine_scripts/monitoring/graphite_setup.sh (right):

https://codereview.chromium.org/310253003/diff/180001/compute_engine_scripts/monitoring/graphite_setup.sh#newcode23
compute_engine_scripts/monitoring/graphite_setup.sh:23: sudo mkdir
/home/www-data
If I recall correctly this didn't work because the www-data user already
exists because Apache created it.

We will shortly be switching to InfluxDB so much of this will be going
away.

On 2014/09/23 04:02:45, tfarina wrote:
> could this be simplified to the following command line?

> sudo adduser www-data

Description:
Add setup scripts for a Graphite server.

BUG=skia:

Committed:
https://skia.googlesource.com/buildbot/+/bdfa827ef0bcb15f2d11333072b29274190eb377

Please review this at https://codereview.chromium.org/310253003/

SVN Base: https://skia.googlesource.com/buildbot.git@master

Affected files (+825, -1 lines):
M compute_engine_scripts/buildbots/README
M compute_engine_scripts/buildbots/vm_config.sh
A compute_engine_scripts/monitoring/README.md
A compute_engine_scripts/monitoring/carbon.conf
A compute_engine_scripts/monitoring/continue_install.sh
A compute_engine_scripts/monitoring/continue_install2.sh
A compute_engine_scripts/monitoring/graphite.wsgi
A compute_engine_scripts/monitoring/graphite_setup.sh
A compute_engine_scripts/monitoring/httpd.conf
A compute_engine_scripts/monitoring/local_settings.py
A compute_engine_scripts/monitoring/monitoring_monit
A compute_engine_scripts/monitoring/storage-schemas.conf
A compute_engine_scripts/monitoring/vm_create_instance.sh
A compute_engine_scripts/monitoring/vm_delete_instance.sh
A compute_engine_scripts/monitoring/vm_push_update.sh
A compute_engine_scripts/monitoring/vm_setup_instance.sh


Reply all
Reply to author
Forward
0 new messages