Re: create simple skia app for android using jni (issue 16336004)
36 views
Skip to first unread message
djso...@google.com
unread,
Jun 3, 2013, 2:24:45 PM6/3/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to za...@google.com, skia-...@googlegroups.com
move this code into platform_tools/android/ndk_demo_app. Also don't
include the
libskia_android.so in the CL, but rather put a README file with
instructions on
how to build this using just the NDK tools.
https://codereview.chromium.org/16336004/diff/9001/experimental/HelloSkia/jni/Android.mk#newcode3 experimental/HelloSkia/jni/Android.mk:3: # set this to wherever your
skia directory is located, with out trailing slashes
I think that for clarity we should have them copy the headers into
jni/skia/include. That way if they update their skia tree it is clear
that they would also need to update these files.
Additionally, have them put the shared library in jni/skia/ as well.
Now this file won't be dependent upon any variables being set, just that
they did the work ahead of time to put content into the correct
directories.