Refactoring to begin encapsulating SW path rendering in GrPathRenderer (issue 6125046)

1 view
Skip to first unread message

robertp...@google.com

unread,
Apr 25, 2012, 8:05:42 PM4/25/12
to bsal...@google.com, skia-...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: bsalomon,

Description:
First pass at moving the software path rendering into a
GrPathRenderer-derived class.

I currently left the software rendering path in GrContext.cpp but will
pull it into the GrSoftwarePathRenderer shell in a follow on delivery.

Please review this at http://codereview.appspot.com/6125046/

Affected files:
M gyp/gpu.gyp
M src/gpu/GrAddPathRenderers_default.cpp
M src/gpu/GrContext.cpp
A src/gpu/GrSoftwarePathRenderer.cpp
A src/gpu/GrSoftwarePathRenderer.h


bsal...@google.com

unread,
Apr 26, 2012, 9:32:26 AM4/26/12
to robertp...@google.com, skia-...@googlegroups.com, re...@codereview-hr.appspotmail.com
On 2012/04/26 00:05:42, robertphillips wrote:

LGTM

http://codereview.appspot.com/6125046/

robertp...@google.com

unread,
Apr 27, 2012, 8:10:13 AM4/27/12
to bsal...@google.com, skia-...@googlegroups.com, re...@codereview-hr.appspotmail.com
Committed first portion as r3769

Holding off on gpu.gyp & GrAddPathRenderers_default.cpp until can do the
DEPS roll

http://codereview.appspot.com/6125046/

robertp...@google.com

unread,
May 1, 2012, 8:21:12 AM5/1/12
to bsal...@google.com, skia-...@googlegroups.com, re...@codereview-hr.appspotmail.com
Committed second half as r3804

http://codereview.appspot.com/6125046/
Reply all
Reply to author
Forward
0 new messages