Re: Initial code for webtry, a web application for allowing users to try out Skia. (issue 228693002)

1 view
Skip to first unread message

tfa...@chromium.org

unread,
Sep 19, 2014, 11:55:20 PM9/19/14
to jcgre...@google.com, mtk...@google.com, skia-...@googlegroups.com, rev...@skia.org

https://codereview.chromium.org/228693002/diff/100001/experimental/webtry/DESIGN
File experimental/webtry/DESIGN (right):

https://codereview.chromium.org/228693002/diff/100001/experimental/webtry/DESIGN#newcode93
experimental/webtry/DESIGN:93: By sysv init only handles starting and
stopping a program once, so we use
s/By/But ?

https://codereview.chromium.org/228693002/

tfa...@chromium.org

unread,
Sep 25, 2014, 12:14:50 PM9/25/14
to jcgre...@google.com, mtk...@google.com, skia-...@googlegroups.com, rev...@skia.org, hum...@google.com

https://codereview.chromium.org/228693002/diff/100001/experimental/webtry/setup/webtry_setup.sh
File experimental/webtry/setup/webtry_setup.sh (right):

https://codereview.chromium.org/228693002/diff/100001/experimental/webtry/setup/webtry_setup.sh#newcode32
experimental/webtry/setup/webtry_setup.sh:32: sudo monit -t
should we reload monit here as well to get the new changes?

sudo monit reload

https://codereview.chromium.org/228693002/

jcgre...@google.com

unread,
Sep 25, 2014, 1:05:59 PM9/25/14
to mtk...@google.com, skia-...@googlegroups.com, rev...@skia.org, tfa...@chromium.org, hum...@google.com
Reviewers: mtklein,
Yes, that would be great.

On 2014/09/25 16:14:50, tfarina wrote:
> should we reload monit here as well to get the new changes?

> sudo monit reload

Description:
Initial code for webtry, a web application for allowing users to try out
Skia.

Currently running at http://108.170.220.126:8000/

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14114

Please review this at https://codereview.chromium.org/228693002/

SVN Base: https://skia.googlesource.com/skia.git@master

Affected files (+891, -213 lines):
A experimental/webtry/DESIGN
M experimental/webtry/README
A experimental/webtry/TODO
D experimental/webtry/index.html
A experimental/webtry/main.cpp
A experimental/webtry/result.cpp
A experimental/webtry/seccomp_bpf.h
D experimental/webtry/server.py
A experimental/webtry/setup/continue_install
A experimental/webtry/setup/webtry_setup.sh
A experimental/webtry/sys/webtry_init
A experimental/webtry/sys/webtry_monit
A experimental/webtry/sys/webtry_schroot
D experimental/webtry/template.cpp
A + experimental/webtry/templates/index.html
A experimental/webtry/templates/template.cpp
A experimental/webtry/webtry.go
M gyp/webtry.gyp


Reply all
Reply to author
Forward
0 new messages