Re: SkScaledBitmapSampler: fix memory overwritten (issue 1085253002 by zoran.jovanovic@sonymobile.com)

[Leon Scroggins]

Thanks! I have uploaded the image with https://codereview.chromium.org/1091053002/.

On Tue, Apr 21, 2015 at 10:33 AM, Zoran Jovanovic <zoran.j...@sonymobile.com> wrote:

Hi.

Please find a test image attached.

Best regards

--
Zoran Jovanovic
Global System Management Architecture

Sony Mobile Communications
Sweden

Phone: +46 (0)10 8017349
Mobile: +46 (0)70 6997349
E-mail: zoran.j...@sonymobile.com

The information in this e-mail, and attachment(s) thereto, is strictly confidential and may be legally privileged. It is intended solely for the named recipient(s), and access to this e-mail, or any attachment(s) thereto, by anyone else is unauthorized. Violations hereof may result in legal actions. Any attachment(s) to this e-mail has been checked for viruses, but please rely on your own virus-checker and procedures. If you contact us by e-mail, we will store your name and address to facilitate communications in the matter concerned. If you do not consent to us storing your name and address for above stated purpose, please notify the sender promptly. Also, if you are not the intended recipient please inform the sender by replying to this transmission, and delete the e-mail, its attachment(s), and any copies of it, without disclosing it.

On 04/17/2015 11:09 AM, Zoran Jovanovic wrote:

Thanks.

I'm checking if we  have someone who can create a test gif with the same properties. Will let you know if I find anything.

Cheers

--
Zoran Jovanovic
Global System Management Architecture

Sony Mobile Communications
Sweden

Phone: +46 (0)10 8017349
Mobile: +46 (0)70 6997349
E-mail: zoran.j...@sonymobile.com

The information in this e-mail, and attachment(s) thereto, is strictly confidential and may be legally privileged. It is intended solely for the named recipient(s), and access to this e-mail, or any attachment(s) thereto, by anyone else is unauthorized. Violations hereof may result in legal actions. Any attachment(s) to this e-mail has been checked for viruses, but please rely on your own virus-checker and procedures. If you contact us by e-mail, we will store your name and address to facilitate communications in the matter concerned. If you do not consent to us storing your name and address for above stated purpose, please notify the sender promptly. Also, if you are not the intended recipient please inform the sender by replying to this transmission, and delete the e-mail, its attachment(s), and any copies of it, without disclosing it.

On 04/16/2015 07:45 PM, scr...@google.com wrote:

On 2015/04/15 12:13:30, Zoran Jovanovic wrote:

On 2015/04/15 12:02:01, scroggo wrote:

On 2015/04/15 10:46:29, Zoran Jovanovic wrote:

The code looks good. Do you have a sample image/samplesize that can be  

used

to

test?

Sending in separate email (can you add attachments in Rietveld?).

I am not aware of the ability to add attachments in Rietveld. I've received  
the
image and confirmed that we crash without this fix, and pass with it.

I would like to add a test, but we need to have an image whose copyright (or
lack thereof) allows us to check it into resources. Since I do not want  
that to
hold this up, I'll approve this now.

LGTM.

I've written a test at https://codereview.chromium.org/1091053002, which we  
can
check in once we have an image to test with. (I was going to file a bug,  
but our
bug db is read-only for maintenance.)

https://codereview.chromium.org/1085253002/

--

Leon Scroggins III
scr...@google.com