Poor error reporting

[Alexandre Bique]

Hi,

I think that skia could do a better job at error reporting.

Our code is using skgpu::VulkanPrefferedFeatures and I believe we initialize vulkan correctly.

GrDirectContexts::MakeVulkan() was working fine with Skia 143 and Skia 144. Though after jumping to skia 146, it is now failing (return null) with no error message, absolutely nothing to understand what's going on, and no code change on our side.

I'm not aware of another path than rebuilding all skia in debug mode and step through to figure out what's going on. Maybe you have a global error reporting mechanism somewhere?

Please could you consider improving the error reporting for this kind of problems?

Thank you very much,

Alex

[Alexandre Bique]

So the problem is related to SK_USE_VMA not being defined, and VulkanBackendContext.fMemoryAllocator having a misleading comment saying that it is optional while it is not.

Regards,

Alex

[kjlu...@google.com]

I will update that comment. We are in the process of prototyping better error reporting across Skia.