DNG SDK new warnings with GCC 7.1+

17 views
Skip to first unread message

mattl...@live.com

unread,
Jul 3, 2020, 4:58:19 PM7/3/20
to skia-discuss
Just an FYI, there are new warnings when using the new GCC toolchains. Or at least when cross-compiling from x64 to armv7a:

[431/1112] compile ../../../third_party/externals/dng_sdk/source/dng_spline.cpp
In file included from /opt/arm-none-linux-gnueabihf/arm-none-linux-gnueabihf/include/c++/9.2.1/vector:72,
from ../../../third_party/externals/dng_sdk/source/dng_memory.h:30,
from ../../../third_party/externals/dng_sdk/source/dng_spline.h:22,
from ../../../third_party/externals/dng_sdk/source/dng_spline.cpp:16:
/opt/arm-none-linux-gnueabihf/arm-none-linux-gnueabihf/include/c++/9.2.1/bits/vector.tcc: In member function 'void std::vector<_Tp, _Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Ar
gs&& ...) [with _Args = {const double&}; _Tp = double; _Alloc = dng_std_allocator<double>]':
/opt/arm-none-linux-gnueabihf/arm-none-linux-gnueabihf/include/c++/9.2.1/bits/vector.tcc:426:7: note: parameter passing for argument of type 'std::vector<double, dng_std_allocator<double> >::iterato
r' {aka '__gnu_cxx::__normal_iterator<double*, std::vector<double, dng_std_allocator<double> > >'} changed in GCC 7.1
426 | vector<_Tp, _Alloc>::
| ^~~~~~~~~~~~~~~~~~~
I  

mattl...@live.com

unread,
Jul 3, 2020, 5:00:13 PM7/3/20
to skia-discuss
Building the commit c8d0c9b1d16bfda56f15165d39e0ffa360a11123

Mike Klein

unread,
Jul 3, 2020, 6:14:59 PM7/3/20
to skia-discuss
Thanks, this is not important.

--
You received this message because you are subscribed to the Google Groups "skia-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skia-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/skia-discuss/53c57c7b-b9b7-4cc1-a1ba-17d3b646eda7n%40googlegroups.com.

mattl...@live.com

unread,
Jul 3, 2020, 6:17:44 PM7/3/20
to skia-discuss
Yeah. I added a "extra_cflags+=[ '-Wno-psabi' ]" to my build and everyone was happy :)

I also noticed a SkJSON in the list
Reply all
Reply to author
Forward
0 new messages