CanvasKit compilation error since chrome/m139

[sudo]

I tried to upgrade from m135 to m142, but got a compilation error. Went to check earlier branches to see when it last worked and found that to be m138.

OS: win10

In skia/modules/canvaskit and running compile.sh no_font no_skottie

wasm-ld: error: obj/modules/canvaskit/canvaskit.canvaskit_bindings.o: undefined symbol: Simplify(SkPath const&, SkPath*)

wasm-ld: error: obj/modules/canvaskit/canvaskit.canvaskit_bindings.o: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*)

wasm-ld: error: obj/modules/canvaskit/canvaskit.canvaskit_bindings.o: undefined symbol: Op(SkPath const&, SkPath const&, SkPathOp, SkPath*)

wasm-ld: error: obj/modules/canvaskit/canvaskit.canvaskit_bindings.o: undefined symbol: AsWinding(SkPath const&, SkPath*)

[William Candillon]

Sounds interesting, it looks like a regression since libpathops has been moved to core.

I can confirm the issue mon side as well, it's interesting in the config, everything looks ok. 

@Skia Team: This is tested part of CI right?

I only took a brief look but I might try to take a deeper look.

Kind regards,

William

[sudo]

Thanks for your reply. This is the specific commit after which I can no longer build https://github.com/google/skia/commit/0132370defcf0351a20c79892710fc55dc52a11d

[kjlu...@google.com]

We are working on updating the Path API. See https://skia-review.googlesource.com/c/skia/+/1075478 for the change that we will be relanding soon.

[William Candillon]

I really like this new API. Very sensible. Path mutability was an
issue for us since we need to let GC know how big the C++ path is but
we don't want to overdo it.
And if I remember correctly, the Path API was the only API which was
slightly "problematic". This should be much cleaner for us.

Kind regards,

William

> --
> You received this message because you are subscribed to a topic in the Google Groups "skia-discuss" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/skia-discuss/X0goEjIaQJc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to skia-discuss...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/skia-discuss/ebaccb8f-76b6-40ad-b2d8-c93a70ad8bf2n%40googlegroups.com.