it appears that CPU-specific sources such as SkOpts_avx.cpp pull in generic
code that may cause illegal instruction crashes.
We've had a crash reported[*] saying that SkRect::round() causes an illegal
instruction crash. We build Skia sources targetting only SSE2, but
disassembling the binary showed AVX instructions in SkRect::round(). A
possible explanation for what happens is that SkOpts_avx.cpp pulls in
SkRect.h header (SkOpts_avx.cpp -> SkOpts.h -> SkRasterPipeline.h ->
SkImageInfo.h -> SkRect.h), SkRect::round() is considered too large for
inlining so a weak copy is emitted built with AVX, and when the linker merges
weak symbols it happens to select the AVX-built copy as the one non-inline
copy of SkRect::round(), causing AVX code to be called from generic SSE2-only
Am I getting it right that code such as SkOpts_avx.cpp should not pull in
such generic code and that it is a bug that this happens for SkRect?