sksl minify supports mesh vertex and fragment?

[Hippo]

Is there any plan to make sksl minify support mesh vertex and fragment?

It works if I change the `gProgramKind` to `SkSL::ProgramKind::kMeshVertex` or `SkSL::ProgramKind::kMeshFragment` and provide definitions of `Attributes` and `Varyings`.

[John Stiles]

That's a good idea! Thank you for the suggestion. The next release of Skia will support minifying mesh shaders, by passing a `--meshfrag` or `--meshvert` flag to sksl-minify. 

This is implemented here: http://review.skia.org/755939 

Please let me know if this will work for your use case.

On Mon, Sep 11, 2023 at 7:20 AM Hippo <two...@gmail.com> wrote:

Is there any plan to make sksl minify support mesh vertex and fragment?

It works if I change the `gProgramKind` to `SkSL::ProgramKind::kMeshVertex` or `SkSL::ProgramKind::kMeshFragment` and provide definitions of `Attributes` and `Varyings`.

--
You received this message because you are subscribed to the Google Groups "skia-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to skia-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/skia-discuss/aeeb2026-89b8-4688-91d7-3d4643aecb46n%40googlegroups.com.

[Hippo]

Thanks! It works!

Maybe update the usage tip? It still shows `usage: sksl-minify <output> <input> [--frag|--vert|--compute|--shader|--colorfilter|--blender] [dependencies...]`.

[John Stiles]

Good catch. I'll update the usage string as well.

To view this discussion on the web visit https://groups.google.com/d/msgid/skia-discuss/6ccd1105-0132-44b0-992b-1085ffd2dbbdn%40googlegroups.com.