Assistance in upgrading from m112 to m113

50 views
Skip to first unread message

William Candillon

unread,
May 20, 2023, 8:37:33 AMMay 20
to skia-d...@googlegroups.com
Dear Skia Team,

I'm currently facing some difficulties while trying to upgrade our
application from Skia m112 to m113 on both iOS and Android platforms.
The specific arguments we use for building Skia can be found at this
link: https://gist.github.com/wcandillon/6af654363c567215ef1663bf02110db4

Post build, I've noticed that the `SkRuntimeEffect` type is no longer
available, along with backend specific functions like
`GrDirectContext::MakeMetal` and `GrDirectContext::MakeGL`.

Having reviewed the changelog, it seems that a significant
modification has been made regarding how the define SK_SUPPORT_GPU is
handled. I understand that it's now SK_GANESH, and the default
behavior has also been altered.

What I like to do in these kind of situations is to check the diff of
the change but also check how the build config for CanvasKit has been
adapted so that we know how we need to change our own build config.
These would be the two relevant commits:
* https://github.com/google/skia/commit/0f7b44ea2fdaf61cc683241476bae0f9f232f7b5
* https://github.com/google/skia/commit/40d29bfd33c33e97bb3c412c901fb7ecbede9594

Unfortunately, based on these diffs, I was unable to infer any
argument changes. I did attempt a build with `skia_enable_gpu=true`
and `skia_enable_ganesh=true` but without any success.

I'm hoping you could provide some guidance to help me navigate this
issue. Any pointers towards the right direction would be highly
appreciated.

Kind regards,

William

William Candillon

unread,
May 22, 2023, 2:06:02 AMMay 22
to skia-discuss
My apologies for the previous message, I had simply forgotten to add the -DSK_GANESH preprocessor directive.
Everything builds fine now.

Kind regards,

William

Reply all
Reply to author
Forward
0 new messages