skia: toplevel "make all" may start failing for you soon; consider using default target instead, or maybe 'everything'

20 views
Skip to first unread message

Elliot Poger

unread,
Oct 18, 2012, 12:41:59 PM10/18/12
to skia-d...@googlegroups.com, Thiago Farina, Eric Boren, Ben Wagner
Warning to Skia builders: if you use the toplevel "make all" command to build everything, it may start failing for you soon.  Just running "make" to get the default target (now "make most") should keep working just fine.

Details are in https://codereview.appspot.com/6651064/ ('gyp: generate "everything" and "most" targets instead of "all"'), but here's the summary:
  • Currently, "make all" doesn't really build everything.  It skips the "debugger" target, because that target requires you to have QT libraries installed on your system.
  • We think it's misleading for "make all" to not build everything, and we needed to change the "make all" behavior anyway because of http://code.google.com/p/skia/issues/detail?id=932 ('gyp automatically creates "all" target on some build flavors (ninja, make) but not others (xcode)')
  • The default target (now "make most") will build all targets that should be appropriate for most developers.  This is probably your best bet.
  • If you really want to build everything, use "make all".
  • Starting very soon, the toplevel "make all" will actually build a new "everything" target, so it doesn't conflict with gyp's sometimes-automatically-created "all" target.
If you have any questions, reply-to-all on this thread.

Elliot Poger

unread,
Oct 25, 2012, 12:41:16 PM10/25/12
to skia-d...@googlegroups.com, Thiago Farina, Eric Boren, Ben Wagner
As of https://code.google.com/p/skia/source/detail?r=6116 , Skia no longer explicitly defines an "all" target.  (We define an "everything" target instead.)

Running "make all" at the toplevel, on all platforms, will run the gyp process and then build the "everything" target.

If you run the gyp process and then manually build the resulting makefiles, you should probably build the "everything" target.  If gyp has automatically created an "all" target for your build flavor, you can use that too.
Reply all
Reply to author
Forward
0 new messages